Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Add controller testing for cms_page

Matthew Kennedycfd78c960d87
diff --git a/frontend/app/controllers/spree/cms_pages_controller.rb b/frontend/app/controllers/spree/cms_pages_controller.rb
index fca0c16d4c..7d7c07a03a 100644
--- a/frontend/app/controllers/spree/cms_pages_controller.rb
+++ b/frontend/app/controllers/spree/cms_pages_controller.rb
@@ -8,7 +8,7 @@ module Spree
def show
if @page&.visible?
@cms_page = @page
- elsif try_spree_current_user&.admin?
+ elsif @page&.draft_mode? && try_spree_current_user&.admin?
@cms_page = @page
@edit_mode = true
else
@@ -19,11 +19,7 @@ module Spree
private
def accurate_title
- if @page
- @page.seo_title
- else
- super
- end
+ @page.seo_title || super
end
def load_cms_page
diff --git a/frontend/spec/controllers/spree/cms_page_controller_spec.rb b/frontend/spec/controllers/spree/cms_page_controller_spec.rb
new file mode 100644
index 0000000000..7b8c7799e5
--- /dev/null
+++ b/frontend/spec/controllers/spree/cms_page_controller_spec.rb
@@ -0,0 +1,31 @@
+require 'spec_helper'
+
+describe Spree::CmsPagesController, type: :controller do
+ let!(:store) { create(:store, default: true, default_locale: 'en', default_currency: 'USD') }
+
+ describe '#show - when page is set the current store' do
+ let!(:cms_page) { create(:cms_standard_page, store: store, locale: 'en') }
+
+ it 'returns a successful response' do
+ get :show, params: { slug: cms_page.slug }
+ expect(response).to be_successful
+ end
+ end
+
+ describe '#show - when page is set the current store but visible false' do
+ let!(:cms_page_visible) { create(:cms_standard_page, store: store, locale: 'en', visible: false) }
+
+ it 'returns ActiveRecord::RecordNotFound' do
+ expect { get :show, params: { slug: cms_page_visible.slug } }.to raise_error ActiveRecord::RecordNotFound
+ end
+ end
+
+ describe '#show - when page is set for another store' do
+ let!(:store_b) { create(:store, default: false, default_locale: 'de', default_currency: 'EUR') }
+ let!(:cms_page_b) { create(:cms_standard_page, store: store_b, locale: 'de') }
+
+ it 'returns ActiveRecord::RecordNotFound' do
+ expect { get :show, params: { slug: cms_page_b.slug } }.to raise_error ActiveRecord::RecordNotFound
+ end
+ end
+end