Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

fix api account addresses scope (#11085)

Chien-Fud032c4d91a22
diff --git a/api/app/controllers/spree/api/v2/storefront/account/addresses_controller.rb b/api/app/controllers/spree/api/v2/storefront/account/addresses_controller.rb
index 70a859477a..77276f42f5 100644
--- a/api/app/controllers/spree/api/v2/storefront/account/addresses_controller.rb
+++ b/api/app/controllers/spree/api/v2/storefront/account/addresses_controller.rb
@@ -37,7 +37,7 @@ module Spree
end
def scope
- super.not_deleted
+ super.where(user: spree_current_user).not_deleted
end
def model_class
diff --git a/api/spec/requests/spree/api/v2/storefront/account/addresses_spec.rb b/api/spec/requests/spree/api/v2/storefront/account/addresses_spec.rb
index 1cf8151050..4fc09c1b70 100644
--- a/api/spec/requests/spree/api/v2/storefront/account/addresses_spec.rb
+++ b/api/spec/requests/spree/api/v2/storefront/account/addresses_spec.rb
@@ -32,6 +32,8 @@ describe 'Storefront API v2 Addresses spec', type: :request do
describe 'addresses#index' do
context 'without options' do
+ let!(:other_user) { create(:user_with_addresses) }
+
before { get '/api/v2/storefront/account/addresses', headers: headers_bearer }
it_behaves_like 'returns valid user addresses resource JSON'
@@ -39,6 +41,7 @@ describe 'Storefront API v2 Addresses spec', type: :request do
it 'returns all user addresses' do
expect(json_response['data'][0]).to have_type('address')
expect(json_response['data'].size).to eq(addresses.count)
+ expect(json_response['data'].size).not_to eq Spree::Address.count
end
end