Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.
Ruby b2b-commercee-commerceecommerceecommerce-apiecommerce-frameworkecommerce-platformheadlessheadless-commerceheadless-ecommercemarketplacemulti-tenantmulti-vendormulti-vendor-ecommerceopen-sourcespree-commerce
Fix: Keep variants visible after saving stock at a location (#14689)
Damian Legawiecd0ccb6a9d67a
diff --git a/packages/dashboard/src/components/spree/stock-levels-panel.tsx b/packages/dashboard/src/components/spree/stock-levels-panel.tsxindex 9d75dfd568..9bde30a484 100644--- a/packages/dashboard/src/components/spree/stock-levels-panel.tsx+++ b/packages/dashboard/src/components/spree/stock-levels-panel.tsx@@ -127,8 +127,8 @@ const LOW_STOCK_THRESHOLD = 5function groupItemsByProduct(items: StockLevel[], unknownProductLabel: string): StockLevelGroup[] {const map = new Map<string, StockLevelGroup>()for (const item of items) {- const productId = item.variant?.product_id ?? '__unknown__'- const productName = item.variant?.product_name ?? unknownProductLabel+ const productId = item.variant?.product_id ?? item.product_id ?? '__unknown__'+ const productName = item.variant?.product_name ?? item.variant_name ?? unknownProductLabellet group = map.get(productId)if (!group) {group = { productId, productName, items: [], hasLowStock: false }@@ -204,9 +204,9 @@ function StockLevelRow({ item }: { item: StockLevel }) {const dirty = count !== item.count_on_hand || backorderable !== item.backorderableconst variant = item.variant- const optionsText = variant?.options_text- const sku = variant?.sku- const productId = variant?.product_id+ const optionsText = variant?.options_text ?? item.options_text+ const sku = variant?.sku ?? item.variant_sku+ const productId = variant?.product_id ?? item.product_idconst variantLabel = optionsText || sku || t('admin.common.default')const isLowStock = count < LOW_STOCK_THRESHOLD && !backorderablediff --git a/packages/dashboard/src/hooks/use-stock-levels.test.ts b/packages/dashboard/src/hooks/use-stock-levels.test.tsnew file mode 100644index 0000000000..681c6ad6bc--- /dev/null+++ b/packages/dashboard/src/hooks/use-stock-levels.test.ts@@ -0,0 +1,74 @@+import type { StockLevel } from '@spree/admin-sdk'+import { describe, expect, it } from 'vitest'+import { mergeStockLevelUpdate } from './use-stock-levels'++function stockLevel(overrides: Partial<StockLevel> = {}): StockLevel {+ return {+ id: 'stlv_1',+ count_on_hand: 10,+ backorderable: false,+ stock_location_id: 'sloc_1',+ variant_id: 'variant_1',+ external_references: {},+ metadata: {},+ reserved_count: 0,+ incoming_count: 0,+ purchasable_count: 10,+ variant_name: 'T-Shirt',+ variant_sku: 'TS-001',+ created_at: '2026-01-01T00:00:00Z',+ updated_at: '2026-01-01T00:00:00Z',+ stock_location_name: 'Main',+ product_id: 'prod_1',+ options_text: 'Red / M',+ thumbnail_url: null,+ allocated_count: 0,+ available_count: 10,+ ...overrides,+ }+}++describe('mergeStockLevelUpdate', () => {+ it('applies updated counts while keeping the expanded variant from the list fetch', () => {+ const previous = stockLevel({+ count_on_hand: 10,+ variant: {+ id: 'variant_1',+ product_id: 'prod_1',+ product_name: 'T-Shirt',+ sku: 'TS-001',+ options_text: 'Red / M',+ } as StockLevel['variant'],+ })+ const updated = stockLevel({+ count_on_hand: 25,+ backorderable: true,+ updated_at: '2026-01-02T00:00:00Z',+ })++ const merged = mergeStockLevelUpdate(previous, updated)++ expect(merged.count_on_hand).toBe(25)+ expect(merged.backorderable).toBe(true)+ expect(merged.variant).toEqual(previous.variant)+ expect(merged.product_id).toBe('prod_1')+ })++ it('prefers an expanded variant on the update response when present', () => {+ const previous = stockLevel({+ variant: {+ id: 'variant_1',+ product_id: 'prod_1',+ product_name: 'Old name',+ } as StockLevel['variant'],+ })+ const refreshedVariant = {+ id: 'variant_1',+ product_id: 'prod_1',+ product_name: 'New name',+ } as StockLevel['variant']+ const updated = stockLevel({ variant: refreshedVariant })++ expect(mergeStockLevelUpdate(previous, updated).variant).toEqual(refreshedVariant)+ })+})diff --git a/packages/dashboard/src/hooks/use-stock-levels.ts b/packages/dashboard/src/hooks/use-stock-levels.tsindex d337327c83..babb0a69db 100644--- a/packages/dashboard/src/hooks/use-stock-levels.ts+++ b/packages/dashboard/src/hooks/use-stock-levels.ts@@ -15,6 +15,16 @@ interface UseStockLevelsParams {variant_sku_or_variant_product_name_cont?: string}+/** Preserve expanded associations when a PATCH response omits them. */+export function mergeStockLevelUpdate(previous: StockLevel, updated: StockLevel): StockLevel {+ return {+ ...previous,+ ...updated,+ variant: updated.variant ?? previous.variant,+ stock_location: updated.stock_location ?? previous.stock_location,+ }+}+export function useStockLevels(params: UseStockLevelsParams = {}) {return useQuery({queryKey: useResourceKey('stock-levels', params),@@ -61,7 +71,7 @@ export function useUpdateStockLevel(id: string, extraInvalidate: QueryKey[] = []if (index === -1) return cachedconst data = [...cached.data]- data[index] = updated+ data[index] = mergeStockLevelUpdate(cached.data[index], updated)return { ...cached, data }},)