Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Ensure linkable pages have slugs and are not of type homepage

Matthew Kennedyd43c71e59856
diff --git a/api/app/controllers/spree/api/v2/storefront/cms_pages_controller.rb b/api/app/controllers/spree/api/v2/storefront/cms_pages_controller.rb
index 2960bcae77..d0c1bbbe0d 100644
--- a/api/app/controllers/spree/api/v2/storefront/cms_pages_controller.rb
+++ b/api/app/controllers/spree/api/v2/storefront/cms_pages_controller.rb
@@ -22,7 +22,7 @@ module Spree
end
def scope
- super.by_store(current_store).by_locale(I18n.locale).linkable_pages
+ super.by_store(current_store).by_locale(I18n.locale).linkable
end
end
end
diff --git a/core/app/models/spree/cms_page.rb b/core/app/models/spree/cms_page.rb
index aa61147f55..293be727f8 100644
--- a/core/app/models/spree/cms_page.rb
+++ b/core/app/models/spree/cms_page.rb
@@ -18,10 +18,10 @@ module Spree
validates :title, presence: true
- scope :visible, -> { where visible: true }
+ scope :visible, -> { where(visible: true) }
scope :by_store, ->(store) { where(store: store) }
scope :by_locale, ->(locale) { where(locale: locale) }
- scope :linkable_pages, -> { where.not(type: 'Spree::Cms::Pages::Homepage') }
+ scope :linkable, -> { where.not(slug: nil, type: 'Spree::Cms::Pages::Homepage') }
self.whitelisted_ransackable_attributes = %w[title type]