Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Better quantity validation for `Spree::StockMovement` (#12239)

Damian Kaczmarczykd49741bbdee7
diff --git a/core/app/models/spree/stock_movement.rb b/core/app/models/spree/stock_movement.rb
index b2f0a2c854..69e88fb566 100644
--- a/core/app/models/spree/stock_movement.rb
+++ b/core/app/models/spree/stock_movement.rb
@@ -15,7 +15,7 @@ module Spree
with_options presence: true do
validates :stock_item
validates :quantity, numericality: {
- greater_than_or_equal_to: QUANTITY_LIMITS[:min],
+ greater_than_or_equal_to: :min_quantity,
less_than_or_equal_to: QUANTITY_LIMITS[:max],
only_integer: true
}
@@ -39,5 +39,11 @@ module Spree
stock_item.adjust_count_on_hand quantity
end
+
+ def min_quantity
+ return QUANTITY_LIMITS[:min] if stock_item.nil? || stock_item.backorderable?
+
+ -stock_item.count_on_hand
+ end
end
end
diff --git a/core/spec/models/spree/stock_movement_spec.rb b/core/spec/models/spree/stock_movement_spec.rb
index 84bd42318e..ee59c9ce62 100644
--- a/core/spec/models/spree/stock_movement_spec.rb
+++ b/core/spec/models/spree/stock_movement_spec.rb
@@ -15,6 +15,16 @@ describe Spree::StockMovement, type: :model do
end
end
+ describe 'validations' do
+ it "does not allow quantity that is less than the stock item's count on hand" do
+ stock_item = create(:stock_item, backorderable: false)
+ stock_movement = build(:stock_movement, quantity: -11, stock_item: stock_item)
+
+ expect(stock_movement).to be_invalid
+ expect(stock_movement.errors[:quantity]).to include('must be greater than or equal to -10')
+ end
+ end
+
describe 'Scope' do
describe '.recent' do
it 'orders chronologically by created at' do