Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

SD-1389 fix tests

KacperMekarskid8aabfb216fd
diff --git a/backend/spec/features/admin/menus/edit_menu_spec.rb b/backend/spec/features/admin/menus/edit_menu_spec.rb
index 257b51f733..e4143f1e22 100644
--- a/backend/spec/features/admin/menus/edit_menu_spec.rb
+++ b/backend/spec/features/admin/menus/edit_menu_spec.rb
@@ -4,7 +4,7 @@ describe 'Menu Edit', type: :feature do
stub_authorization!
let!(:main_menu) { create(:menu, name: 'Main Menu') }
- let!(:menu_item) { create(:menu_item, menu: main_menu, parent: main_menu.root) }
+ let!(:menu_item) { create(:menu_item, name: 'Link To Somewhere', menu: main_menu, parent: main_menu.root) }
let(:file_path) { Rails.root + '../../spec/support/ror_ringer.jpeg' }
context 'when link to URL the user can' do
diff --git a/core/spec/models/spree/menu_item_spec.rb b/core/spec/models/spree/menu_item_spec.rb
index 1d306a23fe..65ac2373eb 100644
--- a/core/spec/models/spree/menu_item_spec.rb
+++ b/core/spec/models/spree/menu_item_spec.rb
@@ -177,7 +177,7 @@ describe Spree::MenuItem, type: :model do
end
describe 'touch menu and store' do
- let(:menu_item) { build(:menu_item, menu: menu) }
+ let(:menu_item) { build(:menu_item, menu: menu, icon: nil) }
it 'touches menu' do
expect(menu).to receive(:touch)
diff --git a/frontend/spec/helpers/navigation_helper_spec.rb b/frontend/spec/helpers/navigation_helper_spec.rb
index 76a787f8bd..7665b3fd2d 100644
--- a/frontend/spec/helpers/navigation_helper_spec.rb
+++ b/frontend/spec/helpers/navigation_helper_spec.rb
@@ -40,7 +40,7 @@ module Spree
include Spree::LocaleHelper
context 'when link is passed with no arguments' do
- let(:menu_item) { create(:menu_item, menu: menu, destination: 'https://my-website.com') }
+ let(:menu_item) { create(:menu_item, name: 'Link To Somewhere', menu: menu, destination: 'https://my-website.com') }
it 'returns the link destination with no unexpected attributes' do
expect(spree_nav_link_tag(menu_item)).to eq('<a href="https://my-website.com">Link To Somewhere</a>')
@@ -48,7 +48,7 @@ module Spree
end
context 'when link is passed with setting to open in a new window' do
- let(:menu_item) { create(:menu_item, menu: menu, destination: 'https://my-website.com', new_window: true) }
+ let(:menu_item) { create(:menu_item, name: 'Link To Somewhere', menu: menu, destination: 'https://my-website.com', new_window: true) }
it 'returns the link destination with target="_blank" rel="noopener noreferrer"' do
expect(spree_nav_link_tag(menu_item)).to eq('<a target="_blank" rel="noopener noreferrer" href="https://my-website.com">Link To Somewhere</a>')
@@ -56,7 +56,7 @@ module Spree
end
context 'when link is passed with setting to open in a new window, and passed custom attributes' do
- let(:menu_item) { create(:menu_item, menu: menu, destination: 'https://my-website.com', new_window: true) }
+ let(:menu_item) { create(:menu_item, name: 'Link To Somewhere', menu: menu, destination: 'https://my-website.com', new_window: true) }
it 'returns the link destination with a full set of cutstom attributes' do
expect(spree_nav_link_tag(menu_item, { class: 'custom-class', id: 'custonId', target: '_not_so_blank', rel: 'related', data: 'custom-data', aria: 'custom-aria' })).