Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Added error reporting/logging when processing a row via CSV importer fails

Damian Legawiecdbd28b0e2e26
diff --git a/core/app/models/spree/import_row.rb b/core/app/models/spree/import_row.rb
index aca272b1bf..1c34a4be90 100644
--- a/core/app/models/spree/import_row.rb
+++ b/core/app/models/spree/import_row.rb
@@ -76,6 +76,7 @@ module Spree
self.item = import.row_processor_class.new(self).process!
complete!
rescue StandardError => e
+ Rails.error.report(e, handled: true, context: { import_row_id: id }, source: 'spree.core')
self.validation_errors = e.message
fail!
end
diff --git a/core/spec/models/spree/import_row_spec.rb b/core/spec/models/spree/import_row_spec.rb
index 8460ed53db..87da010fb1 100644
--- a/core/spec/models/spree/import_row_spec.rb
+++ b/core/spec/models/spree/import_row_spec.rb
@@ -213,6 +213,11 @@ RSpec.describe Spree::ImportRow, :job, type: :model do
import_row.process!
expect(import_row.validation_errors).to eq(error_message)
end
+
+ it 'reports the error to Rails.error' do
+ expect(Rails.error).to receive(:report).with(an_instance_of(StandardError), handled: true, context: { import_row_id: import_row.id }, source: 'spree.core')
+ import_row.process!
+ end
end
end
end