Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Fix promo migrations for MySQL (#12523)

Łukasz Adamczykdc892951c7c3
diff --git a/core/db/migrate/20250312202705_add_unique_index_on_promotion_rules_associations.rb b/core/db/migrate/20250312202705_add_unique_index_on_promotion_rules_associations.rb
index c8dceb2314..b5e5d9f5bc 100644
--- a/core/db/migrate/20250312202705_add_unique_index_on_promotion_rules_associations.rb
+++ b/core/db/migrate/20250312202705_add_unique_index_on_promotion_rules_associations.rb
@@ -1,34 +1,72 @@
class AddUniqueIndexOnPromotionRulesAssociations < ActiveRecord::Migration[7.2]
def change
- # Remove duplicate product promotion rules
- execute <<-SQL
- DELETE FROM spree_product_promotion_rules
- WHERE id NOT IN (
- SELECT MIN(id)
- FROM spree_product_promotion_rules
- GROUP BY product_id, promotion_rule_id
- );
- SQL
+ if ActiveRecord::Base.connection.adapter_name == 'Mysql2'
+ # Remove duplicate product promotion rules
+ execute <<-SQL
+ DELETE FROM spree_product_promotion_rules
+ WHERE id NOT IN (
+ SELECT mid FROM (
+ SELECT MIN(id) AS mid
+ FROM spree_product_promotion_rules
+ GROUP BY product_id, promotion_rule_id
+ ) AS min_ids
+ );
+ SQL
- # Remove duplicate taxon promotion rules
- execute <<-SQL
- DELETE FROM spree_promotion_rule_taxons
- WHERE id NOT IN (
- SELECT MIN(id)
- FROM spree_promotion_rule_taxons
- GROUP BY taxon_id, promotion_rule_id
- );
- SQL
+ # Remove duplicate taxon promotion rules
+ execute <<-SQL
+ DELETE FROM spree_promotion_rule_taxons
+ WHERE id NOT IN (
+ SELECT mid FROM (
+ SELECT MIN(id) AS mid
+ FROM spree_promotion_rule_taxons
+ GROUP BY taxon_id, promotion_rule_id
+ ) AS min_ids
+ );
+ SQL
- # Remove duplicate user promotion rules
- execute <<-SQL
- DELETE FROM spree_promotion_rule_users
- WHERE id NOT IN (
- SELECT MIN(id)
- FROM spree_promotion_rule_users
- GROUP BY user_id, promotion_rule_id
- );
- SQL
+ # Remove duplicate user promotion rules
+ execute <<-SQL
+ DELETE FROM spree_promotion_rule_users
+ WHERE id NOT IN (
+ SELECT mid FROM (
+ SELECT MIN(id) AS mid
+ FROM spree_promotion_rule_users
+ GROUP BY user_id, promotion_rule_id
+ ) AS min_ids
+ );
+ SQL
+ else
+ # Remove duplicate product promotion rules
+ execute <<-SQL
+ DELETE FROM spree_product_promotion_rules
+ WHERE id NOT IN (
+ SELECT MIN(id)
+ FROM spree_product_promotion_rules
+ GROUP BY product_id, promotion_rule_id
+ );
+ SQL
+
+ # Remove duplicate taxon promotion rules
+ execute <<-SQL
+ DELETE FROM spree_promotion_rule_taxons
+ WHERE id NOT IN (
+ SELECT MIN(id)
+ FROM spree_promotion_rule_taxons
+ GROUP BY taxon_id, promotion_rule_id
+ );
+ SQL
+
+ # Remove duplicate user promotion rules
+ execute <<-SQL
+ DELETE FROM spree_promotion_rule_users
+ WHERE id NOT IN (
+ SELECT MIN(id)
+ FROM spree_promotion_rule_users
+ GROUP BY user_id, promotion_rule_id
+ );
+ SQL
+ end
add_index :spree_product_promotion_rules, [:product_id, :promotion_rule_id], unique: true
add_index :spree_promotion_rule_taxons, [:taxon_id, :promotion_rule_id], unique: true
diff --git a/core/db/migrate/20250313175830_add_unique_index_on_promotion_action_line_items.rb b/core/db/migrate/20250313175830_add_unique_index_on_promotion_action_line_items.rb
index 126b70c5f4..6d345dcfaf 100644
--- a/core/db/migrate/20250313175830_add_unique_index_on_promotion_action_line_items.rb
+++ b/core/db/migrate/20250313175830_add_unique_index_on_promotion_action_line_items.rb
@@ -1,14 +1,28 @@
class AddUniqueIndexOnPromotionActionLineItems < ActiveRecord::Migration[7.2]
def change
- # Remove duplicate promotion action line items
- execute <<-SQL
- DELETE FROM spree_promotion_action_line_items
- WHERE id NOT IN (
- SELECT MIN(id)
- FROM spree_promotion_action_line_items
- GROUP BY promotion_action_id, variant_id
- );
- SQL
+ if ActiveRecord::Base.connection.adapter_name == 'Mysql2'
+ # Remove duplicate promotion action line items
+ execute <<-SQL
+ DELETE FROM spree_promotion_action_line_items
+ WHERE id NOT IN (
+ SELECT mid FROM (
+ SELECT MIN(id) AS mid
+ FROM spree_promotion_action_line_items
+ GROUP BY promotion_action_id, variant_id
+ ) AS min_ids
+ );
+ SQL
+ else
+ # Remove duplicate promotion action line items
+ execute <<-SQL
+ DELETE FROM spree_promotion_action_line_items
+ WHERE id NOT IN (
+ SELECT MIN(id)
+ FROM spree_promotion_action_line_items
+ GROUP BY promotion_action_id, variant_id
+ );
+ SQL
+ end
add_index :spree_promotion_action_line_items, [:promotion_action_id, :variant_id], unique: true
end