Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.
Ruby b2b-commercee-commerceecommerceecommerce-apiecommerce-frameworkecommerce-platformheadlessheadless-commerceheadless-ecommercemarketplacemulti-tenantmulti-vendormulti-vendor-ecommerceopen-sourcespree-commerce
Do not authorize admin when action forbidden (#11226)
Szymon Iwaczdd671408ccea
diff --git a/backend/app/controllers/spree/admin/errors_controller.rb b/backend/app/controllers/spree/admin/errors_controller.rbindex 8c28b755f4..1182704050 100644--- a/backend/app/controllers/spree/admin/errors_controller.rb+++ b/backend/app/controllers/spree/admin/errors_controller.rb@@ -1,6 +1,8 @@module Spreemodule Adminclass ErrorsController < BaseController+ skip_before_action :authorize_admin+def forbiddenrender status: 403enddiff --git a/backend/spec/controllers/spree/admin/errors_controller_spec.rb b/backend/spec/controllers/spree/admin/errors_controller_spec.rbnew file mode 100644index 0000000000..8ae7850541--- /dev/null+++ b/backend/spec/controllers/spree/admin/errors_controller_spec.rb@@ -0,0 +1,26 @@+require 'spec_helper'++describe Spree::Admin::ErrorsController, type: :controller do+ let(:user) { create(:user) }++ before { allow(controller).to receive_messages(spree_current_user: user) }++ context '#forbidden' do+ shared_context 'should be able to display forbidden page' do+ it do+ get :forbidden+ expect(response).to have_http_status(403)+ end+ end++ context 'user with admin role' do+ before { user.spree_roles << Spree::Role.find_or_create_by(name: 'admin') }++ it_behaves_like 'should be able to display forbidden page'+ end++ context 'user without admin role' do+ it_behaves_like 'should be able to display forbidden page'+ end+ end+end