Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Make completed carts readonly at the model level

Damian Legawiece26cb7d3db90
diff --git a/spree/api/app/controllers/concerns/spree/api/v3/order_lock.rb b/spree/api/app/controllers/concerns/spree/api/v3/order_lock.rb
index 87857a9ded..952fba0740 100644
--- a/spree/api/app/controllers/concerns/spree/api/v3/order_lock.rb
+++ b/spree/api/app/controllers/concerns/spree/api/v3/order_lock.rb
@@ -15,6 +15,10 @@ module Spree
order = @order || @parent || @cart
order.with_lock do
+ # Completed carts are readonly — nothing left to version-bump;
+ # the row lock alone still serializes the idempotent paths.
+ next yield if order.readonly?
+
# Persist increment within the transaction so reloads inside yield see the new version
new_version = order.lock_version + 1
order.update_column(:lock_version, new_version)
diff --git a/spree/core/app/models/spree/cart.rb b/spree/core/app/models/spree/cart.rb
index c22a7713d4..cd76c42336 100644
--- a/spree/core/app/models/spree/cart.rb
+++ b/spree/core/app/models/spree/cart.rb
@@ -147,6 +147,14 @@ module Spree
end
alias complete? completed?
+ # A completed cart is an immutable audit record — post-checkout life
+ # belongs to the order. Blocks save/update_columns/touch/destroy at the
+ # model level; the completion write itself passes because it fires while
+ # the persisted completed_at is still nil.
+ def readonly?
+ super || (completed_at.present? && !completed_at_changed?)
+ end
+
# @return [Boolean] whether a completion attempt currently holds this cart
def completing?
completing_at.present?
diff --git a/spree/core/spec/models/spree/cart_spec.rb b/spree/core/spec/models/spree/cart_spec.rb
index 4a08636f29..0c560a639b 100644
--- a/spree/core/spec/models/spree/cart_spec.rb
+++ b/spree/core/spec/models/spree/cart_spec.rb
@@ -1,6 +1,26 @@
require 'spec_helper'
describe Spree::Cart, type: :model do
+ describe 'readonly after completion' do
+ let(:cart) { create(:cart, store: @default_store) }
+
+ it 'rejects every write path once completed' do
+ cart.update_columns(completed_at: Time.current)
+
+ reloaded = Spree::Cart.find(cart.id)
+ expect(reloaded).to be_readonly
+ expect { reloaded.update!(email: '[email protected]') }.to raise_error(ActiveRecord::ReadOnlyRecord)
+ expect { reloaded.update_columns(email: '[email protected]') }.to raise_error(ActiveRecord::ReadOnlyRecord)
+ expect { reloaded.touch }.to raise_error(ActiveRecord::ReadOnlyRecord)
+ expect { reloaded.destroy }.to raise_error(ActiveRecord::ReadOnlyRecord)
+ end
+
+ it 'lets the completion write through and locks the instance after it' do
+ expect { cart.update_columns(completed_at: Time.current) }.not_to raise_error
+ expect(cart).to be_readonly
+ end
+ end
+
describe 'lifecycle' do
it 'generates a token on create' do
expect(create(:cart).token).to be_present