Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Fixed: error handler works without options passed (#12437)

Damian Legawiece386ec3d3004
diff --git a/core/app/services/spree/error_handler.rb b/core/app/services/spree/error_handler.rb
index b20010d691..1b7f0baad1 100644
--- a/core/app/services/spree/error_handler.rb
+++ b/core/app/services/spree/error_handler.rb
@@ -16,7 +16,7 @@ module Spree
protected
- def format_message(exception:, opts:)
+ def format_message(exception:, opts: {})
message = if exception.respond_to?(:original_message)
exception.original_message
else
@@ -26,7 +26,7 @@ module Spree
success(exception: exception, message: message, opts: opts)
end
- def log_error(exception:, message:, opts:)
+ def log_error(exception:, message:, opts: {})
Rails.logger.error message
Rails.logger.error "User ID: #{opts[:user]&.id}" if opts[:user]
Rails.logger.error exception.backtrace.join("\n") if exception.backtrace.present?
@@ -34,7 +34,7 @@ module Spree
success(exception: exception, message: message, opts: opts)
end
- def report_error(exception:, message:, opts:)
+ def report_error(exception:, message:, opts: {})
# overwrite this method in your application to support different error handlers
# eg. Sentry, Rollbar, etc
if defined?(Sentry)
diff --git a/core/spec/services/spree/error_handler_spec.rb b/core/spec/services/spree/error_handler_spec.rb
index bc8d995dfe..9d8e121515 100644
--- a/core/spec/services/spree/error_handler_spec.rb
+++ b/core/spec/services/spree/error_handler_spec.rb
@@ -21,4 +21,13 @@ RSpec.describe Spree::ErrorHandler do
expect(result.value).to eq({ exception: exception, message: message })
end
+
+ context 'without opts ' do
+ subject { described_class.call(exception: exception) }
+ let(:result) { subject }
+
+ it 'returns result with error' do
+ expect(result.value).to eq({ exception: exception, message: message })
+ end
+ end
end