Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Set Order Token cookie with `httponly` flag (#12744)

Damian Legawiece3bb62580644
diff --git a/core/lib/spree/core/controller_helpers/auth.rb b/core/lib/spree/core/controller_helpers/auth.rb
index 7fd983148d..53e299acb6 100644
--- a/core/lib/spree/core/controller_helpers/auth.rb
+++ b/core/lib/spree/core/controller_helpers/auth.rb
@@ -26,6 +26,7 @@ module Spree
end
def set_token
+ Spree::Deprecation.warn('set_token is deprecated and will be removed in Spree 5.2. Please use create_token_cookie(token) instead.')
cookies.permanent.signed[:token] ||= cookies.signed[:guest_token]
cookies.permanent.signed[:token] ||= {
value: generate_token,
diff --git a/core/lib/spree/core/controller_helpers/order.rb b/core/lib/spree/core/controller_helpers/order.rb
index c9bc749f7b..37833fef84 100644
--- a/core/lib/spree/core/controller_helpers/order.rb
+++ b/core/lib/spree/core/controller_helpers/order.rb
@@ -118,7 +118,8 @@ module Spree
value: token,
expires: 90.days.from_now,
secure: Rails.configuration.force_ssl || Rails.application.config.ssl_options[:secure_cookies],
- domain: current_store.url_or_custom_domain
+ domain: current_store.url_or_custom_domain,
+ httponly: true
}
end