Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.
Ruby b2b-commercee-commerceecommerceecommerce-apiecommerce-frameworkecommerce-platformheadlessheadless-commerceheadless-ecommercemarketplacemulti-tenantmulti-vendormulti-vendor-ecommerceopen-sourcespree-commerce
Start on menu item model spec.
Matthew Kennedye5dc08627998
diff --git a/core/app/models/spree/menu_item.rb b/core/app/models/spree/menu_item.rbindex 6bb8d764e6..3a13c3ff40 100644--- a/core/app/models/spree/menu_item.rb+++ b/core/app/models/spree/menu_item.rb@@ -14,7 +14,6 @@ module Spreehas_one_attached :image_asset- # Not frozen so they can be added toITEM_TYPE = %w[Link Promotion Container]LINKED_RESOURCE_TYPE = []@@ -25,6 +24,7 @@ module SpreeLINKED_RESOURCE_TYPE.push(*DYNAMIC_RESOURCE_TYPE)validates :name, presence: true+ validates :menu_id, presence: true, numericality: { only_integer: true }validates :item_type, inclusion: { in: ITEM_TYPE }validates :linked_resource_type, inclusion: { in: LINKED_RESOURCE_TYPE }diff --git a/core/spec/models/spree/menu_item_spec.rb b/core/spec/models/spree/menu_item_spec.rbnew file mode 100644index 0000000000..4889046498--- /dev/null+++ b/core/spec/models/spree/menu_item_spec.rb@@ -0,0 +1,62 @@+require 'spec_helper'++describe Spree::MenuItem, type: :model do+ describe 'validates name' do+ let!(:menu) { create(:menu, name: 'Main Menu') }++ it 'returns presence error when no name is given' do+ expect(described_class.new(name: '', menu_id: menu.id, item_type: 'Link')).not_to be_valid+ end+ end++ describe 'validates menu_id presence and integer_only' do+ let!(:menu) { create(:menu, name: 'Main Menu') }++ it 'returns error when no menu id is passed' do+ expect(described_class.new(name: 'Main Menu', item_type: 'Link')).not_to be_valid+ end++ it 'returns error when no menu id is not an integer' do+ expect(described_class.new(name: 'Main Menu', menu_id: 'string', item_type: 'Link')).not_to be_valid+ end++ it 'returns success when no menu id an integer' do+ expect(described_class.new(name: 'Main Menu', item_type: 'Link', menu_id: menu.id)).to be_valid+ end+ end++ describe 'validates item_type' do+ let!(:menu) { create(:menu, name: 'Main Menu') }++ it 'returns error when the item_type is not in the list' do+ expect(described_class.new(name: 'Main Menu', menu_id: menu.id, item_type: 'Linkker')).not_to be_valid+ end+ end++ describe 'validates linked_resource_type' do+ let!(:menu) { create(:menu, name: 'Main Menu') }++ it 'returns error when the linked_resource_type is not in the list' do+ expect(described_class.new(name: 'Main Menu', menu_id: menu.id, item_type: 'Link', linked_resource_type: 'Purple')).not_to be_valid+ end+ end++ describe '.destination' do+ let!(:taxon) { create(:taxon) }+ let!(:product) { create(:product) }+ let!(:menu) { create(:menu, name: 'Main Menu') }++ let!(:menu_item_url) { create(:menu_item, menu_id: menu.id, linked_resource_type: 'URL', url: 'https://test.the.link.com') }+ let!(:menu_item_home_page) { create(:menu_item, menu_id: menu.id, linked_resource_type: 'Home Page') }+ let!(:menu_item_product) { create(:menu_item, menu_id: menu.id, linked_resource_type: 'Spree::Product', linked_resource_id: product.id) }+ let!(:menu_item_taxon) { create(:menu_item, menu_id: menu.id, linked_resource_type: 'Spree::Taxon', linked_resource_id: taxon.id) }++ it 'returns url when type is URL' do+ expect(menu_item_url.destination).to eq(menu_item_url.url)+ end++ # it 'returns product path when type is Spree::Product' do+ # expect(menu_item_product.destination).to eq()+ # end+ end+enddiff --git a/core/spec/models/spree/menu_spec.rb b/core/spec/models/spree/menu_spec.rbindex 6684038d8a..c9a6816c4f 100644--- a/core/spec/models/spree/menu_spec.rb+++ b/core/spec/models/spree/menu_spec.rb@@ -9,11 +9,8 @@ describe Spree::Menu, type: :model dolet!(:menu) { create(:menu, store_ids: [store_1.id, store_3.id]) }it 'returns menu if they are avalable to the store' do- by_store_1 = described_class.by_store(store_1.id)- by_store_2 = described_class.by_store(store_2.id)-- expect(by_store_1).to include(menu)- expect(by_store_2).not_to include(menu)+ expect(described_class.by_store(store_1.id)).to include(menu)+ expect(described_class.by_store(store_2.id)).not_to include(menu)endend@@ -22,14 +19,12 @@ describe Spree::Menu, type: :model dolet!(:menu_2) { create(:menu, name: 'Header') }it 'returns a menu when searched for by name' do- by_name_1 = described_class.by_name(menu_1.name)-- expect(by_name_1).to include(menu_1)- expect(by_name_1).not_to include(menu_2)+ expect(described_class.by_name(menu_1.name)).to include(menu_1)+ expect(described_class.by_name(menu_1.name)).not_to include(menu_2)endend- describe 'validates uniqueness' do+ describe 'validates uniqueness of name' dolet!(:menu_1) { create(:menu, name: 'Footer') }it 'returns uniqueness error' dodiff --git a/core/spec/spec_helper.rb b/core/spec/spec_helper.rbindex 250b7798b1..a5abec4abc 100644--- a/core/spec/spec_helper.rb+++ b/core/spec/spec_helper.rb@@ -69,6 +69,7 @@ RSpec.configure do |config|config.include FactoryBot::Syntax::Methodsconfig.include Spree::TestingSupport::Preferences+ config.include Spree::TestingSupport::UrlHelpersconfig.include Spree::TestingSupport::Kernel# Clean out the database state before the tests run