Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Fixed labels for product taxon and generic filters (#12565)

Łukasz Adamczyke668a0bf44e5
diff --git a/storefront/app/views/themes/default/spree/products/filters/_generic.html.erb b/storefront/app/views/themes/default/spree/products/filters/_generic.html.erb
index 0a8f560c0f..94458c6375 100644
--- a/storefront/app/views/themes/default/spree/products/filters/_generic.html.erb
+++ b/storefront/app/views/themes/default/spree/products/filters/_generic.html.erb
@@ -28,10 +28,13 @@
<li>
<%= f.label "filter_options_#{filter.name}_#{option.name}", class: "flex items-center gap-2 cursor-pointer group text-sm h-10", data: { searchable_list_target: "item", text: option.name } do %>
<%= f.check_box "filter[options][#{filter.name}][]",
- { checked: permitted_products_params.dig(:filter, :options, filter.name)&.include?(option.name),
- class: "input-checkbox group-focus-within:outline" },
- option.name,
- nil %>
+ {
+ id: "filter_options_#{filter.name}_#{option.name}",
+ checked: permitted_products_params.dig(:filter, :options, filter.name)&.include?(option.name),
+ class: "input-checkbox group-focus-within:outline"
+ },
+ option.name,
+ nil %>
<%= option.presentation %>
<span class="opacity-50">
(<%= products_count_for_filter(filter.name, option.id) %>)
@@ -46,10 +49,13 @@
<li class="px-4 lg:px-10">
<%= f.label "filter_options_#{filter.name}_#{option.name}", class: "flex items-center gap-2 cursor-pointer group text-sm h-10", data: { searchable_list_target: "item", text: option.name } do %>
<%= f.check_box "filter[options][#{filter.name}][]",
- { checked: permitted_products_params.dig(:filter, :options, filter.name)&.include?(option.name),
- class: "input-checkbox group-focus-within:outline" },
- option.name,
- nil %>
+ {
+ id: "filter_options_#{filter.name}_#{option.name}",
+ checked: permitted_products_params.dig(:filter, :options, filter.name)&.include?(option.name),
+ class: "input-checkbox group-focus-within:outline"
+ },
+ option.name,
+ nil %>
<%= option.presentation %>
<span class="opacity-50">
(<%= products_count_for_filter(filter.name, option.id) %>)
diff --git a/storefront/app/views/themes/default/spree/products/filters/_taxons.erb b/storefront/app/views/themes/default/spree/products/filters/_taxons.erb
index 34674ba660..aebd09398f 100644
--- a/storefront/app/views/themes/default/spree/products/filters/_taxons.erb
+++ b/storefront/app/views/themes/default/spree/products/filters/_taxons.erb
@@ -29,6 +29,7 @@
<%= f.label "filter_taxon_#{taxon.id}", class: "flex items-center gap-2 cursor-pointer group text-sm h-10", data: { searchable_list_target: "item", text: taxon.name } do %>
<%= f.check_box "filter[taxon_ids][]",
{
+ id: "filter_taxon_#{taxon.id}",
checked: permitted_products_params.dig(:filter, :taxon_ids)&.include?(taxon.id.to_s),
class: "input-checkbox group-focus-within:outline"
},
@@ -50,6 +51,7 @@
<%= f.label "filter_taxon_#{taxon.id}", class: "flex items-center gap-2 cursor-pointer group text-sm h-10", data: { searchable_list_target: "item", text: taxon.name } do %>
<%= f.check_box "filter[taxon_ids][]",
{
+ id: "filter_taxon_#{taxon.id}",
checked: permitted_products_params.dig(:filter, :taxon_ids)&.include?(taxon.id.to_s),
class: "input-checkbox group-focus-within:outline"
},