Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Add SubscriberSerializer spec. update/elete actions.

Sebastian Palmae7d2e8d39a65
diff --git a/api/app/serializers/concerns/spree/api/v2/resource_serializer_concern.rb b/api/app/serializers/concerns/spree/api/v2/resource_serializer_concern.rb
index a53b2ac522..d29f3fffb0 100644
--- a/api/app/serializers/concerns/spree/api/v2/resource_serializer_concern.rb
+++ b/api/app/serializers/concerns/spree/api/v2/resource_serializer_concern.rb
@@ -5,7 +5,8 @@ module Spree
extend ActiveSupport::Concern
def self.included(base)
- model_klazz = "Spree::#{base.to_s.demodulize.gsub(/Serializer/, '')}".constantize
+ serializer_base_name = base.to_s.sub(/^Spree::Api::V2::Platform::/, '').sub(/Serializer$/, '')
+ model_klazz = "Spree::#{serializer_base_name}".constantize
base.set_type model_klazz.json_api_type
# include standard attributes
diff --git a/api/app/serializers/spree/api/v2/platform/webhooks/subscriber_serializer.rb b/api/app/serializers/spree/api/v2/platform/webhooks/subscriber_serializer.rb
index 701acc9fab..63b82f4ab6 100644
--- a/api/app/serializers/spree/api/v2/platform/webhooks/subscriber_serializer.rb
+++ b/api/app/serializers/spree/api/v2/platform/webhooks/subscriber_serializer.rb
@@ -4,9 +4,7 @@ module Spree
module Platform
module Webhooks
class SubscriberSerializer < BaseSerializer
- set_type :webhooks_subscriber
-
- attributes :active, :url, :subscriptions
+ include ResourceSerializerConcern
end
end
end
diff --git a/api/config/routes.rb b/api/config/routes.rb
index 2656f424f3..846a01cf36 100644
--- a/api/config/routes.rb
+++ b/api/config/routes.rb
@@ -314,8 +314,9 @@ Spree::Core::Engine.add_routes do
# Configurations API
resources :shipping_categories
+ # Webhooks API
namespace :webhooks do
- resources :subscribers, only: %i[create index show]
+ resources :subscribers
end
end
end
diff --git a/api/spec/factories/spree/webhooks/subscriber_factory.rb b/api/spec/factories/spree/webhooks/subscriber_factory.rb
index f7979b4058..c9251d3d52 100644
--- a/api/spec/factories/spree/webhooks/subscriber_factory.rb
+++ b/api/spec/factories/spree/webhooks/subscriber_factory.rb
@@ -1,8 +1,9 @@
FactoryBot.define do
factory :webhook_subscriber, aliases: [:subscriber], class: Spree::Webhooks::Subscriber do
+ sequence(:url) { |n| "https://www.url#{n}.com/" }
+
trait :active do
active { true }
- sequence(:url) { |n| "https://www.url#{n}.com/" }
end
end
end
diff --git a/api/spec/integration/api/v2/platform/webhooks/subscribers_spec.rb b/api/spec/integration/api/v2/platform/webhooks/subscribers_spec.rb
index de46b3a40d..a8276b6097 100644
--- a/api/spec/integration/api/v2/platform/webhooks/subscribers_spec.rb
+++ b/api/spec/integration/api/v2/platform/webhooks/subscribers_spec.rb
@@ -12,6 +12,7 @@ describe 'WebhooksSubscribers API', swagger: true do
let(:records_list) { create_list(:subscriber, 2, :active, subscriptions: ['*']) }
let(:subscriber) { build(:subscriber, :active, subscriptions: ['*']) }
let(:valid_create_param_value) { subscriber.attributes }
+ let(:valid_update_param_value) { { active: true } }
path '/api/v2/platform/webhooks/subscribers' do
include_examples 'GET records list', resource_name, options
@@ -20,5 +21,7 @@ describe 'WebhooksSubscribers API', swagger: true do
path '/api/v2/platform/webhooks/subscribers/{id}' do
include_examples 'GET record', resource_name, options
+ include_examples 'PATCH update record', resource_name, options
+ include_examples 'DELETE record', resource_name, options
end
end
diff --git a/api/spec/serializers/spree/api/v2/platform/webhooks/subscriber_serializer_spec.rb b/api/spec/serializers/spree/api/v2/platform/webhooks/subscriber_serializer_spec.rb
new file mode 100644
index 0000000000..b9bad664bd
--- /dev/null
+++ b/api/spec/serializers/spree/api/v2/platform/webhooks/subscriber_serializer_spec.rb
@@ -0,0 +1,26 @@
+require 'spec_helper'
+
+describe Spree::Api::V2::Platform::Webhooks::SubscriberSerializer do
+ include_context 'API v2 serializers params'
+
+ subject { described_class.new(resource, params: serializer_params).serializable_hash }
+
+ let(:resource) { create(:subscriber) }
+ let(:type) { :subscriber }
+
+ it do
+ expect(subject).to eq(
+ data: {
+ id: resource.id.to_s,
+ type: type,
+ attributes: {
+ active: resource.active,
+ created_at: resource.created_at,
+ subscriptions: resource.subscriptions,
+ updated_at: resource.updated_at,
+ url: resource.url
+ }
+ }
+ )
+ end
+end