Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Add api only factories.

Sebastian Palmae8895aa56f40
diff --git a/api/spec/factories/spree/webhooks/subscriber_factory.rb b/api/spec/factories/spree/webhooks/subscriber_factory.rb
new file mode 100644
index 0000000000..f7979b4058
--- /dev/null
+++ b/api/spec/factories/spree/webhooks/subscriber_factory.rb
@@ -0,0 +1,8 @@
+FactoryBot.define do
+ factory :webhook_subscriber, aliases: [:subscriber], class: Spree::Webhooks::Subscriber do
+ trait :active do
+ active { true }
+ sequence(:url) { |n| "https://www.url#{n}.com/" }
+ end
+ end
+end
diff --git a/api/spec/integration/api/v2/platform/webhooks/subscribers_spec.rb b/api/spec/integration/api/v2/platform/webhooks/subscribers_spec.rb
index a17f6e92f0..de46b3a40d 100644
--- a/api/spec/integration/api/v2/platform/webhooks/subscribers_spec.rb
+++ b/api/spec/integration/api/v2/platform/webhooks/subscribers_spec.rb
@@ -1,17 +1,6 @@
require 'swagger_helper'
require 'spec_helper'
-# [TODO]: move
-FactoryBot.define do
- factory :webhook_subscriber, aliases: [:subscriber], class: Spree::Webhooks::Subscriber do
- trait :active do
- active { true }
- sequence(:url) { |n| "https://www.url#{n}.com/" }
- end
- end
-end
-
-
describe 'WebhooksSubscribers API', swagger: true do
include_context 'Platform API v2'
diff --git a/api/spec/services/spree/webhooks/subscribers/queue_requests_spec.rb b/api/spec/services/spree/webhooks/subscribers/queue_requests_spec.rb
index 99bf120ef1..e6365ded86 100644
--- a/api/spec/services/spree/webhooks/subscribers/queue_requests_spec.rb
+++ b/api/spec/services/spree/webhooks/subscribers/queue_requests_spec.rb
@@ -20,11 +20,7 @@ describe Spree::Webhooks::Subscribers::QueueRequests, :job, :spree_webhooks do
before { stub_request(:post, subscriber.url) }
let(:subscriber) do
- Spree::Webhooks::Subscriber.create(
- url: 'https://url1.com/',
- subscriptions: ['*'],
- active: true
- )
+ create(:subscriber, :active, url: 'https://url1.com/', subscriptions: ['*'])
end
it 'queues a job to make a request' do
@@ -38,11 +34,7 @@ describe Spree::Webhooks::Subscribers::QueueRequests, :job, :spree_webhooks do
before { stub_request(:post, subscriber.url) }
let(:subscriber) do
- Spree::Webhooks::Subscriber.create(
- url: 'https://url2.com/',
- subscriptions: [event],
- active: true
- )
+ create(:subscriber, :active, url: 'https://url2.com/', subscriptions: [event])
end
it 'queues a job to make a request' do
@@ -54,11 +46,7 @@ describe Spree::Webhooks::Subscribers::QueueRequests, :job, :spree_webhooks do
context 'when subscriber subscriptions are not active' do
let!(:subscriber) do
- Spree::Webhooks::Subscriber.create(
- url: 'https://url3.com/',
- subscriptions: [event],
- active: false
- )
+ create(:subscriber, url: 'https://url3.com/', subscriptions: [event])
end
it 'does not queue a job to make a request' do
@@ -68,11 +56,7 @@ describe Spree::Webhooks::Subscribers::QueueRequests, :job, :spree_webhooks do
context 'when subscriber subscriptions do not include the event or "*"' do
let!(:subscriber) do
- Spree::Webhooks::Subscriber.create(
- url: 'https://url4.com/',
- subscriptions: ['order.resume'],
- active: true
- )
+ create(:subscriber, :active, url: 'https://url4.com/', subscriptions: ['order.resume'])
end
it 'does not queue a job to make a request' do
diff --git a/api/spec/spec_helper.rb b/api/spec/spec_helper.rb
index 9a6ff3ae65..afe3552366 100644
--- a/api/spec/spec_helper.rb
+++ b/api/spec/spec_helper.rb
@@ -50,6 +50,11 @@ require 'spree/api/testing_support/v2/current_order'
require 'spree/api/testing_support/v2/platform_contexts'
require 'spree/api/testing_support/v2/serializers_params'
+# load api only factories
+Dir["#{File.dirname(__FILE__)}/factories/**/*.rb"].each do |f|
+ load File.expand_path(f)
+end
+
RSpec.configure do |config|
config.backtrace_exclusion_patterns = [/gems\/activesupport/, /gems\/actionpack/, /gems\/rspec/]
config.color = true