Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Update JavaScript

Matthew Kennedyec695204484a
diff --git a/backend/app/assets/javascripts/spree/backend/cms/page.es6 b/backend/app/assets/javascripts/spree/backend/cms/page.es6
index 0a7d885b1b..a7d3f0c76c 100644
--- a/backend/app/assets/javascripts/spree/backend/cms/page.es6
+++ b/backend/app/assets/javascripts/spree/backend/cms/page.es6
@@ -1,12 +1,11 @@
document.addEventListener('DOMContentLoaded', function() {
+ const pageVisabilityAttribute = document.querySelectorAll('[data-cms-page-id]')
const pageTypeSelector = document.getElementById('cms_page_type')
const el = document.getElementById('cmsPagesectionsArea')
- if (pageTypeSelector) { updateCmsPageType() }
+ if (pageTypeSelector) updateCmsPageType()
- $(pageTypeSelector).on('change', function() {
- updateCmsPageType()
- });
+ $(pageTypeSelector).on('change', function() { updateCmsPageType() })
if (el) {
Sortable.create(el, {
@@ -16,21 +15,20 @@ document.addEventListener('DOMContentLoaded', function() {
easing: 'cubic-bezier(1, 0, 0, 1)',
swapThreshold: 0.9,
forceFallback: true,
- onEnd: function (evt) {
+ onEnd: function(evt) {
handleSectionReposition(evt)
}
})
}
- const pageVisabilityAttribute = document.querySelectorAll('[data-cms-page-id]')
- pageVisabilityAttribute.forEach(function (elem) {
- elem.addEventListener('change', function () {
- handleToggleVisibility(this)
+ pageVisabilityAttribute.forEach(function(elem) {
+ elem.addEventListener('change', function() {
+ handleTogglePageVisibility(this)
})
})
})
-function handleToggleVisibility(obj) {
+function handleTogglePageVisibility(obj) {
const pageId = parseInt(obj.dataset.cmsPageId, 10)
const data = { page_id: pageId }
@@ -47,15 +45,14 @@ function handleToggleVisibility(obj) {
reloadPreview()
toggleVisibilityState(obj)
} else {
- handleMenuItemMoveError()
+ // eslint-disable-next-line no-undef
+ spreeHandleApiRequestError(response)
}
})
- .catch(err => {
- console.error(err);
- });
+ .catch(err => { console.error(err) })
}
-function toggleVisibilityState (obj) {
+function toggleVisibilityState(obj) {
const statusHolder = document.getElementById('visibilityStatus')
const pageHidden = statusHolder.querySelector('.page_hidden')
@@ -66,7 +63,7 @@ function toggleVisibilityState (obj) {
}
}
-function reloadPreview () {
+function reloadPreview() {
const liveLiewArea = document.getElementById('pageLivePreview')
if (!liveLiewArea) return
@@ -92,20 +89,14 @@ function handleSectionReposition(evt) {
if (response.ok) {
reloadPreview()
} else {
- handleMenuItemMoveError()
+ // eslint-disable-next-line no-undef
+ spreeHandleApiRequestError(response.status)
}
})
- .catch(err => {
- console.error(err);
- });
-}
-
-function handleMenuItemMoveError () {
- // eslint-disable-next-line no-undef
- show_flash('error', Spree.translations.move_could_not_be_saved)
+ .catch(err => { console.error(err) })
}
-function updateCmsPageType () {
+function updateCmsPageType() {
const slugField = document.getElementById('cms_page_slug')
const updatePageType = document.getElementById('updatePageType')
diff --git a/backend/app/assets/javascripts/spree/backend/global/_index.js b/backend/app/assets/javascripts/spree/backend/global/_index.js
index 1918405af7..2a19ce32c5 100644
--- a/backend/app/assets/javascripts/spree/backend/global/_index.js
+++ b/backend/app/assets/javascripts/spree/backend/global/_index.js
@@ -1,4 +1,5 @@
//= require spree/backend/global/alerts
+//= require spree/backend/global/api_functions
//= require spree/backend/global/bootstrap
//= require spree/backend/global/flatpickr
//= require spree/backend/global/ransack
diff --git a/backend/app/assets/javascripts/spree/backend/global/api_functions.es6 b/backend/app/assets/javascripts/spree/backend/global/api_functions.es6
new file mode 100644
index 0000000000..2e0122be77
--- /dev/null
+++ b/backend/app/assets/javascripts/spree/backend/global/api_functions.es6
@@ -0,0 +1,5 @@
+// eslint-disable-next-line no-unused-vars
+function spreeHandleApiRequestError (response) {
+ // eslint-disable-next-line no-undef
+ show_flash('error', `API Error: ${response}`)
+}