Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.
Ruby b2b-commercee-commerceecommerceecommerce-apiecommerce-frameworkecommerce-platformheadlessheadless-commerceheadless-ecommercemarketplacemulti-tenantmulti-vendormulti-vendor-ecommerceopen-sourcespree-commerce
Auto-generate gift card codes when not provided (#13987)
Damian Legawiecefa5d3ef2861
diff --git a/spree/admin/app/views/spree/admin/gift_cards/_form.html.erb b/spree/admin/app/views/spree/admin/gift_cards/_form.html.erbindex c0b926c5f6..ad817c4c40 100644--- a/spree/admin/app/views/spree/admin/gift_cards/_form.html.erb+++ b/spree/admin/app/views/spree/admin/gift_cards/_form.html.erb@@ -1,7 +1,7 @@<div class="card mb-6"><div class="card-body"><% unless f.object.persisted? %>- <%= f.spree_text_field :code, required: true, help_bubble: Spree.t('admin.gift_cards.code_help_text'), autofocus: true %>+ <%= f.spree_text_field :code, help_bubble: Spree.t('admin.gift_cards.code_help_text'), autofocus: true %><% end %><%= f.spree_money_field :amount, currency: f.object.currency, required: true %>diff --git a/spree/admin/spec/controllers/spree/admin/gift_cards_controller_spec.rb b/spree/admin/spec/controllers/spree/admin/gift_cards_controller_spec.rbindex f5e4a8c697..938f133532 100644--- a/spree/admin/spec/controllers/spree/admin/gift_cards_controller_spec.rb+++ b/spree/admin/spec/controllers/spree/admin/gift_cards_controller_spec.rb@@ -186,6 +186,27 @@ describe Spree::Admin::GiftCardsController, type: :controller doendend+ context 'with blank code' do+ let(:params_without_code) do+ {+ gift_card: {+ amount: 100,+ currency: 'EUR',+ user_id: user.id,+ expires_at: 1.year.from_now.to_date,+ code: ''+ }+ }+ end++ subject { post :create, params: params_without_code }++ it 'creates a gift card with an auto-generated code' do+ expect { subject }.to change(Spree::GiftCard, :count).by(1)+ expect(Spree::GiftCard.last.code).to be_present+ end+ end+context 'with invalid parameters' dolet(:invalid_params) do{diff --git a/spree/core/spec/models/spree/gift_card_spec.rb b/spree/core/spec/models/spree/gift_card_spec.rbindex 1ad8253636..0c7e5ebe35 100644--- a/spree/core/spec/models/spree/gift_card_spec.rb+++ b/spree/core/spec/models/spree/gift_card_spec.rb@@ -6,6 +6,26 @@ RSpec.describe Spree::GiftCard, type: :model doit_behaves_like 'lifecycle events'describe 'Callbacks' do+ describe '#generate_code' do+ it 'generates a code when blank' do+ gift_card = build(:gift_card, code: nil)+ gift_card.valid?+ expect(gift_card.code).to be_present+ end++ it 'generates a code when blank string is given' do+ gift_card = build(:gift_card, code: '')+ gift_card.valid?+ expect(gift_card.code).to be_present+ end++ it 'preserves the provided code when present' do+ gift_card = build(:gift_card, code: 'mycode123')+ gift_card.valid?+ expect(gift_card.code).to eq('mycode123')+ end+ end+describe '#ensure_can_be_deleted' doit "ensures a used gift card can't be destroyed" doexpect(create(:gift_card, state: :redeemed).destroy).to be(false)