Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Apply code reviews.

Matthew Kennedyefc063a25d86
diff --git a/core/app/models/spree/digital.rb b/core/app/models/spree/digital.rb
index c335088691..d906406391 100644
--- a/core/app/models/spree/digital.rb
+++ b/core/app/models/spree/digital.rb
@@ -1,5 +1,5 @@
module Spree
- class Digital < ActiveRecord::Base
+ class Digital < Spree::Base
belongs_to :variant
has_many :digital_links, dependent: :destroy
diff --git a/core/app/models/spree/digital_link.rb b/core/app/models/spree/digital_link.rb
index b184a866ff..5723fa71aa 100644
--- a/core/app/models/spree/digital_link.rb
+++ b/core/app/models/spree/digital_link.rb
@@ -1,5 +1,5 @@
module Spree
- class DigitalLink < ActiveRecord::Base
+ class DigitalLink < Spree::Base
belongs_to :digital
validates :digital, presence: true
diff --git a/core/app/models/spree/variant.rb b/core/app/models/spree/variant.rb
index 2ceb2f6b3c..4b6920a0bc 100644
--- a/core/app/models/spree/variant.rb
+++ b/core/app/models/spree/variant.rb
@@ -60,7 +60,6 @@ module Spree
after_create :create_stock_items
after_create :set_master_out_of_stock, unless: :is_master?
- after_save :destroy_digital, if: :deleted?
after_touch :clear_in_stock_cache
@@ -311,15 +310,6 @@ module Spree
private
- # :dependent => :destroy needs to be handled manually
- # spree does not delete variants, just marks them as deleted?
- # optionally keep digitals around for customers who require continued access to their purchases
- def destroy_digital
- return if Spree::DigitalConfiguration[:keep_digitals]
-
- digitals.map(&:destroy)
- end
-
def ensure_no_line_items
if line_items.any?
errors.add(:base, :cannot_destroy_if_attached_to_line_items)