Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Nesting works as it should from API requests.

Matthew Kennedyf2d950c06ed3
diff --git a/api/spec/requests/spree/api/v2/platform/menu_item_spec.rb b/api/spec/requests/spree/api/v2/platform/menu_item_spec.rb
index ce7cf6e807..d4001b8d27 100644
--- a/api/spec/requests/spree/api/v2/platform/menu_item_spec.rb
+++ b/api/spec/requests/spree/api/v2/platform/menu_item_spec.rb
@@ -5,10 +5,10 @@ describe 'Platform API v2 Menu Items spec', type: :request do
include_context 'Platform API v2'
let!(:store) { create(:store, default: true) }
- let!(:menu) { create(:menu, store_id: store.id) }
- let!(:menu_item_a) { create(:menu_item, menu_id: menu.id) }
- let!(:menu_item_b) { create(:menu_item, menu_id: menu.id) }
- let!(:menu_item_c) { create(:menu_item, menu_id: menu.id, parent_id: menu_item_b.id) }
+ let!(:menu) { create(:menu, store: store) }
+ let!(:menu_item_a) { create(:menu_item, menu: menu) }
+ let!(:menu_item_b) { create(:menu_item, menu: menu) }
+ let!(:menu_item_c) { create(:menu_item, menu: menu, parent: menu_item_b) }
let(:bearer_token) { { 'Authorization' => valid_authorization } }
describe 'menu_item#reposition' do
@@ -26,7 +26,7 @@ describe 'Platform API v2 Menu Items spec', type: :request do
let(:params) { { moved_item_id: menu_item_a.id, new_parent_id: menu_item_b.id, new_position_idx: 0 } }
before do
- patch "/api/v2/platform/menu_items/reposition", headers: bearer_token, params: params
+ patch '/api/v2/platform/menu_items/reposition', headers: bearer_token, params: params
end
it_behaves_like 'returns 204 HTTP status'
@@ -34,7 +34,11 @@ describe 'Platform API v2 Menu Items spec', type: :request do
it 'can be nested inside another item' do
menu_item_a.reload
expect(menu_item_a.parent_id).to eq(menu_item_b.id)
- expect(menu_item_a.depth).to eq(1)
+
+ # Root depth = 0
+ # Menu Item B depth = 1 (created inside menu.root)
+ # Menu Item A depth = 2 (now moved inside Menu Item B)
+ expect(menu_item_a.depth).to eq(2)
end
end
diff --git a/backend/spec/features/admin/menus/edit_menu_spec.rb b/backend/spec/features/admin/menus/edit_menu_spec.rb
index 67ee9023c0..cb0f25bf79 100644
--- a/backend/spec/features/admin/menus/edit_menu_spec.rb
+++ b/backend/spec/features/admin/menus/edit_menu_spec.rb
@@ -60,7 +60,7 @@ describe 'Menu Edit', type: :feature do
end
end
- context 'setting the link to a menu link', js: true do
+ context 'setting the link to a Taxon link', js: true do
let!(:taxon_1) { create(:taxon) }
let!(:taxon_2) { create(:taxon) }
let!(:taxon_3) { create(:taxon) }
@@ -69,7 +69,7 @@ describe 'Menu Edit', type: :feature do
visit spree.edit_admin_menu_menu_item_path(main_menu, menu_item)
end
- it 'allows you to select a menu and save' do
+ it 'allows you to select a Taxon and save' do
select2 'Taxon', from: 'Link To'
expect(page).to have_text 'Click the Update button below to change the link.'
click_on 'Update'