Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Update naming for Stimulus compatibility.

Matthew Kennedyf6deb223de1c
diff --git a/backend/app/assets/javascripts/spree/backend/global/select2_autocomplete.es6 b/backend/app/assets/javascripts/spree/backend/global/select2_autocomplete.es6
index 0de7bda827..969e64c3ec 100644
--- a/backend/app/assets/javascripts/spree/backend/global/select2_autocomplete.es6
+++ b/backend/app/assets/javascripts/spree/backend/global/select2_autocomplete.es6
@@ -1,15 +1,15 @@
// Allows you to use one autocomplete for several use cases with sensible defaults.
// REQUIRED ATTRIBUTES
-// data-ac-name="products" <- used for api search - Example: (taxons).
-// data-ac-url="products_api_v2" <- gets appended to const url - Example: (taxons_api_v2).
+// data-autocomplete-name-value="products" <- used for api search - Example: (taxons).
+// data-autocomplete-url-value="products_api_v2" <- gets appended to const url - Example: (taxons_api_v2).
// OPTIONAL ATTRIBUTES
-// data-ac-clear="boolean" <- true or false allows select2 clear.
-// data-ac-multiple="boolean" <- true or false set multiple or single select
-// data-ac-return-attr="pretty_name" <- example shown returns taxon pretty_name
-// data-ac-min-input="4" <- set a minimum input for search, default is 3.
-// data-ac-search-query="name_or_master_sku_cont" <- custom search query.
+// data-autocomplete-clear-value="boolean" <- true or false allows select2 clear.
+// data-autocomplete-multiple-value="boolean" <- true or false set multiple or single select
+// data-autocomplete-return-attr-value="pretty_name" <- example shown returns taxon pretty_name
+// data-autocomplete-min-input-value="4" <- set a minimum input for search, default is 3.
+// data-autocomplete-search-query-value="name_or_master_sku_cont" <- custom search query.
// can also be called directly as javastript.
@@ -20,16 +20,16 @@ document.addEventListener('DOMContentLoaded', function() {
function buildParamsFromDataAttrs (element) {
// Required Attributes
- const name = element.dataset.acName
- const url = element.dataset.acUrl
+ const name = element.dataset.autocompleteNameValue
+ const url = element.dataset.autocompleteUrlValue
// Optional Attributes
- const placeholder = element.dataset.acPlaceholder
- const clear = element.dataset.acClear
- const multiple = element.dataset.acMultiple
- const returnAttr = element.dataset.acReturnAttr
- const minimumInput = element.dataset.acMinInput
- const searchQuery = element.dataset.acSearchQuery
+ const placeholder = element.dataset.autocompletePlaceholderValue
+ const clear = element.dataset.autocompleteClearValue
+ const multiple = element.dataset.autocompleteMultipleValue
+ const returnAttr = element.dataset.autocompleteReturnAttrValue
+ const minimumInput = element.dataset.autocompleteMinInputValue
+ const searchQuery = element.dataset.autocompleteSearchQueryValue
$(element).select2Autocomplete({
// Required Attributes
diff --git a/backend/app/views/spree/admin/shared/linkables/_spree_product.html.erb b/backend/app/views/spree/admin/shared/linkables/_spree_product.html.erb
index 791c177f0b..74bed801b9 100644
--- a/backend/app/views/spree/admin/shared/linkables/_spree_product.html.erb
+++ b/backend/app/views/spree/admin/shared/linkables/_spree_product.html.erb
@@ -11,10 +11,10 @@
id_holder, name_holder, active_id_holder || nil),
{ include_blank: true },
class: 'select2autocomplete',
- data: { ac_name: 'products',
- ac_placeholder: Spree.t('admin.navigation.seach_for_a_product'),
- ac_clear: true,
- ac_url: 'products_api_v2' } %>
+ data: { autocomplete_name_value: 'products',
+ autocomplete_placeholder_value: Spree.t('admin.navigation.seach_for_a_product'),
+ autocomplete_clear_value: true,
+ autocomplete_url_value: 'products_api_v2' } %>
<%= f.error_message_on :linked_resource_id %>
<small class="form-text text-muted"><%= resource.link %></small>
diff --git a/backend/app/views/spree/admin/shared/linkables/_spree_taxon.html.erb b/backend/app/views/spree/admin/shared/linkables/_spree_taxon.html.erb
index a528745240..5c8a5b3c2f 100644
--- a/backend/app/views/spree/admin/shared/linkables/_spree_taxon.html.erb
+++ b/backend/app/views/spree/admin/shared/linkables/_spree_taxon.html.erb
@@ -11,11 +11,11 @@
id_holder, name_holder, active_id_holder || nil),
{ include_blank: true },
class: 'select2autocomplete',
- data: { ac_name: 'taxons',
- ac_placeholder: Spree.t('admin.navigation.seach_for_a_taxon'),
- ac_clear: true,
- ac_url: 'taxons_api_v2',
- ac_return_attr: 'pretty_name' } %>
+ data: { autocomplete_name_value: 'taxons',
+ autocomplete_placeholder_value: Spree.t('admin.navigation.seach_for_a_taxon'),
+ autocomplete_clear_value: true,
+ autocomplete_url_value: 'taxons_api_v2',
+ autocomplete_return_attr_value: 'pretty_name' } %>
<%= f.error_message_on :linked_resource_id %>
<small class="form-text text-muted"><%= resource.link %></small>