Skip to content

Generate clean 2D game sprites & animation atlases — component-row pipeline: state rows, alpha cleanup, frame extraction, runtime atlases. Codex/Claude skill.

5.4 KB
Raw Blame
# SPDX-License-Identifier: Apache-2.0
"""Automated inspect/score/correction-loop coverage."""

from __future__ import annotations

import json
from pathlib import Path
import shlex
import sys

from conftest import run_script


def test_inspect_scores_extracted_fixture(fixture_run_dir: Path) -> None:
    extract = run_script("extract_sprite_row_frames.py", "--run-dir", str(fixture_run_dir))
    assert extract.returncode == 0, extract.stdout + extract.stderr

    inspected = run_script("inspect_sprite_run.py", "--run-dir", str(fixture_run_dir))
    assert inspected.returncode == 0, inspected.stdout + inspected.stderr
    inspect_report = json.loads((fixture_run_dir / "sprite-inspect.report.json").read_text(encoding="utf-8"))
    assert inspect_report["kind"] == "sprite-gen-inspect-report"
    assert inspect_report["rows"][0]["metrics"]["histogram_intersection"]["min"] <= 1.0
    assert inspect_report["rows"][0]["metrics"]["dhash_similarity"]["min"] <= 1.0
    assert "motion_presence" in inspect_report["rows"][0]["metrics"]

    scored = run_script(
        "score_sprite_run.py",
        "--inspect-report", str(fixture_run_dir / "sprite-inspect.report.json"),
    )
    assert scored.returncode == 0, scored.stdout + scored.stderr
    score_report = json.loads((fixture_run_dir / "sprite-score.report.json").read_text(encoding="utf-8"))
    assert score_report["ok"] is True
    assert score_report["overall_score"] >= 90


def test_raw_frame_count_defect_produces_correction_hint(fixture_run_dir: Path) -> None:
    request_path = fixture_run_dir / "sprite-request.json"
    request = json.loads(request_path.read_text(encoding="utf-8"))
    request["states"] = {"walk": {**request["states"]["walk"], "frames": 5}}
    request_path.write_text(json.dumps(request, ensure_ascii=False, indent=2) + "\n", encoding="utf-8")

    inspected = run_script("inspect_sprite_run.py", "--run-dir", str(fixture_run_dir), "--states", "walk")
    assert inspected.returncode == 1
    scored = run_script(
        "score_sprite_run.py",
        "--inspect-report", str(fixture_run_dir / "sprite-inspect.report.json"),
    )
    assert scored.returncode == 1
    score_report = json.loads((fixture_run_dir / "sprite-score.report.json").read_text(encoding="utf-8"))
    assert score_report["ok"] is False
    assert any("exactly 5 full-body poses" in hint for hint in score_report["hints"])


def test_correction_loop_dry_run_preserves_best_candidate(fixture_run_dir: Path, tmp_path: Path) -> None:
    request_path = fixture_run_dir / "sprite-request.json"
    request = json.loads(request_path.read_text(encoding="utf-8"))
    request["states"] = {"walk": {**request["states"]["walk"], "frames": 5}}
    request_path.write_text(json.dumps(request, ensure_ascii=False, indent=2) + "\n", encoding="utf-8")

    out_dir = tmp_path / "loop"
    result = run_script(
        "run_correction_loop.py",
        "--run-dir", str(fixture_run_dir),
        "--states", "walk",
        "--out-dir", str(out_dir),
        "--dry-run",
    )
    assert result.returncode == 1
    loop_report = json.loads((out_dir / "correction-loop.report.json").read_text(encoding="utf-8"))
    assert loop_report["dry_run"] is True
    assert Path(loop_report["preserved_best"]).is_dir()
    assert "exactly 5 full-body poses" in (out_dir / "attempt-1" / "correction-hints.txt").read_text(encoding="utf-8")


def test_correction_loop_min_attempts_forces_provider_then_converges(fixture_run_dir: Path, tmp_path: Path) -> None:
    extract = run_script("extract_sprite_row_frames.py", "--run-dir", str(fixture_run_dir))
    assert extract.returncode == 0, extract.stdout + extract.stderr
    provider = tmp_path / "copy_provider.py"
    provider.write_text(
        "import shutil,sys\nshutil.copytree(sys.argv[1], sys.argv[2])\n",
        encoding="utf-8",
    )
    out_dir = tmp_path / "loop"
    result = run_script(
        "run_correction_loop.py",
        "--run-dir", str(fixture_run_dir),
        "--states", "walk",
        "--out-dir", str(out_dir),
        "--max-passes", "3",
        "--min-attempts", "2",
        # The template is POSIX shell syntax: literal paths are quoted so a Windows path keeps its backslashes.
        "--provider-command", shlex.join([sys.executable, str(provider), str(fixture_run_dir)]) + " {next_run_dir}",
    )
    assert result.returncode == 0, result.stdout + result.stderr
    loop_report = json.loads((out_dir / "correction-loop.report.json").read_text(encoding="utf-8"))
    assert loop_report["min_attempts"] == 2
    assert len(loop_report["attempts"]) == 2
    assert loop_report["attempts"][1]["ok"] is True
    assert not (out_dir / "candidate-3").exists()


def test_correction_loop_does_not_generate_after_last_attempt(fixture_run_dir: Path, tmp_path: Path) -> None:
    request_path = fixture_run_dir / "sprite-request.json"
    request = json.loads(request_path.read_text(encoding="utf-8"))
    request["states"] = {"walk": {**request["states"]["walk"], "frames": 5}}
    request_path.write_text(json.dumps(request, ensure_ascii=False, indent=2) + "\n", encoding="utf-8")
    out_dir = tmp_path / "loop"
    result = run_script(
        "run_correction_loop.py",
        "--run-dir", str(fixture_run_dir),
        "--states", "walk",
        "--out-dir", str(out_dir),
        "--max-passes", "1",
        "--provider-command", "python3 -c 'raise SystemExit(9)'",
    )
    assert result.returncode == 1
    assert not (out_dir / "attempt-1" / "provider.log").exists()