Generate clean 2D game sprites & animation atlases — component-row pipeline: state rows, alpha cleanup, frame extraction, runtime atlases. Codex/Claude skill.
fix(gif): inspect frame metadata before advancing decoder
Soohong Kima9aefc394c06
diff --git a/sprite_gen/util/gif_utils.py b/sprite_gen/util/gif_utils.pyindex 14aeb60..4ff9d16 100644--- a/sprite_gen/util/gif_utils.py+++ b/sprite_gen/util/gif_utils.py@@ -76,13 +76,18 @@ def save_clean_gif(def gif_report(path: Path) -> dict[str, object]:"""Return frame count, delay list, loop, transparency, and disposal values."""with Image.open(path) as image:- frames = list(ImageSequence.Iterator(image))- delays = [int(frame.info.get("duration", 0) / 10) for frame in frames]- alpha_extrema = [frame.convert("RGBA").getchannel("A").getextrema() for frame in frames]- disposal = [getattr(frame, "disposal_method", None) for frame in frames]+ delays = []+ alpha_extrema = []+ disposal = []+ # The iterator reuses its decoder object. Read each frame's properties+ # before advancing, while they still describe that frame.+ for frame in ImageSequence.Iterator(image):+ delays.append(int(frame.info.get("duration", 0) / 10))+ alpha_extrema.append(frame.convert("RGBA").getchannel("A").getextrema())+ disposal.append(getattr(frame, "disposal_method", None))return {"path": str(path),- "frames": len(frames),+ "frames": len(delays),"delay_ticks": delays,"loop": image.info.get("loop", 0),"transparent": all(min_alpha < 255 for min_alpha, _max_alpha in alpha_extrema),diff --git a/tests/test_gif_report.py b/tests/test_gif_report.pynew file mode 100644index 0000000..aac6ecd--- /dev/null+++ b/tests/test_gif_report.py@@ -0,0 +1,28 @@+# SPDX-License-Identifier: Apache-2.0+"""Inspect each decoded GIF frame before the decoder advances."""+from pathlib import Path++from PIL import Image++from sprite_gen.util.gif_utils import gif_report+++def test_report_preserves_individual_holds_disposal_and_alpha(tmp_path: Path):+ palette = [255, 0, 255, 20, 40, 60, 80, 100, 120] + [0] * (768 - 9)+ frames = []+ for index in (1, 2, 1):+ frame = Image.new("P", (12, 12), index)+ frame.putpalette(palette)+ frames.append(frame)+ frames[-1].putpixel((0, 0), 0)+ path = tmp_path / "varying.gif"+ frames[0].save(path, save_all=True, append_images=frames[1:],+ duration=[60, 70, 90], disposal=[1, 2, 2], loop=3,+ transparency=0, optimize=False)++ report = gif_report(path)+ assert report["frames"] == 3+ assert report["delay_ticks"] == [6, 7, 9]+ assert report["disposal"] == [1, 2, 2]+ assert report["loop"] == 3+ assert report["transparent"] is False # The first two frames are opaque.