Skip to content

Generate clean 2D game sprites & animation atlases — component-row pipeline: state rows, alpha cleanup, frame extraction, runtime atlases. Codex/Claude skill.

test(lane): two wrap-blend tests cut without the seam bridge, the Linux lane runs the curator's JavaScript under node, and the one layout a case-sensitive volume cannot make is named

Soohong Kimbd37c77cf6ed
diff --git a/scripts/linux_lane.sh b/scripts/linux_lane.sh
index ada08cb..d7ea613 100755
--- a/scripts/linux_lane.sh
+++ b/scripts/linux_lane.sh
@@ -10,6 +10,8 @@
# Run it from a clean clone of the commit being measured, on x86-64 Linux with:
# - Python 3.14 (`python3.14` on PATH, or named by SPRITE_GEN_LANE_PYTHON),
# - ffmpeg, and img2webp from libwebp >= 1.5 (its `-exact` flag),
+# - Node.js (`node` on PATH), which runs the curator's JavaScript in tests/effects/test_breathe_*.py
+# (not needed by `--rife-only`),
# - a Vulkan loader with a CPU driver (Mesa lavapipe is enough).
# The host's tools are not installed by this script: a missing one ends the run by name. The
# environment it creates lives in the clone (.venv, ignored), as the quickstart's does.
@@ -95,6 +97,8 @@ command -v img2webp >/dev/null || fail "img2webp (libwebp >= 1.5) is not on PATH
# their whole input (no `grep -q`): under pipefail an early-exiting grep kills the writer with
# SIGPIPE and the pipeline reads as a failure.
img2webp -h 2>&1 | grep -- -exact >/dev/null || fail "img2webp has no -exact flag; libwebp must be 1.5 or newer"
+# Without node the curator's JavaScript tests skip, which no run of this lane would measure.
+[ "$rife_only" = 1 ] || command -v node >/dev/null || fail "node (Node.js) is not on PATH; the curator's JavaScript tests run it"
/sbin/ldconfig -p | grep 'libvulkan\.so\.1' >/dev/null || fail "no Vulkan loader (libvulkan.so.1)"
git diff --quiet && git diff --cached --quiet || fail "the checkout has uncommitted changes"
[ ! -e .venv ] || fail ".venv already exists; run from a fresh clone"
@@ -109,6 +113,7 @@ fi
sha=$(git rev-parse HEAD)
echo "commit $sha"
echo "$("$PYTHON" --version), $(ffmpeg -version | head -1 | cut -d' ' -f1-3)"
+[ "$rife_only" = 1 ] || echo "node $(node --version)"
step "install (clean environment, as the quickstart does)"
"$PYTHON" -m venv .venv
diff --git a/tests/conftest.py b/tests/conftest.py
index 7bee36d..c9829f1 100644
--- a/tests/conftest.py
+++ b/tests/conftest.py
@@ -60,11 +60,16 @@ def symlink_or_skip(link: Path, target: Path) -> None:
# Tests that skip where no RIFE is reachable for a reason other than RIFE: an input the lane does not
-# give. Named without their parameters. In the lane's RIFE-less run (`pytest --rife-unmeasured`) these
-# and the tests marked real_rife may skip; any other skip fails (docs/release.md).
+# give. Named without their parameters, or with them where one case alone skips. In the lane's RIFE-less
+# run (`pytest --rife-unmeasured`) these and the tests marked real_rife may skip; any other skip fails
+# (docs/release.md).
NOT_RIFE_SKIPS = {
# SPRITE_GEN_CHROMA_REAL_STILLS names model stills, which the repository does not hold.
"tests/frames/test_chroma_key_relative.py::test_real_still_keys_out_its_painted_border",
+ # A folder spelt in capitals is the same folder only on a volume that ignores case (macOS, Windows); the
+ # lane's Linux volume tells the two spellings apart, so the layout the case measures cannot be made there.
+ "tests/effects/test_breathe_publish.py::test_overlapping_folders_are_refused_before_anything_is_made"
+ "[out_inside_frames_spelt_in_capitals]",
}
@@ -99,7 +104,7 @@ def _fail_unmeasured_skip(report: pytest.TestReport | pytest.CollectReport, node
test body, the file at import."""
if not report.skipped or hasattr(report, "wasxfail") or not node.config.getoption("rife_unmeasured", False):
return
- if node.get_closest_marker("real_rife") or report.nodeid.partition("[")[0] in NOT_RIFE_SKIPS:
+ if node.get_closest_marker("real_rife") or {report.nodeid, report.nodeid.partition("[")[0]} & NOT_RIFE_SKIPS:
return
path, line, reason = report.longrepr
report.outcome = "failed"
diff --git a/tests/video/test_wrap_blend.py b/tests/video/test_wrap_blend.py
index 4a24b82..4fd8a56 100644
--- a/tests/video/test_wrap_blend.py
+++ b/tests/video/test_wrap_blend.py
@@ -422,11 +422,13 @@ def test_the_checkpoints_part_on_a_flat_figure_is_cut_as_filmed_with_a_warning(t
x = 60 + round(16 * min(t / 6, 1))
f[76:90, x:x + 14, :3] = 60
frames.append(f)
- report = cut(tmp_path, keyed(tmp_path, frames), "auto")
+ # The blend alone: the wrap the blend leaves jumps, so where RIFE is installed the seam bridge would make frames round
+ # it in both cuts (on a CPU Vulkan driver, longer than the test's time); `--repair off` keeps the bridge out of both.
+ report = cut(tmp_path, keyed(tmp_path, frames), "auto", repair="off")
blend = report["wrap_blend"]
assert blend["applied"] is False and blend["after_check"] == "refused" and blend["residual_ratio"] > SEAM_MAX
assert "the wrap blend was not used" in capsys.readouterr().err
- cut(tmp_path, keyed(tmp_path, frames, "keyed-off"), "off", wrap_blend="off")
+ cut(tmp_path, keyed(tmp_path, frames, "keyed-off"), "off", wrap_blend="off", repair="off")
assert outputs(tmp_path / "auto") == outputs(tmp_path / "off")
@@ -519,9 +521,10 @@ def test_a_cut_that_is_not_pinned_is_not_touched(tmp_path: Path) -> None:
def test_a_pinned_cut_the_body_anchor_moves_is_not_touched(tmp_path: Path) -> None:
frames = character(**REDRAW)
- report = cut(tmp_path, keyed(tmp_path, frames), "auto", anchor="body")
+ # The blend alone, as in section 1: `--repair off` keeps the seam bridge from making frames round the redraw's wrap.
+ report = cut(tmp_path, keyed(tmp_path, frames), "auto", anchor="body", repair="off")
assert report["wrap_blend"]["applied"] is False and "--anchor body" in report["wrap_blend"]["why"]
- cut(tmp_path, keyed(tmp_path, frames, "keyed-off"), "off", anchor="body", wrap_blend="off")
+ cut(tmp_path, keyed(tmp_path, frames, "keyed-off"), "off", anchor="body", wrap_blend="off", repair="off")
assert outputs(tmp_path / "auto") == outputs(tmp_path / "off")