web search done right
Don't use self node for scoring in query centrality. We don't want to have bias for the top search results when calculating query centrality. For any node in the search results, they should be scored by the similarity with all the other nodes (not themselves).
Mikkel Denker625e02590dbd
diff --git a/core/src/ranking/inbound_similarity.rs b/core/src/ranking/inbound_similarity.rsindex ee23d63b..ea138fa5 100644--- a/core/src/ranking/inbound_similarity.rs+++ b/core/src/ranking/inbound_similarity.rs@@ -46,12 +46,25 @@ pub struct Scorer {struct NodeScorer {node: NodeID,inbound: bitvec_similarity::BitVec,+ self_score: f64,}impl NodeScorer {+ fn new(node: NodeID, inbound: bitvec_similarity::BitVec) -> Self {+ Self {+ node,+ inbound,+ self_score: 1.0,+ }+ }++ fn set_self_score(&mut self, self_score: f64) {+ self.self_score = self_score;+ }+fn sim(&self, other: &NodeID, other_inbound: &bitvec_similarity::BitVec) -> f64 {if self.node == *other {- 1.0+ self.self_score} else {self.inbound.sim(other_inbound)}@@ -86,6 +99,16 @@ impl Scorer {self.cache.insert(*node, score);score}++ pub fn set_self_score(&mut self, self_score: f64) {+ for scorer in self.liked.iter_mut() {+ scorer.set_self_score(self_score);+ }++ for scorer in self.disliked.iter_mut() {+ scorer.set_self_score(self_score);+ }+ }}#[derive(Clone, Debug)]@@ -174,19 +197,13 @@ impl InboundSimilarity {let liked: Vec<_> = liked_sites.iter().filter_map(|id| self.vectors.get(&id.0).cloned().map(|vec| (id, vec)))- .map(|(node, inbound)| NodeScorer {- node: *node,- inbound,- })+ .map(|(node, inbound)| NodeScorer::new(*node, inbound)).collect();let disliked: Vec<_> = disliked_sites.iter().filter_map(|id| self.vectors.get(&id.0).cloned().map(|vec| (id, vec)))- .map(|(node, inbound)| NodeScorer {- node: *node,- inbound,- })+ .map(|(node, inbound)| NodeScorer::new(*node, inbound)).collect();Scorer {diff --git a/core/src/ranking/query_centrality.rs b/core/src/ranking/query_centrality.rsindex ad6a2fb3..15e5623a 100644--- a/core/src/ranking/query_centrality.rs+++ b/core/src/ranking/query_centrality.rs@@ -24,6 +24,9 @@ pub struct Scorer {impl Scorer {pub fn new(inbound_centrality: inbound_similarity::Scorer) -> Self {+ let mut inbound_centrality = inbound_centrality;+ inbound_centrality.set_self_score(0.0);+Self { inbound_centrality }}