Skip to content

web search done right

Language makes more sense than region. Currently region is only detected by language, so from a user perspective it makes more sense to call the dropdown "language".

Mikkel Denkera31755b87459
diff --git a/core/src/webpage/region.rs b/core/src/webpage/region.rs
index ee64c6ea..8436f8df 100644
--- a/core/src/webpage/region.rs
+++ b/core/src/webpage/region.rs
@@ -44,13 +44,19 @@ pub const ALL_REGIONS: [Region; 6] = [
impl Region {
pub fn name(&self) -> String {
+ // TODO: Translate these strings.
+
+ // The names are used in the UI. In the future we should
+ // actually use region, but right now we only detect region
+ // from the language of the page, so it makes more sense to
+ // just use the language name.
match self {
- Region::All => "All Regions".to_string(),
- Region::Denmark => "Denmark".to_string(),
- Region::France => "France".to_string(),
- Region::Germany => "Germany".to_string(),
- Region::Spain => "Spain".to_string(),
- Region::US => "United States".to_string(),
+ Region::All => "All Languages".to_string(),
+ Region::Denmark => "Danish".to_string(),
+ Region::France => "French".to_string(),
+ Region::Germany => "German".to_string(),
+ Region::Spain => "Spainish".to_string(),
+ Region::US => "English".to_string(),
}
}