Skip to content

web search done right

fix improvements

Mikkel Denkerd4cb9cd81c5b
diff --git a/frontend/src/lib/api/index.ts b/frontend/src/lib/api/index.ts
index 2a12885d..38e54e9b 100644
--- a/frontend/src/lib/api/index.ts
+++ b/frontend/src/lib/api/index.ts
@@ -136,8 +136,8 @@ export const api = {
};
},
- sendImprovementClick: ({ queryId, click }: { queryId: string; click: string }) => {
- window.navigator.sendBeacon(`${API_BASE}/improvement/click?qid=${queryId}&click=${click}`);
+ sendImprovementClick: ({ queryId, clickIndex }: { queryId: string; clickIndex: number }) => {
+ window.navigator.sendBeacon(`${API_BASE}/improvement/click?qid=${queryId}&click=${clickIndex}`);
},
};
diff --git a/frontend/src/lib/improvements.ts b/frontend/src/lib/improvements.ts
index 18c86351..1cbfeba7 100644
--- a/frontend/src/lib/improvements.ts
+++ b/frontend/src/lib/improvements.ts
@@ -8,7 +8,7 @@ const queryIdStore = writable<string | undefined>();
export const updateQueryId = async ({ query, webpages }: { query: string; webpages: Webpage[] }) =>
queryIdStore.set(await api.queryId({ query, urls: webpages.map((wp) => wp.url) }).data);
-export const improvements: Action<HTMLAnchorElement, Webpage> = (node, webpage) => {
+export const improvements: Action<HTMLAnchorElement, number> = (node, webpageIndex) => {
let queryId: string | undefined;
let allowStats: boolean | undefined;
@@ -17,7 +17,7 @@ export const improvements: Action<HTMLAnchorElement, Webpage> = (node, webpage)
const listener = () => {
if (!queryId || !allowStats) return;
- api.sendImprovementClick({ queryId, click: webpage.url });
+ api.sendImprovementClick({ queryId, clickIndex: webpageIndex });
};
node.addEventListener('click', listener);
diff --git a/frontend/src/routes/search/+page.svelte b/frontend/src/routes/search/+page.svelte
index 692eac75..a5ea5200 100644
--- a/frontend/src/routes/search/+page.svelte
+++ b/frontend/src/routes/search/+page.svelte
@@ -191,9 +191,9 @@
{#if results.webpages}
<div class="grid grid-cols-1 space-y-10 place-self-start">
- {#each results.webpages as webpage (webpage.url)}
+ {#each results.webpages as webpage, resultIndex (webpage.url)}
<div animate:flip={{ duration: 150 }}>
- <Result {webpage} on:modal={openSearchModal(webpage)} />
+ <Result {webpage} {resultIndex} on:modal={openSearchModal(webpage)} />
</div>
{/each}
{#if results.discussions}
diff --git a/frontend/src/routes/search/Result.svelte b/frontend/src/routes/search/Result.svelte
index 33a1344d..ac21f8c8 100644
--- a/frontend/src/routes/search/Result.svelte
+++ b/frontend/src/routes/search/Result.svelte
@@ -8,6 +8,7 @@
import { improvements } from '$lib/improvements';
export let webpage: Webpage;
+ export let resultIndex: number;
const summary = derived(summariesStore, ($summaries) => $summaries[webpage.url]);
@@ -23,7 +24,7 @@
<a
class="max-w-[calc(100%-100px)] truncate text-gray-800 dark:text-brand-100"
href={webpage.url}
- use:improvements={webpage}
+ use:improvements={resultIndex}
>
{webpage.prettyUrl}
</a>
@@ -32,7 +33,7 @@
class="max-w-[calc(100%-30px)] truncate text-xl font-medium text-blue-800 visited:text-purple-800 hover:underline dark:text-blue-500 dark:visited:text-purple-500"
title={webpage.title}
href={webpage.url}
- use:improvements={webpage}
+ use:improvements={resultIndex}
>
{webpage.title}
</a>