Skip to content

web search done right

clippy fix

Mikkel Denkerdd62dfc108a0
diff --git a/core/src/inverted_index.rs b/core/src/inverted_index.rs
index d63ae2cc..764befb8 100644
--- a/core/src/inverted_index.rs
+++ b/core/src/inverted_index.rs
@@ -145,7 +145,7 @@ impl InvertedIndex {
let writer = tantivy_index.writer_with_num_threads(1, 1_000_000_000)?;
- let merge_policy = NoMergePolicy::default();
+ let merge_policy = NoMergePolicy;
writer.set_merge_policy(Box::new(merge_policy));
let reader: IndexReader = tantivy_index.reader_builder().try_into()?;
diff --git a/core/src/kv/rocksdb_store.rs b/core/src/kv/rocksdb_store.rs
index 6e1a9cc6..f11012c8 100644
--- a/core/src/kv/rocksdb_store.rs
+++ b/core/src/kv/rocksdb_store.rs
@@ -73,8 +73,8 @@ where
Box::new(IntoIter {
inner: iter,
- key: PhantomData::default(),
- value: PhantomData::default(),
+ key: PhantomData,
+ value: PhantomData,
})
}
diff --git a/core/src/ranking/pipeline.rs b/core/src/ranking/pipeline.rs
index cbb217ca..31746161 100644
--- a/core/src/ranking/pipeline.rs
+++ b/core/src/ranking/pipeline.rs
@@ -149,7 +149,7 @@ impl<T: AsRankingWebsite, M: CrossEncoder> Scorer<T> for ReRanker<M> {
self.crossencoder_score_websites(websites);
for website in websites.iter_mut() {
- let mut website = website.as_mut_ranking();
+ let website = website.as_mut_ranking();
let score = calculate_score(
&self.lambda_mart,
&self.signal_coefficients,
diff --git a/core/src/webgraph/centrality/online_harmonic.rs b/core/src/webgraph/centrality/online_harmonic.rs
index e257e2f3..a66f9c5b 100644
--- a/core/src/webgraph/centrality/online_harmonic.rs
+++ b/core/src/webgraph/centrality/online_harmonic.rs
@@ -109,7 +109,7 @@ fn create_user_nodes(nodes: &[NodeID], proxy_nodes: &[Arc<ProxyNode>]) -> Vec<Us
if res.len() < USER_NODES_LIMIT {
res.push(user_node);
} else {
- let mut best = res
+ let best = res
.iter_mut()
.min_by_key(|curr| user_node.best_dist(&curr.id).unwrap_or(255))
.unwrap();
diff --git a/core/src/webpage/just_text.rs b/core/src/webpage/just_text.rs
index d471bc70..84a1e6fe 100644
--- a/core/src/webpage/just_text.rs
+++ b/core/src/webpage/just_text.rs
@@ -505,7 +505,7 @@ impl JustText {
let prev_neighbour = Self::get_prev_neighbour(paragraphs, i, true);
let next_neighbour = Self::get_next_neighbour(paragraphs, i, true);
- let mut paragraph = &mut paragraphs[i];
+ let paragraph = &mut paragraphs[i];
match (prev_neighbour, next_neighbour) {
(
diff --git a/core/src/webpage/mod.rs b/core/src/webpage/mod.rs
index be9b76b2..a3fdd28a 100644
--- a/core/src/webpage/mod.rs
+++ b/core/src/webpage/mod.rs
@@ -27,7 +27,6 @@ use kuchiki::{iter::NodeEdge, traits::TendrilSink, NodeRef};
use regex::Regex;
use serde::{Deserialize, Serialize};
use std::{
- borrow::Borrow,
collections::{HashMap, HashSet},
panic,
};
@@ -84,7 +83,7 @@ impl<const N: usize> Preprocessor<N> {
match edge {
NodeEdge::Start(node) => {
if let Some(element) = node.as_element() {
- let element_name: &str = element.name.local.borrow();
+ let element_name: &str = &element.name.local;
if let Some((_, n)) = self
.removed_tags
.iter()
@@ -97,7 +96,7 @@ impl<const N: usize> Preprocessor<N> {
}
NodeEdge::End(node) => {
if let Some(element) = node.as_element() {
- let element_name: &str = element.name.local.borrow();
+ let element_name: &str = &element.name.local;
if let Some((_, n)) = self
.removed_tags
.iter()
@@ -634,12 +633,7 @@ impl Html {
.borrow()
.map
.iter()
- .map(|(name, attr)| {
- (
- name.local.borrow().to_string(),
- attr.borrow().value.to_string(),
- )
- })
+ .map(|(name, attr)| (name.local.to_string(), attr.value.to_string()))
.collect(),
);
}
@@ -1018,12 +1012,7 @@ impl Html {
.borrow()
.map
.iter()
- .map(|(name, attr)| {
- (
- name.local.borrow().to_string(),
- attr.borrow().value.to_string(),
- )
- })
+ .map(|(name, attr)| (name.local.to_string(), attr.value.to_string()))
.collect();
scripts.push(Script {