Skip to content

StreamVault is a TV-first free IPTV player for Android TV built with Kotlin, Jetpack Compose, Room, Hilt, and Media3.

docs(catalog): report phase 5 feature extraction

David Nashash446464c2d50b
diff --git a/app/build.gradle.kts b/app/build.gradle.kts
index 09ca5347..c4e964ff 100644
--- a/app/build.gradle.kts
+++ b/app/build.gradle.kts
@@ -380,9 +380,7 @@ abstract class VerifyFeatureNavigationBoundaryTask : DefaultTask() {
fun verify() {
val expectedFiles = setOf(
"WelcomeGraph.kt",
- "HomeGraph.kt",
"LiveGraph.kt",
- "CatalogGraph.kt",
"SystemGraph.kt"
)
val files = sourceRoot.get().asFile.walkTopDown()
diff --git a/docs/COMPOSE_REDUCTION_AND_UI_ARCHITECTURE_PLAN.md b/docs/COMPOSE_REDUCTION_AND_UI_ARCHITECTURE_PLAN.md
index f4405bf7..1024d8fe 100644
--- a/docs/COMPOSE_REDUCTION_AND_UI_ARCHITECTURE_PLAN.md
+++ b/docs/COMPOSE_REDUCTION_AND_UI_ARCHITECTURE_PLAN.md
@@ -896,6 +896,7 @@ Detailed delivery artifacts:
- [Settings and Live regression audit](COMPOSE_REDUCTION_PHASE5_SETTINGS_LIVE_REGRESSION_AUDIT.md)
- [Catalog feature extraction design](superpowers/specs/2026-09-02-phase-5-catalog-feature-extraction-design.md)
- [Catalog feature extraction implementation plan](superpowers/plans/2026-09-02-catalog-feature-extraction.md)
+- [Catalog feature extraction execution report](COMPOSE_REDUCTION_PHASE5_CATALOG_REPORT.md)
Recommended extraction order:
@@ -976,8 +977,11 @@ paths, plus reversible quick-filter save/reload/remove persistence. The full
Home/EPG descriptors and nonzero `feature/live` descriptors; the eight
separate macrobenchmark tests were skipped by configuration and remain an
open performance gate. The app-owned Live route golden was reviewed and
- regenerated with its connected assertion passing. Catalog and System were
- not started; Playback, Provider, and Settings gates remain governed by their
+ regenerated with its connected assertion passing. Catalog is now structurally
+ extracted under `:feature:catalog`; its execution report records the
+ connected golden window mismatch, unavailable seeded journeys, open paired
+ benchmark/profile gates, and current app lint baseline failure. System remains
+ unstarted; Playback, Provider, and Settings gates remain governed by their
separate reports.
### Phase 6 - Optional Views migrations
diff --git a/docs/COMPOSE_REDUCTION_PHASE5_CATALOG_REPORT.md b/docs/COMPOSE_REDUCTION_PHASE5_CATALOG_REPORT.md
new file mode 100644
index 00000000..91885ae7
--- /dev/null
+++ b/docs/COMPOSE_REDUCTION_PHASE5_CATALOG_REPORT.md
@@ -0,0 +1,147 @@
+# Compose Reduction Phase 5 — Catalog execution report
+
+Date: 2026-09-02
+Status: structurally extracted; acceptance gates remain open
+
+## Outcome
+
+The Dashboard, Movies, Series, VOD, Favorites, Search, and media-detail
+presentation now live in `:feature:catalog`. The app remains the composition
+root: it supplies platform/service adapters, player-request and payload
+compatibility, shell/Settings composition, and root graph registration. Route
+strings, arguments, return destinations, callbacks, focus/test semantics, and
+the four reviewed golden assets were preserved.
+
+This report covers the Catalog slice only. Playback, Provider, Settings, and
+Live status remain governed by their existing Phase 5 reports; Phase 5 is not
+complete and `:feature:system` is still unstarted.
+
+## Delivery sequence and rollback
+
+The extraction was delivered in small commits from rollback point
+`d303e2aa` (pre-extraction design/plan links):
+
+| Task | Commit | Result |
+|---:|---|---|
+| 0 | `626903f0` | inventory, dependency ledger, focused baseline, before measurements |
+| 1 | `70bb99ea` | module and fail-closed boundary |
+| 2–4 | `ed3f819b`, `70023eea`, `9ca8cf0d` | contracts, app adapters, localized resources |
+| 5–6 | `6a84d503`, `91782978` | shared primitives and browse presentation |
+| 7–9 | `10c3a9c4`, `3fc94ea0`, `68423dba` | detail, Dashboard, Search/Favorites |
+| 10 | `e3238404` | feature-owned graph registration |
+| 11 | `4c7871fd` | goldens, legacy ownership cleanup, structural gates |
+| 12 | `5f1e615e` | connected acceptance evidence and semantics fix |
+| 13 | current documentation commit | isolation/build measurements and status report |
+
+To roll back the Catalog work, return to `d303e2aa`; the intermediate commits
+are intentionally independently revertible.
+
+## Ownership and boundary
+
+`feature/catalog` production code contains 50 Kotlin/Java files, 24 unit-test
+files, and 3 instrumentation Kotlin/Java files, plus feature resources and
+four route goldens. The six app Catalog screen directories are absent. The
+Catalog boundary reports exactly these project dependencies:
+
+```text
+:core:navigation, :core:ui, :domain, :data
+```
+
+The boundary scan passes with zero forbidden main-source references (`:app`,
+`:player`, sibling features, `MainActivity`, and root NavController types).
+The temporary `PreferencesRepository` and `ProviderSyncStateSource` imports
+are recorded in the transitional dependency ledger. Catalog has no `:player`
+or sibling-feature dependency.
+
+App-owned adapters cover Cast route selection, stream preparation, downloads,
+update/install messaging, navigation payloads, player requests, and the shell
+and Dashboard customization dialog. Favorites intentionally remains a direct
+feature-host surface; no new Favorites route was introduced.
+
+## Resources, tests, and goldens
+
+The locale audit passed with 351 expected keys, zero missing/value/format
+mismatches, zero unexpected keys, and 525 explicitly allowed source-locale
+fallbacks. No app locale key was removed because app-shell and compatibility
+consumers still resolve shared strings.
+
+The four goldens moved byte-for-byte into the feature:
+
+```text
+route_dashboard_default.png
+route_movies_landing.png
+route_series_detail.png
+route_search_results.png
+```
+
+The feature unit, lint, Android-test compilation, resource processing, boundary,
+and debug assembly gates passed. The app navigation-boundary task also passes
+after removing obsolete `HomeGraph.kt`/`CatalogGraph.kt` expectations.
+
+## Connected/device evidence
+
+Target: `emulator-5554`, `Television_1080p(AVD) - 16`, API 36, AOSP TV x86,
+1920×1080 physical display, 320 dpi, animation scales 1.0.
+
+- Feature connected suite: 1 behavior test passed; the four golden methods
+ reached their assertions but failed the pre-pixel dimension check because
+ the captured Compose window is 1824 px wide while the reviewed baselines are
+ 1920 px wide. Assets were not regenerated.
+- App `AppNavigationContractTest`: 3/3 passed.
+- App `PlatformCompatibilityMatrixTest`: 4/4 passed.
+- No Catalog-caused fatal exception was reported by these runs.
+
+Production seeded Dashboard/Movies/Series/VOD/Search/Details journeys,
+Favorites host journeys, phone/tablet, RTL, reduced-motion, screenshot cadence,
+and sanitized logcat evidence were unavailable: this checkout has no seeded
+provider/catalog fixture or production-activity journey harness. These are
+open acceptance gates, not passes.
+
+## Build isolation and performance
+
+Five reversible feature source-edit samples and five feature test-compile
+samples all passed. Warm source-edit median was 8.3s (8.2–8.5s); warm
+test-compile median was 8.7s (8.7–9.0s). Raw profile names and protocol are in
+`validation/phase5_catalog/performance-before.md` and
+`validation/phase5_catalog/performance-after.md`.
+
+An actual Catalog-only edit followed by `:app:assembleDebug` executed the
+Catalog Kotlin task; sibling feature Kotlin tasks were `UP-TO-DATE` and did
+not execute. A clean debug assembly passed in 80.7s, warm debug assembly in
+14.9s, and Beta/Release packaging passed in 332.3s. These are not a
+cache-equivalent five-run clean-build comparison, and the Dashboard
+macrobenchmark was not run.
+
+## Profiles and known failures
+
+The checked-in generated profile sources remain stale for this move:
+
+| Source | legacy app Catalog descriptors | feature Catalog descriptors |
+|---|---:|---:|
+| `baseline-prof.txt` | 748 | 0 |
+| `startup-prof.txt` | 726 | 0 |
+
+The existing generator workflow is documented as passing in the Live/Provider
+reports, but a fresh Catalog-specific generation was not repeated because it
+requires the unavailable seeded journey harness and takes roughly 25 minutes.
+Generated files were not hand-edited; profile regeneration is an open gate.
+
+The repository-wide `:app:check` attempt reached the app lint task but failed
+on 675 lint findings (first: API-level `Trace.beginAsyncSection` in
+`AppStartupCoordinator.kt`; 901 baseline-filtered findings were also reported).
+This is outside Catalog ownership and is not claimed as a Catalog pass. The
+Catalog lint task itself passed with 802 warnings and one hint. Gradle also
+reported 24 configuration-cache diagnostics for the existing boundary task's
+execution-time project access.
+
+## Next acceptance work
+
+1. Run the profile generator on a seeded device and verify legacy descriptors
+ disappear while feature descriptors appear.
+2. Re-run the four goldens on the 1920-pixel baseline window or review a new
+ 1824-pixel baseline set.
+3. Add a seeded production-activity Catalog fixture and execute the documented
+ journeys, including Favorites and accessibility variants.
+4. Run the Dashboard macrobenchmark and a cache-equivalent paired performance
+ comparison. Keep app lint remediation and all other Phase 5 feature gates
+ tracked separately.
diff --git a/docs/COMPOSE_REDUCTION_PHASE5_ROADMAP.md b/docs/COMPOSE_REDUCTION_PHASE5_ROADMAP.md
index 4c1a8ec7..642d885a 100644
--- a/docs/COMPOSE_REDUCTION_PHASE5_ROADMAP.md
+++ b/docs/COMPOSE_REDUCTION_PHASE5_ROADMAP.md
@@ -94,6 +94,8 @@ out of :app without behavior or stability regressions.
docs/superpowers/specs/2026-09-02-phase-5-catalog-feature-extraction-design.md
- Catalog extraction implementation plan:
docs/superpowers/plans/2026-09-02-catalog-feature-extraction.md
+- Catalog execution report:
+ docs/COMPOSE_REDUCTION_PHASE5_CATALOG_REPORT.md
- Transitional dependency ledger:
docs/COMPOSE_REDUCTION_PHASE5_TRANSITIONAL_DEPENDENCIES.md
@@ -110,4 +112,7 @@ stale app Home/EPG descriptors and nonzero `feature/live` descriptors; the
eight separate macrobenchmark tests were skipped by configuration and remain
an open performance gate. The app-route Live golden was reviewed and
regenerated from the current palette, with its connected assertion passing.
-Catalog and System remain unstarted.
+Catalog extraction is structurally implemented through connected validation and
+current-checkout build-isolation samples. Its four golden/window checks,
+seeded production journeys, paired macrobenchmark comparison, and fresh
+baseline-profile generation remain open. System remains unstarted.
diff --git a/docs/superpowers/plans/2026-09-02-catalog-feature-extraction.md b/docs/superpowers/plans/2026-09-02-catalog-feature-extraction.md
index d8393d3c..9f22d38b 100644
--- a/docs/superpowers/plans/2026-09-02-catalog-feature-extraction.md
+++ b/docs/superpowers/plans/2026-09-02-catalog-feature-extraction.md
@@ -24,6 +24,16 @@
- Do not close Playback, Provider, Settings, or Live gates from this slice.
- Run `graphify update .` after code changes.
+## Execution status (2026-09-02)
+
+Tasks 0–12 are implemented and their evidence is recorded under
+`validation/phase5_catalog/`. Task 13 structural/build-isolation work is also
+recorded in `performance-after.md`; the connected golden window, seeded
+journeys, Dashboard macrobenchmark, fresh profile generation, and repository-
+wide app lint remain open or unavailable as documented in
+`docs/COMPOSE_REDUCTION_PHASE5_CATALOG_REPORT.md`. Do not interpret this
+status as completion of Phase 5.
+
---
### Task 0: Freeze Catalog inventory, rollback point, and before measurements
diff --git a/validation/phase5_catalog/performance-after.md b/validation/phase5_catalog/performance-after.md
new file mode 100644
index 00000000..12fa08ef
--- /dev/null
+++ b/validation/phase5_catalog/performance-after.md
@@ -0,0 +1,56 @@
+# Catalog extraction post-measurement
+
+Date: 2026-09-02
+Post-extraction reference: `5f1e615e` plus the app navigation-boundary fix in
+the final Catalog documentation commit
+Toolchain: Java 21.0.5, Gradle 8.12, Windows 11 amd64, `--no-daemon`
+
+## Feature source-edit samples
+
+Each run used a reversible comment-only edit in
+`feature/catalog/src/main/java/com/streamvault/feature/catalog/presentation/dashboard/DashboardHomeShelves.kt`.
+The file was restored and its normalized Git hash matched `HEAD` afterward.
+
+| Sample | Command | Duration | Result | Profile |
+|---:|---|---:|---|---|
+| 1 | `:feature:catalog:compileDebugKotlin --profile` | 109.4s | PASS | `profile-2026-09-02-23-39-00.html` |
+| 2 | same | 8.3s | PASS | `profile-2026-09-02-23-40-45.html` |
+| 3 | same | 8.5s | PASS | `profile-2026-09-02-23-40-54.html` |
+| 4 | same | 8.2s | PASS | `profile-2026-09-02-23-41-02.html` |
+| 5 | same | 8.3s | PASS | `profile-2026-09-02-23-41-10.html` |
+
+The first run includes post-clean/configuration overhead. Warm median: 8.3s;
+warm range: 8.2–8.5s.
+
+## Feature test-compile samples
+
+Each run used a reversible comment-only edit in
+`feature/catalog/src/test/java/com/streamvault/feature/catalog/presentation/dashboard/DashboardHomeShelvesTest.kt`.
+
+| Sample | Command | Duration | Result | Profile |
+|---:|---|---:|---|---|
+| 1 | `:feature:catalog:compileDebugUnitTestKotlin --profile` | 30.8s | PASS | `profile-2026-09-02-23-41-37.html` |
+| 2 | same | 8.9s | PASS | `profile-2026-09-02-23-42-05.html` |
+| 3 | same | 8.7s | PASS | `profile-2026-09-02-23-42-14.html` |
+| 4 | same | 8.7s | PASS | `profile-2026-09-02-23-42-22.html` |
+| 5 | same | 9.0s | PASS | `profile-2026-09-02-23-42-31.html` |
+
+Warm median: 8.7s; warm range: 8.7–9.0s. Both temporary edits were removed
+before the final validation commit.
+
+## Isolation and packaging
+
+An actual Catalog-only edit followed by `:app:assembleDebug` executed
+`:feature:catalog:compileDebugKotlin`; sibling feature Kotlin tasks were
+reported `UP-TO-DATE` and did not execute. The unfiltered Gradle dry-run lists
+all dependency tasks by design, so the actual execution result is the
+authoritative isolation check.
+
+Additional guardrails:
+
+- `clean :app:assembleDebug`: PASS, 80.7s.
+- warm `:app:assembleDebug`: PASS, 14.9s.
+- `:app:assembleBeta :app:assembleRelease`: PASS, 332.3s.
+
+These are current-checkout samples, not a cache-equivalent five-run clean-build
+comparison. The formal macrobenchmark and paired performance gates remain open.
diff --git a/validation/phase5_catalog/profile-validation.md b/validation/phase5_catalog/profile-validation.md
new file mode 100644
index 00000000..c14761bc
--- /dev/null
+++ b/validation/phase5_catalog/profile-validation.md
@@ -0,0 +1,23 @@
+# Catalog profile validation
+
+Date: 2026-09-02
+
+The checked-in generated profile sources were inspected after the Catalog move.
+They currently contain the pre-extraction app-package descriptors and no
+`com/streamvault/feature/catalog` descriptors:
+
+| Source | Legacy app Catalog matches | Feature Catalog matches |
+|---|---:|---:|
+| `app/src/main/generated/baselineProfiles/baseline-prof.txt` | 748 | 0 |
+| `app/src/main/generated/baselineProfiles/startup-prof.txt` | 726 | 0 |
+
+This is an open gate. The existing Phase 5 Live/Provider reports record a
+successful profile-generation workflow on the same API 36 TV emulator, but a
+fresh Catalog-specific `:app:generateBaselineProfile` run was not repeated in
+this slice because that workflow takes roughly 25 minutes and requires seeded
+profile journeys. The generated files were not hand-edited. Re-run the
+existing generator, then verify that legacy Catalog descriptors are absent and
+feature descriptors are present before claiming profile completion.
+
+The current packaging guardrail (`:app:assembleBeta` and
+`:app:assembleRelease`) passed; it does not substitute for profile generation.