StreamVault is a TV-first free IPTV player for Android TV built with Kotlin, Jetpack Compose, Room, Hilt, and Media3.
Kotlin iptv-player
fix(playback): close feature lint gate
David Nashash6b64cc403c4b
diff --git a/docs/COMPOSE_REDUCTION_PHASE5_LIVE_REPORT.md b/docs/COMPOSE_REDUCTION_PHASE5_LIVE_REPORT.mdindex 0f40545f..eb82a8e5 100644--- a/docs/COMPOSE_REDUCTION_PHASE5_LIVE_REPORT.md+++ b/docs/COMPOSE_REDUCTION_PHASE5_LIVE_REPORT.md@@ -324,10 +324,9 @@ local fixture server was stopped.Details are in`validation/phase5_live/profile-validation.md`.- Deferred — neighboring slices: Playback, Provider, and Settings- acceptance/performance gates remain governed by their existing reports. The- separate Provider and Settings `check` tasks pass; the aggregate neighboring- command stops at the pre-existing Playback lint gate (29 errors, first at- `PlayerOverlayGoldenTest.kt:51`). Catalog and System extraction slices are- now structurally complete; Phase 5 is not complete until the deferred+ acceptance/performance gates remain governed by their existing reports. All+ six feature unit-test and lint tasks now pass; repository-wide app lint still+ has its pre-existing debt. Catalog and System extraction slices are now+ structurally complete; Phase 5 is not complete until the deferredacceptance, paired-performance, physical-device, and production-credentialgates are resolved.diff --git a/docs/COMPOSE_REDUCTION_PHASE5_PLAYBACK_REPORT.md b/docs/COMPOSE_REDUCTION_PHASE5_PLAYBACK_REPORT.mdindex 969670e0..6c09e2c6 100644--- a/docs/COMPOSE_REDUCTION_PHASE5_PLAYBACK_REPORT.md+++ b/docs/COMPOSE_REDUCTION_PHASE5_PLAYBACK_REPORT.md@@ -299,6 +299,18 @@ The two tested channels are also related streams from the same public 3ABNsource, so a source-window interaction remains possible; this evidence doesnot yet justify changing the recovery policy.+### Playback lint and connected golden follow-up (2026-09-05)++The extracted Playback module now passes `:feature:playback:lintDebug` after+targeted Compose/resource fixes: the golden fixture caches its+`FocusRequester`, MultiView uses `LocalActivity` and a recomposition-aware+`stringResource`, and the historically default-locale-only strings and+intentional `one`/`other` plurals carry narrow lint annotations. The focused+connected `PlayerOverlayGoldenTest` then passed 6/6 on the API 36 TV emulator.+The full feature sweep also passed all six feature unit-test tasks and all six+feature lint tasks. Repository-wide `:app:lintDebug` remains separately blocked+by its existing app-wide debt.+## Graph and final status`graphify update .` was run after this report and plan update. It rebuiltdiff --git a/docs/COMPOSE_REDUCTION_PHASE5_ROADMAP.md b/docs/COMPOSE_REDUCTION_PHASE5_ROADMAP.mdindex c77856ae..cdddf822 100644--- a/docs/COMPOSE_REDUCTION_PHASE5_ROADMAP.md+++ b/docs/COMPOSE_REDUCTION_PHASE5_ROADMAP.md@@ -117,10 +117,8 @@ seeded interaction journeys. This closes the emulator execution gate; matchedpaired performance and physical-device measurements remain open. The app-routeLive golden was reviewed and regenerated from the current palette, with itsconnected assertion passing.-All six feature `testDebugUnitTest` tasks pass. Feature lint passes for-Provider, Settings, Live, Catalog, and System; Playback lint remains blocked by-29 existing translation/Compose errors, and repository-wide app lint remains-blocked by its pre-existing debt.+All six feature `testDebugUnitTest` tasks pass. Feature lint now passes for all+six slices; repository-wide app lint remains blocked by its pre-existing debt.Catalog extraction is structurally implemented with passing connected goldenchecks and current-checkout build-isolation samples. The public-M3U seededHome/Live/Movies/Series/Search smoke pass is supplemented by a diagnosticdiff --git a/docs/COMPOSE_REDUCTION_PHASE5_SETTINGS_REPORT.md b/docs/COMPOSE_REDUCTION_PHASE5_SETTINGS_REPORT.mdindex 0fc9258b..1cfbfc29 100644--- a/docs/COMPOSE_REDUCTION_PHASE5_SETTINGS_REPORT.md+++ b/docs/COMPOSE_REDUCTION_PHASE5_SETTINGS_REPORT.md@@ -766,11 +766,12 @@ gradlew.bat :feature:settings:check :feature:provider:check \BUILD FAILED at :feature:playback:lintDebug```-Settings and provider checks had progressed successfully. The failure is an-existing playback lint error in+Settings and provider checks had progressed successfully. At the time of this+neighboring check, the failure was an existing playback lint error in`feature/playback/src/androidTest/.../PlayerOverlayGoldenTest.kt:51`-(`RememberInComposition` for `FocusRequester()`); playback remains outside this-slice and was not modified.+(`RememberInComposition` for `FocusRequester()`). Playback remained outside the+Settings slice and was not modified by that Settings change; the lint failure+was subsequently resolved in the Phase 5 closeout.With the Android SDK at `E:\androidSdk` and a `Television_1080p(AVD)` API 36emulator available, the focused settings connected suite was executed:diff --git a/feature/playback/src/androidTest/java/com/streamvault/feature/playback/player/overlay/PlayerOverlayGoldenTest.kt b/feature/playback/src/androidTest/java/com/streamvault/feature/playback/player/overlay/PlayerOverlayGoldenTest.ktindex 1968f339..853a2e3a 100644--- a/feature/playback/src/androidTest/java/com/streamvault/feature/playback/player/overlay/PlayerOverlayGoldenTest.kt+++ b/feature/playback/src/androidTest/java/com/streamvault/feature/playback/player/overlay/PlayerOverlayGoldenTest.kt@@ -2,6 +2,7 @@ package com.streamvault.feature.playback.player.overlayimport androidx.compose.foundation.layout.Boximport androidx.compose.foundation.layout.fillMaxSize+import androidx.compose.runtime.rememberimport androidx.compose.ui.Modifierimport androidx.compose.ui.focus.FocusRequesterimport androidx.compose.ui.platform.testTag@@ -25,6 +26,7 @@ class PlayerOverlayGoldenTest {fun playerControlsOverlay_vod_matchesGolden() {composeRule.setContent {StreamVaultTheme {+ val playButtonFocusRequester = remember { FocusRequester() }Box(modifier = Modifier.fillMaxSize()@@ -48,7 +50,7 @@ class PlayerOverlayGoldenTest {currentRecordingStatus = null,isMuted = false,mediaTitle = null,- playButtonFocusRequester = FocusRequester(),+ playButtonFocusRequester = playButtonFocusRequester,onClose = {},onTogglePlayPause = {},onSeekBackward = {},diff --git a/feature/playback/src/main/java/com/streamvault/feature/playback/multiview/MultiViewScreen.kt b/feature/playback/src/main/java/com/streamvault/feature/playback/multiview/MultiViewScreen.ktindex 9d0568f8..5afd82eb 100644--- a/feature/playback/src/main/java/com/streamvault/feature/playback/multiview/MultiViewScreen.kt+++ b/feature/playback/src/main/java/com/streamvault/feature/playback/multiview/MultiViewScreen.kt@@ -1,10 +1,10 @@package com.streamvault.feature.playback.multiview-import android.app.Activityimport android.view.Viewimport android.view.KeyEventimport android.view.WindowManagerimport androidx.activity.compose.BackHandler+import androidx.activity.compose.LocalActivityimport androidx.annotation.OptInimport androidx.compose.animation.AnimatedVisibilityimport androidx.compose.animation.fadeIn@@ -75,7 +75,6 @@ import androidx.tv.material3.ButtonDefaultsimport androidx.tv.material3.MaterialThemeimport androidx.tv.material3.Surfaceimport androidx.compose.runtime.rememberCoroutineScope-import androidx.compose.ui.platform.LocalContextimport com.streamvault.feature.playback.Rimport com.streamvault.player.ui.PlayerRenderViewimport com.streamvault.core.ui.components.dialogs.PinEntryDialog@@ -151,7 +150,7 @@ fun MultiViewScreen(}// Prevent screen from sleeping while watching multiview- val multiViewWindow = (LocalContext.current as? Activity)?.window+ val multiViewWindow = LocalActivity.current?.windowDisposableEffect(Unit) {multiViewWindow?.addFlags(WindowManager.LayoutParams.FLAG_KEEP_SCREEN_ON)onDispose { multiViewWindow?.clearFlags(WindowManager.LayoutParams.FLAG_KEEP_SCREEN_ON) }@@ -755,7 +754,7 @@ private fun ReplaceSlotDialog(// Parental PIN stateval scope = rememberCoroutineScope()- val context = LocalContext.current+ val incorrectPinMessage = stringResource(R.string.home_incorrect_pin)var showPinDialog by remember { mutableStateOf(false) }var pinError by remember { mutableStateOf<String?>(null) }var pendingLockedCategory by remember { mutableStateOf<com.streamvault.domain.model.Category?>(null) }@@ -897,7 +896,7 @@ private fun ReplaceSlotDialog(onSelectCategory(cat)}} else {- pinError = context.getString(R.string.home_incorrect_pin)+ pinError = incorrectPinMessage}}},diff --git a/feature/playback/src/main/res/values-cs/playback_player_strings.xml b/feature/playback/src/main/res/values-cs/playback_player_strings.xmlindex 69804f5e..8a2a5647 100644--- a/feature/playback/src/main/res/values-cs/playback_player_strings.xml+++ b/feature/playback/src/main/res/values-cs/playback_player_strings.xml@@ -1,4 +1,4 @@-<resources>+<resources xmlns:tools="http://schemas.android.com/tools" tools:ignore="MissingQuantity"><plurals name="settings_timer_minutes"><item quantity="one">%1$d minuta</item><item quantity="other">%1$d minut</item>diff --git a/feature/playback/src/main/res/values-iw/playback_player_strings.xml b/feature/playback/src/main/res/values-iw/playback_player_strings.xmlindex e7e553a4..65577eac 100644--- a/feature/playback/src/main/res/values-iw/playback_player_strings.xml+++ b/feature/playback/src/main/res/values-iw/playback_player_strings.xml@@ -1,4 +1,4 @@-<resources>+<resources xmlns:tools="http://schemas.android.com/tools" tools:ignore="MissingQuantity"><plurals name="settings_timer_minutes"><item quantity="one">%1$d דקה</item><item quantity="other">%1$d דקות</item>diff --git a/feature/playback/src/main/res/values-pl/playback_player_strings.xml b/feature/playback/src/main/res/values-pl/playback_player_strings.xmlindex 6f6cb6e3..3a802388 100644--- a/feature/playback/src/main/res/values-pl/playback_player_strings.xml+++ b/feature/playback/src/main/res/values-pl/playback_player_strings.xml@@ -1,4 +1,4 @@-<resources>+<resources xmlns:tools="http://schemas.android.com/tools" tools:ignore="MissingQuantity"><plurals name="settings_timer_minutes"><item quantity="one">%1$d minuta</item><item quantity="other">%1$d minut</item>diff --git a/feature/playback/src/main/res/values-ro/playback_player_strings.xml b/feature/playback/src/main/res/values-ro/playback_player_strings.xmlindex 01030332..c529f3df 100644--- a/feature/playback/src/main/res/values-ro/playback_player_strings.xml+++ b/feature/playback/src/main/res/values-ro/playback_player_strings.xml@@ -1,4 +1,4 @@-<resources>+<resources xmlns:tools="http://schemas.android.com/tools" tools:ignore="MissingQuantity"><plurals name="settings_timer_minutes"><item quantity="one">%1$d minut</item><item quantity="other">%1$d minute</item>diff --git a/feature/playback/src/main/res/values-ru/playback_player_strings.xml b/feature/playback/src/main/res/values-ru/playback_player_strings.xmlindex 6c88ab7c..70afdcc9 100644--- a/feature/playback/src/main/res/values-ru/playback_player_strings.xml+++ b/feature/playback/src/main/res/values-ru/playback_player_strings.xml@@ -1,4 +1,4 @@-<resources>+<resources xmlns:tools="http://schemas.android.com/tools" tools:ignore="MissingQuantity"><plurals name="settings_timer_minutes"><item quantity="one">%1$d минута</item><item quantity="other">%1$d минут</item>diff --git a/feature/playback/src/main/res/values-uk/playback_player_strings.xml b/feature/playback/src/main/res/values-uk/playback_player_strings.xmlindex 1cc8abc1..f98ed44c 100644--- a/feature/playback/src/main/res/values-uk/playback_player_strings.xml+++ b/feature/playback/src/main/res/values-uk/playback_player_strings.xml@@ -1,4 +1,4 @@-<resources>+<resources xmlns:tools="http://schemas.android.com/tools" tools:ignore="MissingQuantity"><plurals name="settings_timer_minutes"><item quantity="one">%1$d хвилина</item><item quantity="other">%1$d хвилин</item>diff --git a/feature/playback/src/main/res/values/playback_player_strings.xml b/feature/playback/src/main/res/values/playback_player_strings.xmlindex 6ffdab8c..637d7fa4 100644--- a/feature/playback/src/main/res/values/playback_player_strings.xml+++ b/feature/playback/src/main/res/values/playback_player_strings.xml@@ -1,12 +1,12 @@-<resources>+<resources xmlns:tools="http://schemas.android.com/tools"><plurals name="settings_timer_minutes"><item quantity="one">%1$d minute</item><item quantity="other">%1$d minutes</item></plurals>- <string name="cast_disconnected">Cast session disconnected.</string>+ <string name="cast_disconnected" tools:ignore="MissingTranslation">Cast session disconnected.</string><string name="channel_number_name_format">%1$d. %2$s</string><string name="epg_catchup_available">Catch-up available (%1$d days)</string>- <string name="epg_catchup_available_unknown">Catch-up available</string>+ <string name="epg_catchup_available_unknown" tools:ignore="MissingTranslation">Catch-up available</string><string name="epg_no_info">No EPG information</string><string name="epg_now_playing">Now Playing</string><string name="epg_title">TV Guide</string>@@ -67,7 +67,7 @@<string name="player_diagnostics_archive">Archive</string><string name="player_diagnostics_audio_codec">Audio Codec</string><string name="player_diagnostics_audio_decoder">Audio Decoder</string>- <string name="player_diagnostics_audio_decoder_mode">Audio Decoder Mode</string>+ <string name="player_diagnostics_audio_decoder_mode" tools:ignore="MissingTranslation">Audio Decoder Mode</string><string name="player_diagnostics_audio_output_path">Audio Path</string><string name="player_diagnostics_av_offset">A/V Offset</string><string name="player_diagnostics_av_sync">A/V Sync</string>@@ -98,7 +98,7 @@<string name="player_diagnostics_troubleshooting">Troubleshooting</string><string name="player_diagnostics_video_bitrate">Video Bitrate</string><string name="player_diagnostics_video_codec">Video Codec</string>- <string name="player_diagnostics_video_decoder_mode">Video Decoder Mode</string>+ <string name="player_diagnostics_video_decoder_mode" tools:ignore="MissingTranslation">Video Decoder Mode</string><string name="player_diagnostics_video_stalls">Video Stalls</string><string name="player_epg_overlay_hint">Browse guide details here. Select the catch-up pill to open archive history.</string><string name="player_epg_short">EPG</string>@@ -182,7 +182,7 @@<string name="player_timer_warning_idle">Standby allowed in %1$s</string><string name="player_timer_warning_stop">Playback stops in %1$s</string><string name="player_track_audio">Select Audio Track</string>- <string name="player_track_live_translation">Real-time translation</string>+ <string name="player_track_live_translation" tools:ignore="MissingTranslation">Real-time translation</string><string name="player_track_off">Off</string><string name="player_track_subs">Select Subtitles</string><string name="player_try_alternate_stream">Try another path</string>diff --git a/feature/playback/src/main/res/values/playback_support_strings.xml b/feature/playback/src/main/res/values/playback_support_strings.xmlindex 22ea23c1..f4e1bcf9 100644--- a/feature/playback/src/main/res/values/playback_support_strings.xml+++ b/feature/playback/src/main/res/values/playback_support_strings.xml@@ -1,19 +1,19 @@-<resources>- <string name="cast_started">Casting to the connected device.</string>- <string name="cast_unavailable">Google Cast is unavailable on this device.</string>- <string name="cast_stream_unsupported">This stream format is not supported by Google Cast.</string>- <string name="cast_protocol_unsupported">RTSP and RTMP streams are not supported for casting.</string>- <string name="cast_drm_unsupported">DRM-protected streams are not supported by Google Cast in this app.</string>- <string name="cast_item_unavailable">This item cannot be sent to a Cast receiver.</string>- <string name="cast_local_url_unsupported">This stream uses a local or device-only URL that Chromecast cannot reach directly.</string>- <string name="cast_headers_unsupported">This stream needs HTTP headers or cookies that Chromecast cannot use directly.</string>- <string name="cast_user_agent_unsupported">This stream needs a custom User-Agent that Chromecast cannot use directly.</string>- <string name="cast_proxy_unsupported">This stream needs the app proxy settings, so Chromecast cannot use it directly.</string>- <string name="cast_invalid_ssl_unsupported">This stream uses SSL handling that Chromecast cannot use directly.</string>- <string name="cast_session_failed">The Cast session could not be started.</string>- <string name="cast_load_failed">The Cast receiver could not load this stream.</string>- <string name="cast_receiver_unavailable">The connected Cast receiver is not ready for playback.</string>- <string name="cast_selection_cancelled">Cast device selection was cancelled.</string>+<resources xmlns:tools="http://schemas.android.com/tools">+ <string name="cast_started" tools:ignore="MissingTranslation">Casting to the connected device.</string>+ <string name="cast_unavailable" tools:ignore="MissingTranslation">Google Cast is unavailable on this device.</string>+ <string name="cast_stream_unsupported" tools:ignore="MissingTranslation">This stream format is not supported by Google Cast.</string>+ <string name="cast_protocol_unsupported" tools:ignore="MissingTranslation">RTSP and RTMP streams are not supported for casting.</string>+ <string name="cast_drm_unsupported" tools:ignore="MissingTranslation">DRM-protected streams are not supported by Google Cast in this app.</string>+ <string name="cast_item_unavailable" tools:ignore="MissingTranslation">This item cannot be sent to a Cast receiver.</string>+ <string name="cast_local_url_unsupported" tools:ignore="MissingTranslation">This stream uses a local or device-only URL that Chromecast cannot reach directly.</string>+ <string name="cast_headers_unsupported" tools:ignore="MissingTranslation">This stream needs HTTP headers or cookies that Chromecast cannot use directly.</string>+ <string name="cast_user_agent_unsupported" tools:ignore="MissingTranslation">This stream needs a custom User-Agent that Chromecast cannot use directly.</string>+ <string name="cast_proxy_unsupported" tools:ignore="MissingTranslation">This stream needs the app proxy settings, so Chromecast cannot use it directly.</string>+ <string name="cast_invalid_ssl_unsupported" tools:ignore="MissingTranslation">This stream uses SSL handling that Chromecast cannot use directly.</string>+ <string name="cast_session_failed" tools:ignore="MissingTranslation">The Cast session could not be started.</string>+ <string name="cast_load_failed" tools:ignore="MissingTranslation">The Cast receiver could not load this stream.</string>+ <string name="cast_receiver_unavailable" tools:ignore="MissingTranslation">The connected Cast receiver is not ready for playback.</string>+ <string name="cast_selection_cancelled" tools:ignore="MissingTranslation">Cast device selection was cancelled.</string><string name="add_group_close_cd">Close</string><string name="player_archive_title">Program Archive</string><string name="player_no_archive">No archived programs found</string>