Skip to content

StreamVault is a TV-first free IPTV player for Android TV built with Kotlin, Jetpack Compose, Room, Hilt, and Media3.

feat(catalog): add feature module boundary

David Nashash70bb99ea6fd7
diff --git a/app/build.gradle.kts b/app/build.gradle.kts
index 26d03612..09ca5347 100644
--- a/app/build.gradle.kts
+++ b/app/build.gradle.kts
@@ -453,6 +453,7 @@ dependencies {
implementation(project(":feature:provider"))
implementation(project(":feature:settings"))
implementation(project(":feature:live"))
+ implementation(project(":feature:catalog"))
implementation(libs.profileinstaller)
baselineProfile(project(":benchmark"))
diff --git a/feature/catalog/build.gradle.kts b/feature/catalog/build.gradle.kts
new file mode 100644
index 00000000..e06b107f
--- /dev/null
+++ b/feature/catalog/build.gradle.kts
@@ -0,0 +1,203 @@
+import org.gradle.api.artifacts.ProjectDependency
+
+plugins {
+ alias(libs.plugins.android.library)
+ alias(libs.plugins.kotlin.android)
+ alias(libs.plugins.kotlin.compose)
+ alias(libs.plugins.ksp)
+ alias(libs.plugins.hilt)
+ alias(libs.plugins.kover)
+}
+
+android {
+ namespace = "com.streamvault.feature.catalog"
+ compileSdk = 36
+
+ defaultConfig {
+ minSdk = 25
+ testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
+ }
+
+ compileOptions {
+ isCoreLibraryDesugaringEnabled = true
+ sourceCompatibility = JavaVersion.VERSION_17
+ targetCompatibility = JavaVersion.VERSION_17
+ }
+
+ buildFeatures {
+ compose = true
+ }
+}
+
+kotlin {
+ compilerOptions {
+ jvmTarget.set(org.jetbrains.kotlin.gradle.dsl.JvmTarget.JVM_17)
+ }
+}
+
+kover {
+ currentProject {
+ createVariant("ci") {
+ add("debug")
+ }
+ }
+}
+
+val allowedProjectDependencies = setOf(
+ ":core:navigation",
+ ":core:ui",
+ ":domain",
+ ":data",
+)
+
+val forbiddenFeatureCatalogSourceTokens = listOf(
+ "import com.streamvault.app",
+ "com.streamvault.app",
+ "import com.streamvault.player",
+ "com.streamvault.player",
+ "import com.streamvault.feature.playback",
+ "com.streamvault.feature.playback",
+ "import com.streamvault.feature.provider",
+ "com.streamvault.feature.provider",
+ "import com.streamvault.feature.settings",
+ "com.streamvault.feature.settings",
+ "import com.streamvault.feature.live",
+ "com.streamvault.feature.live",
+ "MainActivity",
+ "NavHostController",
+ "NavController",
+)
+
+fun findForbiddenFeatureCatalogSourceReferences(sourceRoot: java.io.File): List<String> = sourceRoot
+ .walkTopDown()
+ .filter { it.isFile && it.extension in setOf("kt", "java") }
+ .flatMap { file ->
+ file.readLines().flatMapIndexed { index, line ->
+ forbiddenFeatureCatalogSourceTokens.filter(line::contains).map { token ->
+ "${file.relativeTo(sourceRoot)}:${index + 1}: ${token}"
+ }
+ }
+ }
+ .toList()
+
+val featureCatalogBoundaryReport = layout.buildDirectory.file(
+ "reports/feature-catalog-boundary/report.txt"
+)
+
+val verifyFeatureCatalogBoundary = tasks.register("verifyFeatureCatalogBoundary") {
+ group = "verification"
+ description = "Verifies that the Catalog feature source and dependencies remain app-independent."
+ outputs.file(featureCatalogBoundaryReport)
+ outputs.upToDateWhen { false }
+ notCompatibleWithConfigurationCache(
+ "The boundary scan reads resolved Gradle model state at execution time."
+ )
+
+ doLast {
+ val projectDependencyPaths = configurations
+ .flatMap { configuration ->
+ configuration.dependencies
+ .withType<ProjectDependency>()
+ .filter { dependency -> dependency.path != project.path }
+ .map { dependency -> dependency.path }
+ }
+ .toSet()
+
+ check(projectDependencyPaths == allowedProjectDependencies) {
+ ":feature:catalog project dependencies must be exactly " +
+ "${allowedProjectDependencies.sorted()}; found ${projectDependencyPaths.sorted()}"
+ }
+
+ val sourceRoot = layout.projectDirectory.asFile.resolve("src/main")
+ val violations = findForbiddenFeatureCatalogSourceReferences(sourceRoot)
+ check(violations.isEmpty()) {
+ ":feature:catalog contains forbidden app, player, feature, or root navigation references:\n" +
+ violations.joinToString("\n")
+ }
+
+ val fixtureRoot = layout.projectDirectory.asFile.resolve("src/test/resources/boundary-fixtures")
+ val fixtureViolations = findForbiddenFeatureCatalogSourceReferences(fixtureRoot)
+ val requiredFixtureViolations = setOf(
+ "AppPackageImport.kt:3: import com.streamvault.app",
+ "FullyQualifiedAppReference.kt:3: com.streamvault.app",
+ "MainActivityReference.java:4: MainActivity",
+ "RootNavigation.kt:3: NavHostController",
+ "RootNavigation.java:4: NavController",
+ "PlaybackFeatureImport.kt:3: import com.streamvault.feature.playback",
+ "ProviderFeatureImport.kt:3: import com.streamvault.feature.provider",
+ "SettingsFeatureImport.java:4: com.streamvault.feature.settings",
+ "LiveFeatureImport.kt:3: import com.streamvault.feature.live",
+ "PlayerModuleImport.java:4: com.streamvault.player",
+ )
+ check(fixtureViolations.containsAll(requiredFixtureViolations)) {
+ ":feature:catalog boundary fixtures are not detected: " +
+ "${requiredFixtureViolations - fixtureViolations.toSet()}"
+ }
+
+ val reportFile = featureCatalogBoundaryReport.get().asFile
+ reportFile.parentFile.mkdirs()
+ reportFile.writeText(
+ listOf(
+ "projectDependencies=${projectDependencyPaths.sorted().joinToString(",")}",
+ "mainSourceViolations=${violations.joinToString("|")}",
+ "fixtureViolations=${fixtureViolations.joinToString("|")}"
+ ).joinToString("\n")
+ )
+ println(
+ "Verified :feature:catalog boundary: approved dependencies, no forbidden source references, " +
+ "and Kotlin/Java fixture coverage."
+ )
+ }
+}
+
+tasks.named("check") {
+ dependsOn(verifyFeatureCatalogBoundary)
+}
+
+tasks.withType<org.gradle.api.tasks.testing.Test>().configureEach {
+ dependsOn(verifyFeatureCatalogBoundary)
+}
+
+dependencies {
+ coreLibraryDesugaring(libs.desugar.jdk.libs)
+
+ implementation(project(":core:navigation"))
+ implementation(project(":core:ui"))
+ implementation(project(":domain"))
+ implementation(project(":data"))
+
+ implementation(platform(libs.compose.bom))
+ implementation(libs.compose.ui)
+ implementation(libs.compose.material3)
+ implementation(libs.compose.material.icons.extended)
+ implementation(libs.compose.tv.foundation)
+ implementation(libs.compose.tv.material)
+ implementation(libs.activity.compose)
+ implementation(libs.lifecycle.runtime.ktx)
+ implementation(libs.lifecycle.runtime.compose)
+ implementation(libs.lifecycle.viewmodel.compose)
+ implementation(libs.navigation.compose)
+ implementation(libs.hilt.android)
+ ksp(libs.hilt.compiler)
+ implementation(libs.hilt.navigation.compose)
+ implementation(libs.coroutines.core)
+ implementation(libs.coroutines.android)
+ implementation(libs.core.ktx)
+ implementation(libs.documentfile)
+ implementation(libs.okhttp)
+ implementation(libs.okhttp.logging)
+ implementation(libs.zxing.core)
+
+ testImplementation(libs.junit)
+ testImplementation(libs.truth)
+ testImplementation(libs.coroutines.test)
+ testImplementation(libs.robolectric)
+ testImplementation(libs.mockito.kotlin)
+
+ androidTestImplementation(platform(libs.compose.bom))
+ androidTestImplementation("androidx.compose.ui:ui-test-junit4")
+ androidTestImplementation(libs.navigation.testing)
+ androidTestImplementation(libs.androidx.test.ext.junit)
+ androidTestImplementation(libs.androidx.test.runner)
+ androidTestImplementation(libs.truth)
+}
diff --git a/feature/catalog/src/main/AndroidManifest.xml b/feature/catalog/src/main/AndroidManifest.xml
new file mode 100644
index 00000000..94cbbcfc
--- /dev/null
+++ b/feature/catalog/src/main/AndroidManifest.xml
@@ -0,0 +1 @@
+<manifest xmlns:android="http://schemas.android.com/apk/res/android" />
diff --git a/feature/catalog/src/test/java/com/streamvault/feature/catalog/CatalogModuleBoundaryTest.kt b/feature/catalog/src/test/java/com/streamvault/feature/catalog/CatalogModuleBoundaryTest.kt
new file mode 100644
index 00000000..ae9a37ef
--- /dev/null
+++ b/feature/catalog/src/test/java/com/streamvault/feature/catalog/CatalogModuleBoundaryTest.kt
@@ -0,0 +1,51 @@
+package com.streamvault.feature.catalog
+
+import com.google.common.truth.Truth.assertThat
+import java.io.File
+import org.junit.Test
+
+class CatalogModuleBoundaryTest {
+ @Test
+ fun catalogModuleDeclaresOnlyApprovedProjectDependencies() {
+ val buildFile = File("build.gradle.kts")
+ assertThat(buildFile.isFile).isTrue()
+ val text = buildFile.readText()
+
+ assertThat(text).contains("verifyFeatureCatalogBoundary")
+ assertThat(text).contains("implementation(project(\":core:navigation\"))")
+ assertThat(text).contains("implementation(project(\":core:ui\"))")
+ assertThat(text).contains("implementation(project(\":domain\"))")
+ assertThat(text).contains("implementation(project(\":data\"))")
+ assertThat(text).doesNotContain("project(\":app\")")
+ assertThat(text).doesNotContain("project(\":player\")")
+ assertThat(text).doesNotContain("project(\":feature:")
+ }
+
+ @Test
+ fun catalogBoundaryReportHasNoMainSourceViolations() {
+ val report = File("build/reports/feature-catalog-boundary/report.txt")
+ assertThat(report.isFile).isTrue()
+ val lines = report.readLines()
+ assertThat(lines).contains("projectDependencies=:core:navigation,:core:ui,:data,:domain")
+ assertThat(lines).contains("mainSourceViolations=")
+ assertThat(lines.first { it.startsWith("mainSourceViolations=") })
+ .isEqualTo("mainSourceViolations=")
+ }
+
+ @Test
+ fun catalogBoundaryReportDetectsEveryFixtureCategory() {
+ val report = File("build/reports/feature-catalog-boundary/report.txt")
+ val fixtureLine = report.readLines().first { it.startsWith("fixtureViolations=") }
+
+ assertThat(fixtureLine).contains("AppPackageImport.kt:3: import com.streamvault.app")
+ assertThat(fixtureLine).contains("FullyQualifiedAppReference.kt:3: com.streamvault.app")
+ assertThat(fixtureLine).contains("MainActivityReference.java:4: MainActivity")
+ assertThat(fixtureLine).contains("RootNavigation.kt:3: NavHostController")
+ assertThat(fixtureLine).contains("RootNavigation.java:4: NavController")
+ assertThat(fixtureLine).contains("PlaybackFeatureImport.kt:3: import com.streamvault.feature.playback")
+ assertThat(fixtureLine).contains("ProviderFeatureImport.kt:3: import com.streamvault.feature.provider")
+ assertThat(fixtureLine).contains("SettingsFeatureImport.java:4: com.streamvault.feature.settings")
+ assertThat(fixtureLine).contains("LiveFeatureImport.kt:3: import com.streamvault.feature.live")
+ assertThat(fixtureLine).contains("PlayerModuleImport.java:4: com.streamvault.player")
+ }
+}
diff --git a/feature/catalog/src/test/resources/boundary-fixtures/AppPackageImport.kt b/feature/catalog/src/test/resources/boundary-fixtures/AppPackageImport.kt
new file mode 100644
index 00000000..3dd90aaa
--- /dev/null
+++ b/feature/catalog/src/test/resources/boundary-fixtures/AppPackageImport.kt
@@ -0,0 +1,5 @@
+package boundary.fixtures
+
+import com.streamvault.app.FixtureAppType
+
+internal val appPackageImport: Class<*> = FixtureAppType::class.java
diff --git a/feature/catalog/src/test/resources/boundary-fixtures/FullyQualifiedAppReference.kt b/feature/catalog/src/test/resources/boundary-fixtures/FullyQualifiedAppReference.kt
new file mode 100644
index 00000000..3d80b901
--- /dev/null
+++ b/feature/catalog/src/test/resources/boundary-fixtures/FullyQualifiedAppReference.kt
@@ -0,0 +1,3 @@
+package boundary.fixtures
+
+internal val fullyQualifiedAppReference = com.streamvault.app.FixtureAppType::class
diff --git a/feature/catalog/src/test/resources/boundary-fixtures/LiveFeatureImport.kt b/feature/catalog/src/test/resources/boundary-fixtures/LiveFeatureImport.kt
new file mode 100644
index 00000000..b9a56740
--- /dev/null
+++ b/feature/catalog/src/test/resources/boundary-fixtures/LiveFeatureImport.kt
@@ -0,0 +1,5 @@
+package boundary.fixtures
+
+import com.streamvault.feature.live.FixtureLiveType
+
+internal val liveFeatureImport: Class<*> = FixtureLiveType::class.java
diff --git a/feature/catalog/src/test/resources/boundary-fixtures/MainActivityReference.java b/feature/catalog/src/test/resources/boundary-fixtures/MainActivityReference.java
new file mode 100644
index 00000000..bf9135d3
--- /dev/null
+++ b/feature/catalog/src/test/resources/boundary-fixtures/MainActivityReference.java
@@ -0,0 +1,5 @@
+package boundary.fixtures;
+
+class ActivityReference {
+ Class<?> activity = MainActivity.class;
+}
diff --git a/feature/catalog/src/test/resources/boundary-fixtures/PlaybackFeatureImport.kt b/feature/catalog/src/test/resources/boundary-fixtures/PlaybackFeatureImport.kt
new file mode 100644
index 00000000..9769a004
--- /dev/null
+++ b/feature/catalog/src/test/resources/boundary-fixtures/PlaybackFeatureImport.kt
@@ -0,0 +1,5 @@
+package boundary.fixtures
+
+import com.streamvault.feature.playback.FixturePlaybackType
+
+internal val playbackFeatureImport: Class<*> = FixturePlaybackType::class.java
diff --git a/feature/catalog/src/test/resources/boundary-fixtures/PlayerModuleImport.java b/feature/catalog/src/test/resources/boundary-fixtures/PlayerModuleImport.java
new file mode 100644
index 00000000..6311030c
--- /dev/null
+++ b/feature/catalog/src/test/resources/boundary-fixtures/PlayerModuleImport.java
@@ -0,0 +1,5 @@
+package boundary.fixtures;
+
+class PlayerModuleImport {
+ com.streamvault.player.FixturePlayerType player;
+}
diff --git a/feature/catalog/src/test/resources/boundary-fixtures/ProviderFeatureImport.kt b/feature/catalog/src/test/resources/boundary-fixtures/ProviderFeatureImport.kt
new file mode 100644
index 00000000..9da5ad0f
--- /dev/null
+++ b/feature/catalog/src/test/resources/boundary-fixtures/ProviderFeatureImport.kt
@@ -0,0 +1,5 @@
+package boundary.fixtures
+
+import com.streamvault.feature.provider.FixtureProviderType
+
+internal val providerFeatureImport: Class<*> = FixtureProviderType::class.java
diff --git a/feature/catalog/src/test/resources/boundary-fixtures/RootNavigation.java b/feature/catalog/src/test/resources/boundary-fixtures/RootNavigation.java
new file mode 100644
index 00000000..ec4de0a2
--- /dev/null
+++ b/feature/catalog/src/test/resources/boundary-fixtures/RootNavigation.java
@@ -0,0 +1,5 @@
+package boundary.fixtures;
+
+class RootNavigation {
+ NavController controller;
+}
diff --git a/feature/catalog/src/test/resources/boundary-fixtures/RootNavigation.kt b/feature/catalog/src/test/resources/boundary-fixtures/RootNavigation.kt
new file mode 100644
index 00000000..b258d961
--- /dev/null
+++ b/feature/catalog/src/test/resources/boundary-fixtures/RootNavigation.kt
@@ -0,0 +1,3 @@
+package boundary.fixtures
+
+internal fun rootNavigation(controller: NavHostController) = controller
diff --git a/feature/catalog/src/test/resources/boundary-fixtures/SettingsFeatureImport.java b/feature/catalog/src/test/resources/boundary-fixtures/SettingsFeatureImport.java
new file mode 100644
index 00000000..bcad4ae1
--- /dev/null
+++ b/feature/catalog/src/test/resources/boundary-fixtures/SettingsFeatureImport.java
@@ -0,0 +1,5 @@
+package boundary.fixtures;
+
+class SettingsFeatureImport {
+ com.streamvault.feature.settings.FixtureSettingsType settings;
+}
diff --git a/settings.gradle.kts b/settings.gradle.kts
index c2348383..848aecb5 100644
--- a/settings.gradle.kts
+++ b/settings.gradle.kts
@@ -27,3 +27,4 @@ include(":feature:playback")
include(":feature:provider")
include(":feature:settings")
include(":feature:live")
+include(":feature:catalog")