Skip to content

StreamVault is a TV-first free IPTV player for Android TV built with Kotlin, Jetpack Compose, Room, Hilt, and Media3.

fix(playback): persist selected subtitle preference

David Nashash746622088ee4
diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md
index aac73ede..1b4f402b 100644
--- a/docs/CHANGELOG.md
+++ b/docs/CHANGELOG.md
@@ -29,6 +29,7 @@ All notable product changes are recorded in this document.
### Fixed
+- Fixed selected subtitles reverting to off by saving track details before the player refreshes its available subtitle list.
- Fixed Guide schedules briefly appearing and disappearing during background updates, and missing provider EPG requests for channels loaded after the first page.
- Fixed Jellyfin Quick Connect QR links to use the Web Quick Connect route and safely encode the pairing code.
- Fixed QR provider pairing session cleanup and request validation, including expired sessions, malformed or oversized submissions, slow clients, and duplicate submissions.
diff --git a/feature/playback/src/main/java/com/streamvault/feature/playback/player/PlayerPlaybackPreferenceActions.kt b/feature/playback/src/main/java/com/streamvault/feature/playback/player/PlayerPlaybackPreferenceActions.kt
index 8718ac26..88910329 100644
--- a/feature/playback/src/main/java/com/streamvault/feature/playback/player/PlayerPlaybackPreferenceActions.kt
+++ b/feature/playback/src/main/java/com/streamvault/feature/playback/player/PlayerPlaybackPreferenceActions.kt
@@ -36,17 +36,22 @@ fun PlayerViewModel.selectAudioTrack(trackId: String) {
}
fun PlayerViewModel.selectSubtitleTrack(trackId: String?) {
- playerEngine.selectSubtitleTrack(trackId)
+ // Capture the track before changing the engine selection. Some engines emit a
+ // new track list synchronously, which can make a valid selection look unavailable.
val selectedTrack = trackId?.let { id ->
playerEngine.availableSubtitleTracks.value.firstOrNull { it.id == id }
}
- if (trackId != null && selectedTrack == null) return
+ playerEngine.selectSubtitleTrack(trackId)
val current = activeVodTrackPreferences ?: VodTrackPreferences()
+ val subtitlePreference = if (trackId == null) {
+ VodTrackPreference(disabled = true)
+ } else {
+ selectedTrack?.toVodTrackPreference() ?: VodTrackPreference(trackId = trackId)
+ }
persistVodTrackPreferences(
updated = current.copy(
- subtitle = selectedTrack?.toVodTrackPreference()
- ?: VodTrackPreference(disabled = true)
+ subtitle = subtitlePreference
)
)
}