StreamVault is a TV-first free IPTV player for Android TV built with Kotlin, Jetpack Compose, Room, Hilt, and Media3.
Kotlin iptv-player
Annotate all audit issues with resolution status badges
Davidona9f637d15f46d
diff --git a/docs/audit/01_CRITICAL_BLOCKERS.md b/docs/audit/01_CRITICAL_BLOCKERS.mdindex 3af5c007..561cb309 100644--- a/docs/audit/01_CRITICAL_BLOCKERS.md+++ b/docs/audit/01_CRITICAL_BLOCKERS.md@@ -4,7 +4,7 @@ All ship-blocking issues that will cause crashes, data loss, or security vulnera----## 1. Missing `proguard-rules.pro` — Release Builds Will Fail+## 1. ✅ FIXED — Missing `proguard-rules.pro` — Release Builds Will Fail**Module:** Build Configuration**File:** `app/build.gradle.kts`@@ -36,7 +36,7 @@ buildTypes {----## 2. Decoder Mode Logic Is Reversed+## 2. ✅ FIXED — Decoder Mode Logic Is Reversed**Module:** Player**File:** `player/src/main/java/com/streamvault/player/Media3PlayerEngine.kt` (lines 81–86)@@ -62,7 +62,7 @@ DecoderMode.SOFTWARE -> DefaultRenderersFactory.EXTENSION_RENDERER_MODE_OFF----## 3. No MediaSession Integration — TV Remote Won't Work+## 3. ✅ FIXED — No MediaSession Integration — TV Remote Won't Work**Module:** Player**File:** `player/src/main/java/com/streamvault/player/Media3PlayerEngine.kt`@@ -88,7 +88,7 @@ mediaSession?.release()----## 4. `pixelWidthHeightRatio` Stored as Frame Rate+## 4. ✅ FIXED — `pixelWidthHeightRatio` Stored as Frame Rate**Module:** Player**File:** `player/src/main/java/com/streamvault/player/Media3PlayerEngine.kt` (line 180)@@ -115,7 +115,7 @@ override fun onVideoInputFormatChanged(eventTime: EventTime, format: Format, ...----## 5. EPG Staging Uses Negative Provider IDs — Data Corruption Risk+## 5. ⚠️ MITIGATED — EPG Staging Uses Negative Provider IDs — Data Corruption Risk**Module:** Data**File:** `data/src/main/java/com/streamvault/data/repository/EpgRepositoryImpl.kt` (lines 48–49)@@ -134,7 +134,7 @@ Using negative provider IDs as a staging mechanism creates a race condition: if----## 6. M3U Category ID Collision Across Providers+## 6. ✅ FIXED — M3U Category ID Collision Across Providers**Module:** Data**File:** `data/src/main/java/com/streamvault/data/sync/SyncManager.kt` (lines 419–430)@@ -155,7 +155,7 @@ Category IDs are allocated sequentially (1–9999 for LIVE, 10000+ for MOVIE) wi----## 7. Database Migration 8→9 ID Remapping Can Corrupt References+## 7. ⏭️ DEFERRED — Database Migration 8→9 ID Remapping Can Corrupt References**Module:** Data**File:** `data/src/main/java/com/streamvault/data/local/StreamVaultDatabase.kt` (lines 180–290)@@ -177,7 +177,7 @@ If duplicate `(provider_id, stream_id)` pairs exist in source data (which M3U im----## 8. ViewModels Never Cancel Background Jobs — Memory Leaks+## 8. ✅ FIXED — ViewModels Never Cancel Background Jobs — Memory Leaks**Module:** App**Files:** Multiple ViewModels@@ -226,7 +226,7 @@ override fun onCleared() {----## 9. Credentials Can Leak Into Crash Logs+## 9. ✅ FIXED — Credentials Can Leak Into Crash Logs**Module:** Data**File:** `data/src/main/java/com/streamvault/data/sync/SyncManager.kt` (lines 738–753)@@ -249,7 +249,7 @@ Log.e(TAG, "Sync failed for provider $providerId: $safeMessage")----## 10. No Signing Configuration for Release+## 10. ✅ FIXED — No Signing Configuration for Release**Module:** Build**File:** `app/build.gradle.kts`@@ -271,7 +271,7 @@ signingConfigs {----## 11. ParentalControlManager Has Race Condition and No Persistence+## 11. ✅ FIXED (race) / ⚠️ BY DESIGN (persistence) — ParentalControlManager Has Race Condition and No Persistence**Module:** Domain**File:** `domain/src/main/java/com/streamvault/domain/manager/ParentalControlManager.kt` (lines 21–28)@@ -293,7 +293,7 @@ fun unlockCategory(providerId: Long, categoryId: Long) {----## 12. No Foreign Key Constraints in Room Database+## 12. ⏭️ DEFERRED — No Foreign Key Constraints in Room Database**Module:** Data**File:** `data/src/main/java/com/streamvault/data/local/entity/Entities.kt`@@ -315,7 +315,7 @@ Room entities have no `@ForeignKey` annotations. Deleting a provider leaves behi----## 13. XML Date Parsing Returns Epoch 0 Silently+## 13. ✅ FIXED — XML Date Parsing Returns Epoch 0 Silently**Module:** Data**File:** `data/src/main/java/com/streamvault/data/parser/XmltvParser.kt` (lines 184–200)@@ -336,7 +336,7 @@ Any XMLTV program with an unparseable date gets `startTime = 0`, placing it in t----## 14. M3U Input Not Length-Bounded (DoS Vector)+## 14. ✅ FIXED — M3U Input Not Length-Bounded (DoS Vector)**Module:** Data**File:** `data/src/main/java/com/streamvault/data/parser/M3uParser.kt` (lines 299–330)@@ -351,7 +351,7 @@ Channel names, group titles, and other strings from M3U files have no maximum le----## 15. `file://` URI Exposure+## 15. ⚠️ FALSE POSITIVE — `file://` URI Exposure**Module:** App**File:** `app/src/main/java/com/streamvault/app/ui/screens/provider/ProviderSetupScreen.kt` (line 91)@@ -367,7 +367,7 @@ Direct `file://` URIs are forbidden on Android 7+ (API 24) for cross-process sha----## 16. No Error Recovery Strategy in Player+## 16. ✅ FIXED — No Error Recovery Strategy in Player**Module:** Player**File:** `player/src/main/java/com/streamvault/player/Media3PlayerEngine.kt` (lines 172–173)diff --git a/docs/audit/02_PLAYER_ENGINE.md b/docs/audit/02_PLAYER_ENGINE.mdindex 96462032..4ba46c46 100644--- a/docs/audit/02_PLAYER_ENGINE.md+++ b/docs/audit/02_PLAYER_ENGINE.md@@ -4,13 +4,13 @@ All issues related to media playback, decoding, buffering, and streaming.----## 1. Decoder Mode Logic Is Reversed+## 1. ✅ FIXED — Decoder Mode Logic Is Reversed> See [01_CRITICAL_BLOCKERS.md #2](01_CRITICAL_BLOCKERS.md#2-decoder-mode-logic-is-reversed)----## 2. Buffer Configuration Too Low for IPTV+## 2. ✅ FIXED — Buffer Configuration Too Low for IPTV**File:** `player/src/main/java/com/streamvault/player/Media3PlayerEngine.kt` (lines 90–97)**Severity:** 🟠 HIGH@@ -37,25 +37,25 @@ val loadControl = DefaultLoadControl.Builder()----## 3. No MediaSession Integration+## 3. ✅ FIXED — No MediaSession Integration> See [01_CRITICAL_BLOCKERS.md #3](01_CRITICAL_BLOCKERS.md#3-no-mediasession-integration--tv-remote-wont-work)----## 4. No Network Error Recovery+## 4. ✅ FIXED — No Network Error Recovery> See [01_CRITICAL_BLOCKERS.md #16](01_CRITICAL_BLOCKERS.md#16-no-error-recovery-strategy-in-player)----## 5. Video Format Frame Rate Is Wrong+## 5. ✅ FIXED — Video Format Frame Rate Is Wrong> See [01_CRITICAL_BLOCKERS.md #4](01_CRITICAL_BLOCKERS.md#4-pixelwidthheightratio-stored-as-frame-rate)----## 6. Error Classification Is Fragile (String Matching)+## 6. ✅ FIXED — Error Classification Is Fragile (String Matching)**File:** `player/src/main/java/com/streamvault/player/PlayerEngine.kt` (lines 44–56)**Severity:** 🟠 HIGH@@ -97,7 +97,7 @@ fun fromException(e: Throwable): PlayerError = when (e) {----## 7. No Explicit Network Timeout on Data Source+## 7. ✅ FIXED — No Explicit Network Timeout on Data Source**File:** `player/src/main/java/com/streamvault/player/Media3PlayerEngine.kt` (lines 218–237)**Severity:** 🟠 HIGH@@ -114,7 +114,7 @@ OkHttpDataSource.Factory(okHttpClient)----## 8. No Background/Foreground Lifecycle Handling+## 8. ✅ FIXED — No Background/Foreground Lifecycle Handling**File:** `player/src/main/java/com/streamvault/player/Media3PlayerEngine.kt`**Severity:** 🟠 HIGH@@ -129,7 +129,7 @@ The player has no awareness of app lifecycle transitions. When the user presses----## 9. Track Selection Has Redundant API Calls+## 9. ✅ FIXED — Track Selection Has Redundant API Calls**File:** `player/src/main/java/com/streamvault/player/Media3PlayerEngine.kt` (lines 347–413)**Severity:** 🟡 MEDIUM@@ -154,7 +154,7 @@ These should be combined into a single parameter update to avoid an intermediate----## 10. Polling Redundant with Position Discontinuity Listener+## 10. ⏭️ REMAINING — Polling Redundant with Position Discontinuity Listener**File:** `player/src/main/java/com/streamvault/player/Media3PlayerEngine.kt` (lines 427–437)**Severity:** 🟡 MEDIUM@@ -167,7 +167,7 @@ For multi-view (4 players), this means 4 × 2Hz = 8 position updates per second----## 11. No Bitrate / Quality Metrics for Diagnostics+## 11. ⏭️ DEFERRED — No Bitrate / Quality Metrics for Diagnostics**File:** `player/src/main/java/com/streamvault/player/PlayerEngine.kt` (PlayerStats data class)**Severity:** 🟡 MEDIUM@@ -193,7 +193,7 @@ Missing for premium diagnostics:----## 12. Stream Type Detection Incomplete+## 12. ✅ FIXED — Stream Type Detection Incomplete**File:** `player/src/main/java/com/streamvault/player/StreamTypeDetector.kt` (lines 14–32)**Severity:** 🟡 MEDIUM@@ -208,7 +208,7 @@ The fallback `StreamType.UNKNOWN` delegates to ExoPlayer's content-type sniffing----## 13. Audio Content Type Not Stream-Aware+## 13. ⏭️ REMAINING — Audio Content Type Not Stream-Aware**File:** `player/src/main/java/com/streamvault/player/Media3PlayerEngine.kt` (lines 106–110)**Severity:** 🔵 LOW@@ -227,7 +227,7 @@ The fallback `StreamType.UNKNOWN` delegates to ExoPlayer's content-type sniffing----## 14. No Chromecast / Cast Support+## 14. ⏭️ DEFERRED — No Chromecast / Cast Support**Severity:** 🟡 MEDIUM (for premium release)@@ -235,7 +235,7 @@ No Google Cast integration exists. Premium IPTV apps typically support casting f----## 15. Decoder Reuse Evaluation Not Logged+## 15. ⏭️ REMAINING — Decoder Reuse Evaluation Not Logged**File:** `player/src/main/java/com/streamvault/player/Media3PlayerEngine.kt` (lines 117–130)**Severity:** 🔵 LOW@@ -244,7 +244,7 @@ The `DecoderReuseEvaluation` parameter in `onVideoInputFormatChanged` is never i----## 16. Coroutine Scope Cleanup Not Guaranteed+## 16. ✅ FIXED — Coroutine Scope Cleanup Not Guaranteed**File:** `player/src/main/java/com/streamvault/player/Media3PlayerEngine.kt` (line 46)**Severity:** 🔵 LOWdiff --git a/docs/audit/03_DATA_LAYER.md b/docs/audit/03_DATA_LAYER.mdindex c552fbee..8aa92bc8 100644--- a/docs/audit/03_DATA_LAYER.md+++ b/docs/audit/03_DATA_LAYER.md@@ -4,49 +4,49 @@ Database, parsing, sync, data integrity, and repository implementation issues.----## 1. EPG Date Parsing Silently Returns Epoch 0+## 1. ✅ FIXED — EPG Date Parsing Silently Returns Epoch 0> See [01_CRITICAL_BLOCKERS.md #13](01_CRITICAL_BLOCKERS.md#13-xml-date-parsing-returns-epoch-0-silently)----## 2. M3U Input Not Length-Bounded+## 2. ✅ FIXED — M3U Input Not Length-Bounded> See [01_CRITICAL_BLOCKERS.md #14](01_CRITICAL_BLOCKERS.md#14-m3u-input-not-length-bounded-dos-vector)----## 3. EPG Staging Uses Negative Provider IDs+## 3. ⚠️ MITIGATED — EPG Staging Uses Negative Provider IDs> See [01_CRITICAL_BLOCKERS.md #5](01_CRITICAL_BLOCKERS.md#5-epg-staging-uses-negative-provider-ids--data-corruption-risk)----## 4. Category ID Collision Across Providers+## 4. ✅ FIXED — Category ID Collision Across Providers> See [01_CRITICAL_BLOCKERS.md #6](01_CRITICAL_BLOCKERS.md#6-m3u-category-id-collision-across-providers)----## 5. Database Migration 8→9 Unsafe ID Remapping+## 5. ⏭️ DEFERRED — Database Migration 8→9 Unsafe ID Remapping> See [01_CRITICAL_BLOCKERS.md #7](01_CRITICAL_BLOCKERS.md#7-database-migration-89-id-remapping-can-corrupt-references)----## 6. Credentials Can Leak in Logs+## 6. ✅ FIXED — Credentials Can Leak in Logs> See [01_CRITICAL_BLOCKERS.md #9](01_CRITICAL_BLOCKERS.md#9-credentials-can-leak-into-crash-logs)----## 7. No Foreign Key Constraints+## 7. ⏭️ DEFERRED — No Foreign Key Constraints> See [01_CRITICAL_BLOCKERS.md #12](01_CRITICAL_BLOCKERS.md#12-no-foreign-key-constraints-in-room-database)----## 8. M3U URL Validation Insufficient+## 8. ✅ FIXED — M3U URL Validation Insufficient**File:** `data/src/main/java/com/streamvault/data/parser/M3uParser.kt` (lines 312–320)**File:** `data/src/main/java/com/streamvault/data/sync/SyncManager.kt` (lines 448–451)@@ -65,7 +65,7 @@ if (uri.scheme !in listOf("http", "https")) return null----## 9. FTS Search Results Silently Truncated at 300+## 9. ✅ FIXED — FTS Search Results Silently Truncated at 300**File:** `data/src/main/java/com/streamvault/data/local/dao/Daos.kt` (lines 83–100)**Severity:** 🟠 HIGH@@ -79,7 +79,7 @@ SELECT COUNT(*) FROM channels_fts WHERE channels_fts MATCH :query----## 10. Large EPG Files Can Cause OOM+## 10. ⚠️ MITIGATED — Large EPG Files Can Cause OOM**File:** `data/src/main/java/com/streamvault/data/sync/SyncManager.kt` (lines 561–576)**Severity:** 🟠 HIGH@@ -93,7 +93,7 @@ The EPG download uses a 64KB `GZIPInputStream` buffer, but for very large EPG fi----## 11. PlaybackHistory Restore Uses N+1 Query Pattern+## 11. ✅ FIXED — PlaybackHistory Restore Uses N+1 Query Pattern**File:** `data/src/main/java/com/streamvault/data/local/dao/Daos.kt` (lines 248–264)**Severity:** 🟠 HIGH@@ -113,7 +113,7 @@ The correlated subquery executes once per matched movie row. With 10,000+ movies----## 12. RecordingManager Race Condition+## 12. ✅ FIXED — RecordingManager Race Condition**File:** `data/src/main/java/com/streamvault/data/manager/RecordingManagerImpl.kt` (lines 50–52)**Severity:** 🟠 HIGH@@ -122,7 +122,7 @@ The `stateMutex` protects `itemsState` but `activeJobs` is accessed from multipl----## 13. M3U Parser Unquoted Attribute Values+## 13. ⏭️ REMAINING — M3U Parser Unquoted Attribute Values**File:** `data/src/main/java/com/streamvault/data/parser/M3uParser.kt` (lines 309–330)**Severity:** 🟡 MEDIUM@@ -136,7 +136,7 @@ The parser will extract only "My" as the group title because whitespace terminat----## 14. Adult Content Classifier Is English-Only+## 14. ✅ FIXED — Adult Content Classifier Is English-Only**File:** `data/src/main/java/com/streamvault/data/util/AdultContentClassifier.kt` (lines 6–19)**Severity:** 🟡 MEDIUM@@ -145,7 +145,7 @@ The classifier uses a hardcoded English keyword list. Content in Spanish, German----## 15. XMLTV Date Format Support Limited+## 15. ✅ FIXED — XMLTV Date Format Support Limited**File:** `data/src/main/java/com/streamvault/data/parser/XmltvParser.kt` (lines 39–43)**Severity:** 🟡 MEDIUM@@ -159,7 +159,7 @@ Missing formats cause programs to fall through to the epoch-0 fallback.----## 16. Backup File Has No Integrity Check+## 16. ✅ FIXED — Backup File Has No Integrity Check**File:** `data/src/main/java/com/streamvault/data/manager/BackupManagerImpl.kt` (lines 53–101)**Severity:** 🟡 MEDIUM@@ -170,7 +170,7 @@ Exported and imported backup files have no checksum, signature, or version valid----## 17. SimpleDateFormat Thread Safety+## 17. ✅ FIXED — SimpleDateFormat Thread Safety**File:** `data/src/main/java/com/streamvault/data/parser/XmltvParser.kt` (lines 39–43)**Severity:** 🔵 LOW@@ -185,7 +185,7 @@ private val dateFormats = listOf(----## 18. No Pagination Metadata in Repositories+## 18. ⏭️ DEFERRED — No Pagination Metadata in Repositories**File:** `data/src/main/java/com/streamvault/data/repository/MovieRepositoryImpl.kt` (lines 150–162)**Severity:** 🟡 MEDIUM@@ -194,7 +194,7 @@ Movie/Series pagination queries don't return the total count. The UI has no way----## 19. PIN Hashing - RNG Initialization+## 19. ⏭️ REMAINING — PIN Hashing - RNG Initialization**File:** `data/src/main/java/com/streamvault/data/preferences/PreferencesRepository.kt` (lines 28–31)**Severity:** 🔵 LOW@@ -207,7 +207,7 @@ Creating a new `SecureRandom()` instance per call may use a weaker default provi----## 20. Migration 2→3 Lacks Data Validation+## 20. ⏭️ REMAINING — Migration 2→3 Lacks Data Validation**File:** `data/src/main/java/com/streamvault/data/local/StreamVaultDatabase.kt` (lines 47–57)**Severity:** 🔵 LOW@@ -216,7 +216,7 @@ ALTER TABLE migrations add columns but don't validate whether existing data sati----## 21. Unused Extra Attributes in M3U Entries+## 21. ⏭️ REMAINING — Unused Extra Attributes in M3U Entries**File:** `data/src/main/java/com/streamvault/data/parser/M3uParser.kt` (line 40)**Severity:** 🔵 LOW@@ -225,7 +225,7 @@ The parser captures unknown M3U attributes into an `extraAttributes` map that is----## 22. Xtream Unknown Status Not Logged+## 22. ⏭️ REMAINING — Xtream Unknown Status Not Logged**File:** `data/src/main/java/com/streamvault/data/remote/xtream/XtreamProvider.kt` (lines 82–90)**Severity:** 🔵 LOWdiff --git a/docs/audit/04_DOMAIN_LAYER.md b/docs/audit/04_DOMAIN_LAYER.mdindex c50fb6ae..e48678c2 100644--- a/docs/audit/04_DOMAIN_LAYER.md+++ b/docs/audit/04_DOMAIN_LAYER.md@@ -4,7 +4,7 @@ Architecture, models, use cases, and validation issues.----## 1. Domain Model Contains UI Logic+## 1. ✅ FIXED — Domain Model Contains UI Logic**File:** `domain/src/main/java/com/streamvault/domain/model/Program.kt` (lines 15–25)**Severity:** 🟠 HIGH@@ -25,7 +25,7 @@ This violates Clean Architecture — the domain model directly calls `System.cur----## 2. Severely Under-Developed Use Case Layer+## 2. ⏭️ DEFERRED — Severely Under-Developed Use Case Layer**File:** `domain/src/main/java/com/streamvault/domain/usecase/`**Severity:** 🟠 HIGH@@ -50,13 +50,13 @@ Only **1 use case** exists: `GetCustomCategories`. An IPTV app of this scope sho----## 3. ParentalControlManager — Race Condition and No Persistence+## 3. ✅ FIXED (race) / ⚠️ BY DESIGN (persistence) — ParentalControlManager — Race Condition and No Persistence> See [01_CRITICAL_BLOCKERS.md #11](01_CRITICAL_BLOCKERS.md#11-parentalcontrolmanager-has-race-condition-and-no-persistence)----## 4. No Data Validation Across Domain Models+## 4. ⏭️ DEFERRED — No Data Validation Across Domain Models**Severity:** 🟠 HIGH@@ -112,7 +112,7 @@ val scheduledEndMs: Long // Could be ≤ scheduledStartMs----## 5. Repository API Design Issues+## 5. ⏭️ DEFERRED — Repository API Design Issues### 5a. FavoriteRepository — Ambiguous API@@ -176,7 +176,7 @@ These can fail (database full, constraint violation) but the caller has no way t----## 6. ChannelNormalizer Algorithm Flawed+## 6. ✅ FIXED — ChannelNormalizer Algorithm Flawed**File:** `domain/src/main/java/com/streamvault/domain/util/ChannelNormalizer.kt` (lines 12–40)**Severity:** 🟡 MEDIUM@@ -190,7 +190,7 @@ The normalizer strips quality tags (HD, FHD, SD, 4K) to group "same" channels to----## 7. Category Model Has Redundant Protection Fields+## 7. ⏭️ DEFERRED — Category Model Has Redundant Protection Fields**File:** `domain/src/main/java/com/streamvault/domain/model/Category.kt`**Severity:** 🟡 MEDIUM@@ -206,7 +206,7 @@ Parental protection is tracked in two places: the `Category` model and the `Pare----## 8. Missing Domain Features for Premium IPTV+## 8. ⏭️ DEFERRED — Missing Domain Features for Premium IPTV**Severity:** 🟡 MEDIUM@@ -224,7 +224,7 @@ No domain models or repository interfaces exist for:----## 9. `GetCustomCategories` Swallows Exceptions+## 9. ⏭️ REMAINING — `GetCustomCategories` Swallows Exceptions**File:** `domain/src/main/java/com/streamvault/domain/usecase/GetCustomCategories.kt`**Severity:** 🟡 MEDIUM@@ -239,7 +239,7 @@ If the categories query fails, the UI shows "no categories" with no error indica----## 10. Provider Model Stores Credentials in Plain Data Class+## 10. ✅ FIXED — Provider Model Stores Credentials in Plain Data Class**File:** `domain/src/main/java/com/streamvault/domain/model/Provider.kt`**Severity:** 🟡 MEDIUM@@ -259,7 +259,7 @@ While credentials are encrypted at the storage layer (`CredentialCrypto`), the d----## 11. `StreamInfo` Model Exists but Underutilized+## 11. ⏭️ DEFERRED — `StreamInfo` Model Exists but Underutilized**File:** `domain/src/main/java/com/streamvault/domain/model/StreamInfo.kt`**Severity:** 🔵 LOWdiff --git a/docs/audit/05_UI_UX.md b/docs/audit/05_UI_UX.mdindex 8fca8f73..b8fdfd72 100644--- a/docs/audit/05_UI_UX.md+++ b/docs/audit/05_UI_UX.md@@ -4,7 +4,7 @@ Screens, navigation, accessibility, focus management, and presentation issues.----## 1. D-Pad Focus Trap Scenarios+## 1. ✅ FIXED — D-Pad Focus Trap Scenarios**Severity:** 🔴 CRITICAL@@ -35,7 +35,7 @@ If the user navigates out of the 2×2 player grid, there's no safe path back in.----## 2. Missing Error State UI on Content Screens+## 2. ✅ FIXED — Missing Error State UI on Content Screens**Severity:** 🔴 CRITICAL@@ -65,7 +65,7 @@ When query is under 2 characters, shows blank instead of a search hint or sugges----## 3. Accessibility — Missing Content Descriptions+## 3. ✅ FIXED — Accessibility — Missing Content Descriptions**Severity:** 🔴 CRITICAL@@ -97,7 +97,7 @@ Control buttons lack descriptions. No announcement when playback state changes (----## 4. RTL Layout Not Fully Mirrored+## 4. ✅ N/A — RTL Layout Not Fully Mirrored**Severity:** 🟠 HIGH@@ -123,13 +123,13 @@ Row header (title on left, "See All" on right) doesn't flip in RTL.----## 5. ViewModel Memory Leaks — Jobs Not Cancelled+## 5. ✅ FIXED — ViewModel Memory Leaks — Jobs Not Cancelled> See [01_CRITICAL_BLOCKERS.md #8](01_CRITICAL_BLOCKERS.md#8-viewmodels-never-cancel-background-jobs--memory-leaks)----## 6. LazyRow/LazyColumn Missing Stable Keys+## 6. ✅ FIXED — LazyRow/LazyColumn Missing Stable Keys**Severity:** 🟠 HIGH@@ -163,7 +163,7 @@ No keys during reorder operations → full re-compose on every reorder step.----## 7. Hardcoded English Strings in UI Code+## 7. ✅ FIXED — Hardcoded English Strings in UI Code**Severity:** 🟠 HIGH@@ -182,7 +182,7 @@ These strings are visible to users and will appear in English regardless of loca----## 8. Player Error Recovery Not Visible to User+## 8. ⏭️ REMAINING — Player Error Recovery Not Visible to User**Severity:** 🟠 HIGH@@ -198,7 +198,7 @@ Users have no idea why their stream quality changed, why the channel switched, o----## 9. DashboardScreen Missing States+## 9. ✅ FIXED — DashboardScreen Missing States**Severity:** 🟡 MEDIUM@@ -211,7 +211,7 @@ Users have no idea why their stream quality changed, why the channel switched, o----## 10. String Concatenation Pattern Breaks RTL+## 10. ✅ FIXED — String Concatenation Pattern Breaks RTL**Severity:** 🟡 MEDIUM@@ -225,7 +225,7 @@ String concatenation doesn't respect RTL text direction. In Arabic, the number s----## 11. HomeScreen Back Handler Missing+## 11. ✅ FIXED — HomeScreen Back Handler Missing**Severity:** 🟡 MEDIUM@@ -241,7 +241,7 @@ Currently relies on system default back behavior which may cause premature exit----## 12. Focus Restoration Uses `remember` Instead of `rememberSaveable`+## 12. ✅ FIXED — Focus Restoration Uses `remember` Instead of `rememberSaveable`**Severity:** 🟡 MEDIUM@@ -253,7 +253,7 @@ Using `remember` means focus state is lost on configuration changes (language ch----## 13. No Responsive Layout for Sidebar Width+## 13. ✅ FIXED — No Responsive Layout for Sidebar Width**Severity:** 🟡 MEDIUM@@ -267,7 +267,7 @@ Hardcoded 280dp sidebar width. On large TV screens (65"+) this is too narrow; on----## 14. No Animation on Category/Content Transitions+## 14. ⏭️ DEFERRED — No Animation on Category/Content Transitions**Severity:** 🟡 MEDIUM@@ -275,7 +275,7 @@ When selecting a category in HomeScreen, the channel grid content changes instan----## 15. Missing Numeric Channel Switching in All Contexts+## 15. ⏭️ REMAINING — Missing Numeric Channel Switching in All Contexts**Severity:** 🟡 MEDIUM@@ -286,7 +286,7 @@ Quick channel switching via numeric pad (0-9) exists in the player but may not w----## 16. No Loading Skeleton for Category Sidebar+## 16. ✅ FIXED — No Loading Skeleton for Category Sidebar**Severity:** 🔵 LOW@@ -294,7 +294,7 @@ Channel grid has skeleton loading, but the category sidebar shows nothing while----## 17. No Wrapping Navigation in Horizontal Lists+## 17. ⏭️ REMAINING — No Wrapping Navigation in Horizontal Lists**Severity:** 🔵 LOW@@ -302,7 +302,7 @@ When the user reaches the last item in a LazyRow and presses D-Pad right, nothin----## 18. Search Needs Minimum Query Length Hint+## 18. ⏭️ REMAINING — Search Needs Minimum Query Length Hint**Severity:** 🔵 LOW@@ -314,7 +314,7 @@ When the user types a single character, show a hint: "Type at least 2 characters----## 19. Multi-View Has No Slot Status Indicators+## 19. ⏭️ REMAINING — Multi-View Has No Slot Status Indicators**Severity:** 🔵 LOWdiff --git a/docs/audit/06_SECURITY.md b/docs/audit/06_SECURITY.mdindex 9a31b7bb..c7e8a3c9 100644--- a/docs/audit/06_SECURITY.md+++ b/docs/audit/06_SECURITY.md@@ -10,19 +10,19 @@ StreamVault's security foundation is solid — credentials are encrypted with AE----## 1. `file://` URI Exposure+## 1. ⚠️ FALSE POSITIVE — `file://` URI Exposure> See [01_CRITICAL_BLOCKERS.md #15](01_CRITICAL_BLOCKERS.md#15-file-uri-exposure)----## 2. Credentials Can Leak Into Crash Logs+## 2. ✅ FIXED — Credentials Can Leak Into Crash Logs> See [01_CRITICAL_BLOCKERS.md #9](01_CRITICAL_BLOCKERS.md#9-credentials-can-leak-into-crash-logs)----## 3. M3U URL Injection Vectors+## 3. ✅ FIXED — M3U URL Injection Vectors**File:** `data/src/main/java/com/streamvault/data/parser/M3uParser.kt`**Severity:** 🟠 HIGH@@ -40,7 +40,7 @@ While `UrlSecurityPolicy.isAllowedImportedUrl()` exists, the following attack ve----## 4. Provider Credentials in Domain Model `toString()`+## 4. ✅ FIXED — Provider Credentials in Domain Model `toString()`**File:** `domain/src/main/java/com/streamvault/domain/model/Provider.kt`**Severity:** 🟡 MEDIUM@@ -62,13 +62,13 @@ override fun toString(): String = "Provider(id=$id, name=$name, type=$type)"----## 5. M3U Input Not Length-Bounded+## 5. ✅ FIXED — M3U Input Not Length-Bounded> See [01_CRITICAL_BLOCKERS.md #14](01_CRITICAL_BLOCKERS.md#14-m3u-input-not-length-bounded-dos-vector)----## 6. No Certificate Pinning+## 6. ⏭️ N/A — No Certificate Pinning**Severity:** 🟡 MEDIUM@@ -78,7 +78,7 @@ No SSL/TLS certificate pinning is implemented for API communications. This is ty----## 7. Backup File Not Encrypted+## 7. ⏭️ DEFERRED — Backup File Not Encrypted**File:** `data/src/main/java/com/streamvault/data/manager/BackupManagerImpl.kt`**Severity:** 🟡 MEDIUM@@ -94,7 +94,7 @@ These are stored as plain JSON. If a user shares the backup file, their IPTV pro----## 8. PIN Stored as Hash Without Iteration Count+## 8. ⏭️ REMAINING — PIN Stored as Hash Without Iteration Count**File:** `data/src/main/java/com/streamvault/data/preferences/PreferencesRepository.kt`**Severity:** 🔵 LOWdiff --git a/docs/audit/07_TESTING_LOCALIZATION.md b/docs/audit/07_TESTING_LOCALIZATION.mdindex 489c2045..3bc55735 100644--- a/docs/audit/07_TESTING_LOCALIZATION.md+++ b/docs/audit/07_TESTING_LOCALIZATION.md@@ -6,7 +6,7 @@ Test coverage, test quality, translations, and resource issues.## Testing-### 1. Domain & Player Modules Have Zero Test Coverage+### 1. ⏭️ DEFERRED — Domain & Player Modules Have Zero Test Coverage**Severity:** 🔴 CRITICAL@@ -29,7 +29,7 @@ Test coverage, test quality, translations, and resource issues.----### 2. Existing Tests Are Surface-Level+### 2. ⏭️ DEFERRED — Existing Tests Are Surface-Level**Severity:** 🟠 HIGH@@ -46,7 +46,7 @@ Test coverage, test quality, translations, and resource issues.----### 3. No Integration Tests for Critical Flows+### 3. ⏭️ DEFERRED — No Integration Tests for Critical Flows**Severity:** 🟠 HIGH@@ -60,7 +60,7 @@ Missing end-to-end scenarios:----### 4. No Performance/Stress Tests+### 4. ⏭️ DEFERRED — No Performance/Stress Tests**Severity:** 🟡 MEDIUM@@ -73,7 +73,7 @@ No tests for:----### 5. Data Layer Tests Have Good Patterns+### 5. ✅ POSITIVE — Data Layer Tests Have Good Patterns**Severity:** ✅ POSITIVE@@ -88,7 +88,7 @@ These serve as good templates for expanding coverage.## Localization-### 3. Hardcoded English Strings in Code+### 3. ✅ FIXED — Hardcoded English Strings in Code> See [05_UI_UX.md #7](05_UI_UX.md#7-hardcoded-english-strings-in-ui-code)@@ -96,7 +96,7 @@ These serve as good templates for expanding coverage.----### 4. 26 Languages Supported — Coverage Appears Good+### 4. ✅ POSITIVE — 26 Languages Supported — Coverage Appears Good**Severity:** ✅ POSITIVE@@ -107,7 +107,7 @@ Spot-check of key strings across English, Spanish, French, and German shows prop----### 5. String Concatenation Breaks RTL+### 5. ✅ FIXED — String Concatenation Breaks RTL> See [05_UI_UX.md #10](05_UI_UX.md#10-string-concatenation-pattern-breaks-rtl)@@ -115,7 +115,7 @@ Spot-check of key strings across English, Spanish, French, and German shows prop## Resources-### 6. App Icon Missing Density Variants+### 6. ⏭️ DEFERRED — App Icon Missing Density Variants**Severity:** 🟠 HIGH@@ -136,13 +136,13 @@ Only the highest density icon is provided. On lower-density screens, the icon is----### 7. Missing ProGuard Rules File+### 7. ✅ FIXED — Missing ProGuard Rules File> See [01_CRITICAL_BLOCKERS.md #1](01_CRITICAL_BLOCKERS.md#1-missing-proguard-rulespro--release-builds-will-fail)----### 8. No Release Signing Configuration+### 8. ✅ FIXED — No Release Signing Configuration> See [01_CRITICAL_BLOCKERS.md #10](01_CRITICAL_BLOCKERS.md#10-no-signing-configuration-for-release)