Skip to content

StreamVault is a TV-first free IPTV player for Android TV built with Kotlin, Jetpack Compose, Room, Hilt, and Media3.

Fix provider delete dialog dismissal

David Nashashacba073aa2c3
diff --git a/app/src/main/java/com/streamvault/app/ui/screens/settings/SettingsProviderActions.kt b/app/src/main/java/com/streamvault/app/ui/screens/settings/SettingsProviderActions.kt
index f8f1605e..311dbd3b 100644
--- a/app/src/main/java/com/streamvault/app/ui/screens/settings/SettingsProviderActions.kt
+++ b/app/src/main/java/com/streamvault/app/ui/screens/settings/SettingsProviderActions.kt
@@ -433,11 +433,11 @@ internal class SettingsProviderActions(
uiState.update { it.copy(isDeletingProvider = true) }
when (val result = providerRepository.deleteProvider(providerId)) {
is Result.Success -> {
- watchNextManager.refreshWatchNext()
- launcherRecommendationsManager.refreshRecommendations(force = true)
- tvInputChannelSyncManager.refreshTvInputCatalog()
uiState.update { it.copy(isDeletingProvider = false, userMessage = "Provider deleted") }
onSuccess()
+ runCatching { watchNextManager.refreshWatchNext() }
+ runCatching { launcherRecommendationsManager.refreshRecommendations(force = true) }
+ runCatching { tvInputChannelSyncManager.refreshTvInputCatalog() }
}
is Result.Error -> uiState.update { it.copy(isDeletingProvider = false, userMessage = "Could not delete provider: ${result.message}") }
Result.Loading -> Unit
diff --git a/app/src/test/java/com/streamvault/app/ui/screens/settings/SettingsProviderActionsTest.kt b/app/src/test/java/com/streamvault/app/ui/screens/settings/SettingsProviderActionsTest.kt
index 33b78730..eaa2cd5f 100644
--- a/app/src/test/java/com/streamvault/app/ui/screens/settings/SettingsProviderActionsTest.kt
+++ b/app/src/test/java/com/streamvault/app/ui/screens/settings/SettingsProviderActionsTest.kt
@@ -21,6 +21,7 @@ import kotlinx.coroutines.test.advanceUntilIdle
import kotlinx.coroutines.test.runTest
import org.junit.Test
import org.mockito.kotlin.any
+import org.mockito.kotlin.doThrow
import org.mockito.kotlin.eq
import org.mockito.kotlin.mock
import org.mockito.kotlin.never
@@ -90,4 +91,23 @@ class SettingsProviderActionsTest {
verify(tvInputChannelSyncManager).refreshTvInputCatalog()
assertThat(uiState.value.userMessage).isEqualTo("Provider deleted")
}
-}
\ No newline at end of file
+
+ @Test
+ fun deleteProvider_stillCompletesSuccessWhenFollowUpRefreshFails() = runTest(StandardTestDispatcher()) {
+ whenever(providerRepository.deleteProvider(7L)).thenReturn(Result.success(Unit))
+ doThrow(IllegalStateException("refresh boom")).whenever(launcherRecommendationsManager)
+ .refreshRecommendations(force = true)
+ var onSuccessCalled = false
+
+ actions.deleteProvider(this, 7L, onSuccess = { onSuccessCalled = true })
+ advanceUntilIdle()
+
+ verify(providerRepository).deleteProvider(7L)
+ verify(watchNextManager).refreshWatchNext()
+ verify(launcherRecommendationsManager).refreshRecommendations(force = true)
+ verify(tvInputChannelSyncManager).refreshTvInputCatalog()
+ assertThat(onSuccessCalled).isTrue()
+ assertThat(uiState.value.isDeletingProvider).isFalse()
+ assertThat(uiState.value.userMessage).isEqualTo("Provider deleted")
+ }
+}
diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md
index 9b5faed6..2e8d75a8 100644
--- a/docs/CHANGELOG.md
+++ b/docs/CHANGELOG.md
@@ -18,6 +18,7 @@ All notable product changes are recorded in this document.
### Fixed
+- Fixed provider delete confirmation staying open when a follow-up TV integration refresh failed after the provider had already been deleted.
- Fixed the bundled FFmpeg Media3 artifact so MPEG Layer II audio (`audio/mpeg-L2`) maps to the bundled `mp2` decoder and release builds pass FFmpeg verification again.
- Fixed a broken player content-resolution merge that could leave the app failing to compile.
- Fixed player stream-info failures to preserve and surface the underlying error message instead of dropping it.