Skip to content

StreamVault is a TV-first free IPTV player for Android TV built with Kotlin, Jetpack Compose, Room, Hilt, and Media3.

Fix Xtream max-connections fallbacks

David Nashashbc1096d0eabd
diff --git a/data/src/main/java/com/streamvault/data/remote/xtream/XtreamProvider.kt b/data/src/main/java/com/streamvault/data/remote/xtream/XtreamProvider.kt
index 052057db..c88a2bf4 100644
--- a/data/src/main/java/com/streamvault/data/remote/xtream/XtreamProvider.kt
+++ b/data/src/main/java/com/streamvault/data/remote/xtream/XtreamProvider.kt
@@ -111,7 +111,7 @@ class XtreamProvider(
serverUrl = serverUrl,
username = username,
password = password,
- maxConnections = response.userInfo.maxConnections.toIntOrNull() ?: 1,
+ maxConnections = parseXtreamMaxConnections(response.userInfo.maxConnections),
expirationDate = expDate,
apiVersion = response.serverInfo.apiVersion?.takeIf { it.isNotBlank() }
?: response.serverInfo.version?.takeIf { it.isNotBlank() },
@@ -1180,6 +1180,14 @@ class XtreamProvider(
?: 0f
}
+ private fun parseXtreamMaxConnections(rawValue: String?): Int {
+ return rawValue
+ ?.trim()
+ ?.toIntOrNull()
+ ?.takeIf { it > 0 }
+ ?: 1
+ }
+
private fun decodeXtreamText(
value: String,
mode: XtreamTextDecodeMode = XtreamTextDecodeMode.RAW
diff --git a/data/src/test/java/com/streamvault/data/remote/xtream/XtreamProviderTest.kt b/data/src/test/java/com/streamvault/data/remote/xtream/XtreamProviderTest.kt
index 97a66291..e7c148c0 100644
--- a/data/src/test/java/com/streamvault/data/remote/xtream/XtreamProviderTest.kt
+++ b/data/src/test/java/com/streamvault/data/remote/xtream/XtreamProviderTest.kt
@@ -65,6 +65,31 @@ class XtreamProviderTest {
assertThat(authenticated?.allowedOutputFormats).containsExactly("ts", "m3u8").inOrder()
}
+ @Test
+ fun `authenticate falls back to one connection for zero and placeholder max connections`() = runBlocking {
+ listOf("0", "", "NA", "N/A", " ").forEach { rawMaxConnections ->
+ val provider = XtreamProvider(
+ providerId = 42,
+ api = FakeXtreamApiService(
+ authResponse = XtreamAuthResponse(
+ userInfo = XtreamUserInfo(
+ auth = 1,
+ maxConnections = rawMaxConnections
+ ),
+ serverInfo = XtreamServerInfo()
+ )
+ ),
+ serverUrl = "https://example.com",
+ username = "user",
+ password = "pass"
+ )
+
+ val authenticated = provider.authenticate().getOrNull()
+
+ assertThat(authenticated?.maxConnections).isEqualTo(1)
+ }
+ }
+
@Test
fun `getLiveStreams preserves live container extension in internal url`() = runBlocking {
val provider = XtreamProvider(
diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md
index 80dd1cab..c0a1924a 100644
--- a/docs/CHANGELOG.md
+++ b/docs/CHANGELOG.md
@@ -17,6 +17,7 @@ All notable product changes are recorded in this document.
### Fixed
+- Fixed Xtream provider connection-limit parsing so placeholder values like `0`, empty, and `N/A` fall back safely instead of producing invalid limits.
- Fixed player stream-info failures to preserve and surface the underlying error message instead of dropping it.
- Fixed decoder error recovery to retry against alternate stream formats when available.
- Fixed XMLTV parsing for ISO timestamps that include timezone offsets.