Skip to content

StreamVault is a TV-first free IPTV player for Android TV built with Kotlin, Jetpack Compose, Room, Hilt, and Media3.

test: broaden settings data boundary fixture

David Nashashd4046ed9652c
diff --git a/.superpowers/sdd/2026-09-05-settings-data-boundary/task-1-report.md b/.superpowers/sdd/2026-09-05-settings-data-boundary/task-1-report.md
index 3fcf876f..bd97aca5 100644
--- a/.superpowers/sdd/2026-09-05-settings-data-boundary/task-1-report.md
+++ b/.superpowers/sdd/2026-09-05-settings-data-boundary/task-1-report.md
@@ -40,3 +40,28 @@ Ran `graphify update .` successfully after modifying code files. Graphify rebuil
## Commit scope
The commit contains only the Task 1 boundary build/test/fixture changes and this report. The captured test log remains uncommitted.
+
+## Round 1/5 fix
+
+Finding addressed: the fixture guard previously proved only detection of the import phrase `import com.streamvault.data`; it did not prove detection of fully-qualified `com.streamvault.data...` usages.
+
+Fix details:
+
+- Test file: `feature/settings/src/test/java/com/streamvault/feature/settings/SettingsModuleBoundaryTest.kt` now asserts that the build logic contains the broader `com.streamvault.data` token.
+- Fixture file: `feature/settings/src/test/resources/boundary-fixtures/FullyQualifiedDataReference.kt` adds a fully-qualified `com.streamvault.data.sync.SyncProgressBus` reference.
+- Build logic: `feature/settings/build.gradle.kts` adds the broader `com.streamvault.data` token to fixture-only scanning and requires both the import and fully-qualified fixture violations. The production token list and production source scan remain unchanged for Task 4.
+
+Exact command:
+
+```text
+gradlew.bat :feature:settings:verifyFeatureSettingsBoundary --no-daemon
+```
+
+Result: expected RED, exit code 1. The task failed specifically on the existing project dependency:
+
+```text
+:feature:settings project dependencies must be exactly [:core:navigation, :core:ui, :domain, :player]; found
+[:core:navigation, :core:ui, :data, :domain, :player]
+```
+
+The task did not fail because of the fixture scan, confirming the broader-token fixture logic is accepted while the current `:data` dependency remains the RED cause. The prior untracked `task-1-boundary-test.log` was removed after this evidence was recorded; the rerun output was not persisted to a new log.
diff --git a/feature/settings/build.gradle.kts b/feature/settings/build.gradle.kts
index 2e9a4425..bc7e3fe2 100644
--- a/feature/settings/build.gradle.kts
+++ b/feature/settings/build.gradle.kts
@@ -61,7 +61,8 @@ val forbiddenFeatureSettingsSourceTokens = listOf(
)
val forbiddenFeatureSettingsFixtureTokens = forbiddenFeatureSettingsSourceTokens +
- "import com.streamvault.data"
+ "import com.streamvault.data" +
+ "com.streamvault.data"
fun findForbiddenFeatureSettingsSourceReferences(
sourceRoot: java.io.File,
@@ -127,6 +128,8 @@ val verifyFeatureSettingsBoundary = tasks.register("verifyFeatureSettingsBoundar
"ProviderFeatureImport.kt:3: import com.streamvault.feature.provider",
"PlaybackFeatureImport.java:3: import com.streamvault.feature.playback",
"DataImport.kt:3: import com.streamvault.data",
+ "DataImport.kt:3: com.streamvault.data",
+ "FullyQualifiedDataReference.kt:3: com.streamvault.data",
)
check(fixtureViolations.containsAll(requiredFixtureViolations)) {
":feature:settings boundary fixtures are not detected: " +
diff --git a/feature/settings/src/test/java/com/streamvault/feature/settings/SettingsModuleBoundaryTest.kt b/feature/settings/src/test/java/com/streamvault/feature/settings/SettingsModuleBoundaryTest.kt
index 354141a3..a58f1e27 100644
--- a/feature/settings/src/test/java/com/streamvault/feature/settings/SettingsModuleBoundaryTest.kt
+++ b/feature/settings/src/test/java/com/streamvault/feature/settings/SettingsModuleBoundaryTest.kt
@@ -14,5 +14,6 @@ class SettingsModuleBoundaryTest {
assertThat(text).contains(":core:navigation")
assertThat(text).doesNotContain("project(\":app\")")
assertThat(text).doesNotContain("project(\":data\")")
+ assertThat(text).contains("com.streamvault.data")
}
}
diff --git a/feature/settings/src/test/resources/boundary-fixtures/FullyQualifiedDataReference.kt b/feature/settings/src/test/resources/boundary-fixtures/FullyQualifiedDataReference.kt
new file mode 100644
index 00000000..a90dfc0a
--- /dev/null
+++ b/feature/settings/src/test/resources/boundary-fixtures/FullyQualifiedDataReference.kt
@@ -0,0 +1,3 @@
+package boundary.fixtures
+
+private val forbidden: com.streamvault.data.sync.SyncProgressBus? = null