Skip to content

StreamVault is a TV-first free IPTV player for Android TV built with Kotlin, Jetpack Compose, Room, Hilt, and Media3.

test: finalize phase 3 verification

David Nashashe5d996799344
diff --git a/app/src/androidTest/java/com/streamvault/app/ui/PremiumRouteGoldenTest.kt b/app/src/androidTest/java/com/streamvault/app/ui/PremiumRouteGoldenTest.kt
index c5248591..8d62081c 100644
--- a/app/src/androidTest/java/com/streamvault/app/ui/PremiumRouteGoldenTest.kt
+++ b/app/src/androidTest/java/com/streamvault/app/ui/PremiumRouteGoldenTest.kt
@@ -77,6 +77,7 @@ class PremiumRouteGoldenTest {
SeriesPosterCard(series = TestFixtures.series, modifier = Modifier.width(160.dp).height(240.dp))
LiveChannelRowSurface(
channel = TestFixtures.liveChannel,
+ nowMs = TestFixtures.currentProgram.startTime,
onClick = {},
modifier = Modifier.weight(1f)
)
@@ -138,7 +139,11 @@ class PremiumRouteGoldenTest {
subtitle = "Find channels, categories, or program titles without leaving the live surface.",
onClick = {}
)
- LiveChannelRowSurface(channel = TestFixtures.liveChannel, onClick = {})
+ LiveChannelRowSurface(
+ channel = TestFixtures.liveChannel,
+ nowMs = TestFixtures.currentProgram.startTime,
+ onClick = {}
+ )
LiveChannelRowSurface(
channel = TestFixtures.liveChannel.copy(
id = 8L,
@@ -147,6 +152,7 @@ class PremiumRouteGoldenTest {
catchUpSupported = false,
currentProgram = TestFixtures.currentProgram.copy(title = "Global Briefing")
),
+ nowMs = TestFixtures.currentProgram.startTime,
onClick = {}
)
}
diff --git a/app/src/androidTest/java/com/streamvault/app/ui/components/shell/ShellGoldenTest.kt b/app/src/androidTest/java/com/streamvault/app/ui/components/shell/ShellGoldenTest.kt
index 8ba4222b..72cac78d 100644
--- a/app/src/androidTest/java/com/streamvault/app/ui/components/shell/ShellGoldenTest.kt
+++ b/app/src/androidTest/java/com/streamvault/app/ui/components/shell/ShellGoldenTest.kt
@@ -67,6 +67,7 @@ class ShellGoldenTest {
isFavorite = true,
catchUpSupported = true
),
+ nowMs = 0L,
onClick = {},
onLongClick = {}
)
diff --git a/core/ui/src/main/java/com/streamvault/core/ui/device/TelevisionDevice.kt b/core/ui/src/main/java/com/streamvault/core/ui/device/TelevisionDevice.kt
index 7e5486f3..989afe22 100644
--- a/core/ui/src/main/java/com/streamvault/core/ui/device/TelevisionDevice.kt
+++ b/core/ui/src/main/java/com/streamvault/core/ui/device/TelevisionDevice.kt
@@ -23,13 +23,26 @@ internal fun classifyTelevisionDevice(
fun Context.isTelevisionDevice(): Boolean {
val packageManager = packageManager
+
+ if (packageManager.hasSystemFeature(PackageManager.FEATURE_LEANBACK) ||
+ packageManager.hasSystemFeature("android.software.leanback_only") ||
+ packageManager.hasSystemFeature(PackageManager.FEATURE_TELEVISION) ||
+ packageManager.hasSystemFeature("amazon.hardware.fire_tv")
+ ) {
+ return true
+ }
+
val uiModeManager = getSystemService(Context.UI_MODE_SERVICE) as? UiModeManager
+ if (uiModeManager?.currentModeType == Configuration.UI_MODE_TYPE_TELEVISION) {
+ return true
+ }
+
return classifyTelevisionDevice(
- hasLeanback = packageManager.hasSystemFeature(PackageManager.FEATURE_LEANBACK),
- hasLeanbackOnly = packageManager.hasSystemFeature("android.software.leanback_only"),
- hasTelevision = packageManager.hasSystemFeature(PackageManager.FEATURE_TELEVISION),
- hasFireTv = packageManager.hasSystemFeature("amazon.hardware.fire_tv"),
- uiModeType = uiModeManager?.currentModeType,
+ hasLeanback = false,
+ hasLeanbackOnly = false,
+ hasTelevision = false,
+ hasFireTv = false,
+ uiModeType = null,
screenWidthDp = resources.configuration.screenWidthDp,
hasTouchscreen = packageManager.hasSystemFeature(PackageManager.FEATURE_TOUCHSCREEN)
)
diff --git a/docs/COMPOSE_REDUCTION_PHASE3_REPORT.md b/docs/COMPOSE_REDUCTION_PHASE3_REPORT.md
new file mode 100644
index 00000000..fdf2063e
--- /dev/null
+++ b/docs/COMPOSE_REDUCTION_PHASE3_REPORT.md
@@ -0,0 +1,112 @@
+# Compose Reduction Phase 3 Report
+
+Date: 2026-08-23
+
+## Status
+
+Phase 3 is complete. The reusable presentation foundation now lives in
+`:core:ui`; app navigation, resources, repositories, and Activity behavior
+remain in `:app` behind an adapter. The dependency guard, JVM tests, connected
+TV instrumentation, shell goldens, premium-route goldens, and debug APK build
+all pass.
+
+## New boundary
+
+- Added `:core:ui` and included it from the root Gradle settings.
+- `:app` depends on `:core:ui`; `:core:ui` has no project dependencies.
+- Added `verifyCoreUiBoundary` at the module and root levels. It rejects
+ project dependencies and references to app/data/domain/player/navigation/Hilt
+ APIs from core source.
+- Core source contains no app resources, navigation controllers, domain models,
+ repositories, Activity references, or player references.
+
+The guard command and result were:
+
+```text
+.\gradlew.bat verifyCoreUiBoundary
+Verified :core:ui boundary: no project dependencies and no banned source references.
+```
+
+## Moved or extracted source
+
+- Design tokens, typography, focus helpers, theme, and Inter font resources move
+ to `com.streamvault.core.ui.design` and `com.streamvault.core.ui.theme`.
+- TV interaction primitives and mouse/remote activation handling move to
+ `com.streamvault.core.ui.interaction`.
+- The television-device predicate moves to
+ `com.streamvault.core.ui.device`, with the original feature/UI-mode
+ short-circuit behavior preserved.
+- Generic shell visuals move to
+ `com.streamvault.core.ui.components.shell`, including the core scaffold,
+ navigation chrome, headers, status/message states, load-more card, metadata
+ strip, and close action.
+- App-owned media cards and browse-specific panels remain in `:app`.
+- `AppShellNavigation` remains in `:app` and maps app routes, localized labels,
+ resources, repository-backed configuration, and Activity callbacks into the
+ core shell API. The existing VOD catalog merge rule is covered by unit tests.
+
+## Verification
+
+| Check | Result |
+| --- | --- |
+| `verifyCoreUiBoundary` | Pass |
+| `:core:ui:compileDebugKotlin` | Pass |
+| `:core:ui:testDebugUnitTest` | Pass |
+| `:app:compileDebugKotlin` | Pass |
+| `:app:testDebugUnitTest` | Pass; 363 tests |
+| `:app:assembleDebug` | Pass |
+| `:core:ui:compileDebugAndroidTestKotlin` | Pass |
+| `:core:ui:connectedDebugAndroidTest` | Pass; 1/1 on `Television_1080p(AVD) - 16` |
+| `ShellGoldenTest` | Pass; 3/3 on `Television_1080p(AVD) - 16` |
+| `PremiumRouteGoldenTest` | Pass; 6/6 on `Television_1080p(AVD) - 16` |
+| `git diff --check` | Pass |
+
+The app connected tests installed the current checkout's debug APK for
+`com.streamvault.app` over the same-package app instance on the emulator. No
+release or differently sourced APK was used for these results.
+
+## Task impact and graph refresh
+
+The build graph now makes the intended boundary explicit: changes in core UI
+compile `:core:ui` and its app consumer, while app-only UI remains downstream
+of core. The verification run completed `:core:ui` compilation/tests, app
+compilation, and `assembleDebug`. No before/after build-time benchmark was
+claimed.
+
+`graphify update .` completed successfully:
+
+```text
+Rebuilt: 13613 nodes, 26500 edges, 362 communities
+graph.json and GRAPH_REPORT.md updated in graphify-out
+```
+
+`graph.html` was skipped by graphify because the graph exceeds its 5,000-node
+visualization limit.
+
+## Warnings and resolved issue
+
+The extracted device predicate initially read `resources.configuration`
+eagerly, which broke two mocked `WatchNextManagerTest` cases. The original app
+implementation returned early for known TV feature flags; that short-circuit
+was restored in core. The complete app unit suite then passed.
+
+Gradle reports configuration-cache warnings for the custom boundary task
+because it intentionally inspects `project` during task execution. The task
+still passes and is marked incompatible with configuration cache by design.
+
+## Scope confirmation
+
+This phase changed UI module ownership, package imports, and the app-to-core
+shell contract. It did not change player composition, playback lifecycle,
+stream recovery, or Live TV playback behavior; the long-duration Live TV
+validation protocol was therefore not newly required for this structural UI
+move.
+
+Implementation commits:
+
+- `ef421345` — add core UI module boundary
+- `9ce82152` — extract television device predicate
+- `66dfac60` — move design system into core UI
+- `c6853787` — move TV interaction primitives into core UI
+- `517b272f` — extract core shell visuals and app navigation adapter
+- `d2a9a69b` — preserve shell focus stacking