Skip to content

StreamVault is a TV-first free IPTV player for Android TV built with Kotlin, Jetpack Compose, Room, Hilt, and Media3.

build: avoid baseline profile generation cycle

David Nashashf030d413965a
diff --git a/app/build.gradle.kts b/app/build.gradle.kts
index 64f240dd..4ad0a11e 100644
--- a/app/build.gradle.kts
+++ b/app/build.gradle.kts
@@ -320,21 +320,26 @@ abstract class MergeStartupRulesIntoBaselineProfileTask : DefaultTask() {
// Release-like art/startup merge tasks consume the normalized files written by the custom
// installer above. Keep the dependency explicit so Gradle's task validation remains sound
// when profile verification and a beta/release assembly are requested together. During
- // `generateBaselineProfile`, however, the profile producer must package the non-minified
- // release before the producer's copy task can install the newly collected files; adding
- // this dependency to that task graph would create a cycle.
+ // `generateBaselineProfile`, the producer must package the non-minified release before the
+ // producer's copy task can install the newly collected files; only those non-minified merge
+ // tasks omit the dependency to avoid a cycle. Beta/release merges remain explicit even when
+ // generation and assembly are requested together.
val profileGenerationRequested = gradle.startParameter.taskNames.any { taskName ->
taskName.substringAfterLast(':') == "generateBaselineProfile"
}
+ setOf(
+ "mergeBetaArtProfile",
+ "mergeReleaseArtProfile",
+ "mergeBetaStartupProfile",
+ "mergeReleaseStartupProfile",
+ )
+ .forEach { mergeTaskName ->
+ tasks.matching { it.name == mergeTaskName }.configureEach {
+ dependsOn(installMergedBaselineProfile)
+ }
+ }
if (!profileGenerationRequested) {
- setOf(
- "mergeBetaArtProfile",
- "mergeReleaseArtProfile",
- "mergeNonMinifiedReleaseArtProfile",
- "mergeBetaStartupProfile",
- "mergeReleaseStartupProfile",
- "mergeNonMinifiedReleaseStartupProfile",
- )
+ setOf("mergeNonMinifiedReleaseArtProfile", "mergeNonMinifiedReleaseStartupProfile")
.forEach { mergeTaskName ->
tasks.matching { it.name == mergeTaskName }.configureEach {
dependsOn(installMergedBaselineProfile)
diff --git a/validation/phase5_settings/profile-validation.md b/validation/phase5_settings/profile-validation.md
index e49ab363..1b22e9e3 100644
--- a/validation/phase5_settings/profile-validation.md
+++ b/validation/phase5_settings/profile-validation.md
@@ -49,3 +49,16 @@ The generated profile changes are paired with the app build-script guard that
keeps release/beta assembly validation explicit while avoiding a cycle during
profile collection. Physical-device and performance comparisons remain
separate Phase 5 gates.
+
+The exact roadmap invocation (generation, source verification, and both
+assemblies in one request) was also dry-run after that guard change. Its task
+graph resolved successfully without a cycle; the real collection and the
+release-like assemblies were executed as separate commands above to avoid
+repeating the 12-minute connected collection solely for graph validation.
+
+```text
+gradlew.bat :app:generateBaselineProfile verifyBaselineProfileSources \
+ :app:assembleBeta :app:assembleRelease --dry-run \
+ --no-daemon --console=plain --warning-mode=none
+BUILD SUCCESSFUL in 34s
+```