Skip to content

StreamVault is a TV-first free IPTV player for Android TV built with Kotlin, Jetpack Compose, Room, Hilt, and Media3.

Reset movie retry budget after recovery

Ensar Basri Kahveciff94bed23bdb
diff --git a/player/src/main/java/com/streamvault/player/Media3PlayerEngine.kt b/player/src/main/java/com/streamvault/player/Media3PlayerEngine.kt
index 1ab01697..ebc8e7ff 100644
--- a/player/src/main/java/com/streamvault/player/Media3PlayerEngine.kt
+++ b/player/src/main/java/com/streamvault/player/Media3PlayerEngine.kt
@@ -57,6 +57,7 @@ import com.streamvault.player.playback.PlayerRetryPolicy
import com.streamvault.player.playback.PlayerTimeoutProfile
import com.streamvault.player.playback.PreloadCoordinator
import com.streamvault.player.playback.ResolvedStreamType
+import com.streamvault.player.playback.resolveRetryAttemptAfterReady
import com.streamvault.player.playback.resolveRetrySeekPositionMs
import com.streamvault.player.playback.StreamTypeResolver
import com.streamvault.player.playback.VideoStallDetector
@@ -1204,6 +1205,11 @@ class Media3PlayerEngine @Inject constructor(
}
if (_playbackState.value == PlaybackState.READY) {
_retryStatus.value = null
+ retryAttempt = resolveRetryAttemptAfterReady(
+ currentAttempt = retryAttempt,
+ playbackStarted = playbackStarted,
+ isCurrentMediaItemLive = exoPlayer?.isCurrentMediaItemLive == true
+ )
if (isPlayingTimeshiftSnapshot && pendingTimeshiftSeekToEnd) {
pendingTimeshiftSeekToEnd = false
playerOrNull()?.duration?.takeIf { it > 0L && it != C.TIME_UNSET }?.let { duration ->
diff --git a/player/src/main/java/com/streamvault/player/playback/PlayerRetrySeekPositionPolicy.kt b/player/src/main/java/com/streamvault/player/playback/PlayerRetrySeekPositionPolicy.kt
index ee4efacd..c41fa815 100644
--- a/player/src/main/java/com/streamvault/player/playback/PlayerRetrySeekPositionPolicy.kt
+++ b/player/src/main/java/com/streamvault/player/playback/PlayerRetrySeekPositionPolicy.kt
@@ -23,6 +23,17 @@ internal fun resolveRetrySeekPositionMs(
}
}
+internal fun resolveRetryAttemptAfterReady(
+ currentAttempt: Int,
+ playbackStarted: Boolean,
+ isCurrentMediaItemLive: Boolean
+): Int {
+ if (currentAttempt <= 0) return currentAttempt
+ if (!playbackStarted) return currentAttempt
+ if (isCurrentMediaItemLive) return currentAttempt
+ return 0
+}
+
private fun Long?.isFiniteMediaDuration(): Boolean {
return this != null && this != C.TIME_UNSET && this > 0L
}
diff --git a/player/src/test/java/com/streamvault/player/playback/PlayerRetrySeekPositionPolicyTest.kt b/player/src/test/java/com/streamvault/player/playback/PlayerRetrySeekPositionPolicyTest.kt
index 7daeea6e..bcbe9f48 100644
--- a/player/src/test/java/com/streamvault/player/playback/PlayerRetrySeekPositionPolicyTest.kt
+++ b/player/src/test/java/com/streamvault/player/playback/PlayerRetrySeekPositionPolicyTest.kt
@@ -57,4 +57,26 @@ class PlayerRetrySeekPositionPolicyTest {
assertThat(seekPosition).isNull()
}
+
+ @Test
+ fun `ready movie playback after retry restores transient retry budget`() {
+ val nextAttempt = resolveRetryAttemptAfterReady(
+ currentAttempt = 1,
+ playbackStarted = true,
+ isCurrentMediaItemLive = false
+ )
+
+ assertThat(nextAttempt).isEqualTo(0)
+ }
+
+ @Test
+ fun `ready live playback keeps retry budget scoped to live recovery`() {
+ val nextAttempt = resolveRetryAttemptAfterReady(
+ currentAttempt = 1,
+ playbackStarted = true,
+ isCurrentMediaItemLive = true
+ )
+
+ assertThat(nextAttempt).isEqualTo(1)
+ }
}