Open-source AI penetration testing tool to find and fix your app’s vulnerabilities.
Python agentsai-hackingai-penetration-testingai-pentestingai-securityartificial-intelligencebug-bountycode-qualityctf-toolscybersecuritycybersecurity-toolsethical-hackinghackingllm-securityoffensive-securitypenetration-testingpentesting-toolsred-teamingsecuritysecurity-automation
fix(runtime,interface): mount sources at advertised paths + surface scan failures in TUI
0xallam53188a75837a
diff --git a/strix/interface/cli.py b/strix/interface/cli.pyindex 5369e5fe..48462417 100644--- a/strix/interface/cli.py+++ b/strix/interface/cli.py@@ -1,12 +1,10 @@import atexitimport contextlibimport logging-import osimport signalimport sysimport threadingimport time-from pathlib import Pathfrom typing import Anyfrom rich.console import Console@@ -37,26 +35,6 @@ def _resolve_sandbox_image() -> str:return image-def _resolve_sources_path(args: Any) -> Path:- """Pick the host directory to mount into ``/workspace/sources``.-- - With ``--local-sources``, mount the parent of the first source so- the agent can walk down into the actual tree.- - Otherwise, a per-run scratch dir under ``$XDG_CACHE_HOME/strix``.- """- local_sources: list[dict[str, str]] | None = getattr(args, "local_sources", None)- if local_sources:- first = local_sources[0]- host_path = first.get("host_path") or first.get("source_path") or first.get("path")- if host_path:- return Path(host_path).expanduser().resolve().parent-- cache_root = os.environ.get("XDG_CACHE_HOME") or str(Path.home() / ".cache")- sources = Path(cache_root) / "strix" / "sources" / str(args.run_name)- sources.mkdir(parents=True, exist_ok=True)- return sources--async def run_cli(args: Any) -> None: # noqa: PLR0915console = Console()@@ -200,7 +178,7 @@ async def run_cli(args: Any) -> None: # noqa: PLR0915scan_config=scan_config,scan_id=args.run_name,image=_resolve_sandbox_image(),- sources_path=_resolve_sources_path(args),+ local_sources=getattr(args, "local_sources", None) or [],tracer=tracer,interactive=bool(getattr(args, "interactive", False)),)diff --git a/strix/interface/tui.py b/strix/interface/tui.pyindex 2c4a3c24..bf1e1b1c 100644--- a/strix/interface/tui.py+++ b/strix/interface/tui.py@@ -3,14 +3,12 @@ import asyncioimport atexitimport contextlibimport logging-import osimport signalimport sysimport threadingfrom collections.abc import Callablefrom importlib.metadata import PackageNotFoundErrorfrom importlib.metadata import version as pkg_version-from pathlib import Pathfrom typing import TYPE_CHECKING, Any, ClassVar@@ -726,6 +724,10 @@ class StrixTUIApp(App): # type: ignore[misc]self._scan_loop: asyncio.AbstractEventLoop | None = Noneself._scan_stop_event = threading.Event()self._scan_completed = threading.Event()+ # Captured by ``scan_target`` when the scan thread crashes; read+ # by ``run_tui`` after ``run_async()`` returns so the user sees+ # the traceback on stderr instead of just a silent UI hang.+ self._scan_error: BaseException | None = Noneself._spinner_frame_index: int = 0 # Current animation frame indexself._sweep_num_squares: int = 6 # Number of squares in sweep animation@@ -743,18 +745,6 @@ class StrixTUIApp(App): # type: ignore[misc]self._setup_cleanup_handlers()- def _resolve_sources_path(self) -> Path:- local_sources = getattr(self.args, "local_sources", None) or []- if local_sources:- first = local_sources[0]- host_path = first.get("host_path") or first.get("source_path") or first.get("path")- if host_path:- return Path(host_path).expanduser().resolve().parent- cache_root = os.environ.get("XDG_CACHE_HOME") or str(Path.home() / ".cache")- sources = Path(cache_root) / "strix" / "sources" / str(self.args.run_name)- sources.mkdir(parents=True, exist_ok=True)- return sources-def _build_scan_config(self, args: argparse.Namespace) -> dict[str, Any]:return {"scan_id": args.run_name,@@ -1102,7 +1092,7 @@ class StrixTUIApp(App): # type: ignore[misc]return self._merge_renderables(renderables)- def _get_status_display_content(+ def _get_status_display_content( # noqa: PLR0911self, agent_id: str, agent_data: dict[str, Any]) -> tuple[Text | None, Text, bool]:status = agent_data.get("status", "running")@@ -1141,6 +1131,16 @@ class StrixTUIApp(App): # type: ignore[misc]keymap.append("Send message to retry", style="dim")return (text, keymap, False)+ if status == "failed":+ error_msg = agent_data.get("error_message", "")+ text = Text()+ if error_msg:+ text.append(error_msg, style="red")+ else:+ text.append("Scan failed", style="red")+ self._stop_dot_animation()+ return (text, Text(), False)+if status == "waiting":keymap = Text()keymap.append("Send message to resume", style="dim")@@ -1409,13 +1409,12 @@ class StrixTUIApp(App): # type: ignore[misc]try:if not self._scan_stop_event.is_set():image = load_settings().runtime.image or "strix-sandbox:latest"- sources_path = self._resolve_sources_path()loop.run_until_complete(run_strix_scan(scan_config=self.scan_config,scan_id=self.scan_config["run_name"],image=str(image),- sources_path=sources_path,+ local_sources=getattr(self.args, "local_sources", None) or [],tracer=self.tracer,bus=self.bus,interactive=True,@@ -1424,12 +1423,15 @@ class StrixTUIApp(App): # type: ignore[misc]except (KeyboardInterrupt, asyncio.CancelledError):logger.info("Scan interrupted by user")- except (ConnectionError, TimeoutError):+ except (ConnectionError, TimeoutError) as e:logging.exception("Network error during scan")- except RuntimeError:+ self._scan_error = e+ except RuntimeError as e:logging.exception("Runtime error during scan")- except Exception:+ self._scan_error = e+ except Exception as e:logging.exception("Unexpected error during scan")+ self._scan_error = efinally:# Best-effort sandbox teardown if early setup failed# before run_strix_scan's own ``finally`` ran.@@ -1995,3 +1997,9 @@ async def run_tui(args: argparse.Namespace) -> None:"""Run strix in interactive TUI mode with textual."""app = StrixTUIApp(args)await app.run_async()+ # Propagate scan-thread failures: ``app.run_async`` returns normally+ # when the user quits (ctrl-q) regardless of whether the scan+ # crashed. Without this re-raise, ``main.py`` would treat a failed+ # scan as success and print the completion banner.+ if app._scan_error is not None:+ raise app._scan_errordiff --git a/strix/orchestration/scan.py b/strix/orchestration/scan.pyindex aceaf1ac..8006ea75 100644--- a/strix/orchestration/scan.py+++ b/strix/orchestration/scan.py@@ -27,6 +27,7 @@ import contextlibimport jsonimport loggingimport uuid+from datetime import UTC, datetimefrom pathlib import Pathfrom typing import TYPE_CHECKING, Any, Literal@@ -45,7 +46,7 @@ from strix.orchestration.filter import inject_messages_filterfrom strix.orchestration.hooks import StrixOrchestrationHooksfrom strix.orchestration.run_loop import run_with_continuationfrom strix.runtime import session_manager-from strix.telemetry.logging import set_scan_id, setup_scan_logging+from strix.telemetry.logging import set_agent_id, set_scan_id, setup_scan_logging#: Default ``max_turns`` budget passed to ``Runner.run``.@@ -173,7 +174,7 @@ async def run_strix_scan(scan_config: dict[str, Any],scan_id: str | None = None,image: str,- sources_path: Path,+ local_sources: list[dict[str, str]] | None = None,tracer: Any | None = None,bus: AgentMessageBus | None = None,interactive: bool = False,@@ -192,7 +193,11 @@ async def run_strix_scan(should pass a stable id.image: Docker image tag for the sandbox (e.g.``"strix-sandbox:0.2.0"``).- sources_path: Host directory mounted into ``/workspace/sources``.+ local_sources: Per-source mount specs from+ :func:`strix.interface.utils.collect_local_sources` —+ each entry's ``source_path`` (host) is bind-mounted at+ ``/workspace/<workspace_subdir>``. Pass ``None`` (or ``[]``)+ for non-whitebox runs.tracer: Optional Strix tracer. Stored in context for thetelemetry hook chain. Pass ``None`` for unit tests.interactive: Renders the interactive-mode prompt block on the@@ -300,7 +305,7 @@ async def run_strix_scan(bundle = await session_manager.create_or_reuse(scan_id,image=image,- sources_path=sources_path,+ local_sources=local_sources or [],)logger.info("Sandbox ready for scan %s", scan_id)@@ -450,12 +455,27 @@ async def run_strix_scan(interactive=interactive,session=root_session,)- except BaseException:+ except BaseException as exc:logger.exception("Strix scan %s failed", scan_id)# Cancel any descendant tasks the root spawned before unwinding.# cancel_descendants is idempotent and handles the empty-tree case.if root_id is not None:await bus.cancel_descendants(root_id)+ # The SDK's on_agent_end hook only fires after a successful+ # ``Runner.run_streamed`` reaches the agent's first turn. A+ # failure earlier (e.g., model-provider routing, sandbox+ # bring-up) leaves the root stuck at status="running" — the+ # TUI keeps animating "Initializing" forever. Finalize it+ # here so the bus + tracer reflect reality, and stash the+ # error message for the status-line display.+ error_message = f"{type(exc).__name__}: {exc}"+ if tracer is not None and root_id in getattr(tracer, "agents", {}):+ tracer.agents[root_id]["status"] = "failed"+ tracer.agents[root_id]["error_message"] = error_message+ tracer.agents[root_id]["updated_at"] = datetime.now(UTC).isoformat()+ with contextlib.suppress(Exception):+ await bus.finalize(root_id, "failed")+ set_agent_id(None)raisefinally:for s in sessions_to_close:diff --git a/strix/runtime/backends.py b/strix/runtime/backends.pyindex 9fcafef8..e4fa482b 100644--- a/strix/runtime/backends.py+++ b/strix/runtime/backends.py@@ -48,6 +48,13 @@ async def _docker_backend(NET_RAW caps + ``host.docker.internal`` host-gateway. Imports``docker`` lazily so deployments that target a non-Dockerbackend don't need the docker-py library installed.++ ``session.start()`` is what materializes the manifest entries+ (LocalDir copies, mount setup, etc.) into the running container —+ the SDK's ``client.create()`` only builds the inner session object+ without applying the manifest. ``async with session:`` would call it+ too, but Strix manages session lifetime explicitly via+ ``client.delete()`` so we trigger ``start()`` ourselves."""import dockerfrom agents.sandbox.sandboxes.docker import DockerSandboxClientOptions@@ -57,6 +64,7 @@ async def _docker_backend(client = StrixDockerSandboxClient(docker.from_env())options = DockerSandboxClientOptions(image=image, exposed_ports=exposed_ports)session = await client.create(options=options, manifest=manifest)+ await session.start()return client, sessiondiff --git a/strix/runtime/session_manager.py b/strix/runtime/session_manager.pyindex 3859884f..13944954 100644--- a/strix/runtime/session_manager.py+++ b/strix/runtime/session_manager.py@@ -16,9 +16,10 @@ next scan from starting.from __future__ import annotationsimport logging-from typing import TYPE_CHECKING, Any+from pathlib import Path+from typing import Any-from agents.sandbox.entries import LocalDir+from agents.sandbox.entries import BaseEntry, LocalDirfrom agents.sandbox.manifest import Environment, Manifestfrom strix.config import load_settings@@ -26,10 +27,6 @@ from strix.runtime.backends import get_backendfrom strix.runtime.caido_bootstrap import bootstrap_caido-if TYPE_CHECKING:- from pathlib import Path--logger = logging.getLogger(__name__)@@ -48,15 +45,17 @@ async def create_or_reuse(scan_id: str,*,image: str,- sources_path: Path,+ local_sources: list[dict[str, str]],) -> dict[str, Any]:"""Return the existing bundle for ``scan_id`` or create a new one.Args:scan_id: Caller-provided scan identifier (used as cache key).image: Docker image tag (e.g. ``"strix-sandbox:0.2.0"``).- sources_path: Host directory mounted into the container's- ``/workspace/sources`` so the agent can read user code.+ local_sources: Each entry's ``source_path`` (host) is mounted at+ ``/workspace/<workspace_subdir>`` inside the container — the+ same path the root-task prompt advertises. Empty list means+ no host code is mounted (web/IP-only scans).Returns the bundle dict containing ``client``, ``session``, and``caido_client``.@@ -66,6 +65,19 @@ async def create_or_reuse(logger.info("Reusing existing sandbox session for scan %s", scan_id)return cached+ # Build Manifest entries keyed by ``workspace_subdir`` — the SDK+ # mounts each at ``/workspace/<key>``, which is exactly the path+ # ``_build_root_task`` puts in the agent's task prompt. Mounting+ # only the listed source dirs (not their parent) avoids leaking+ # unrelated host content into the sandbox.+ entries: dict[str | Path, BaseEntry] = {}+ for src in local_sources:+ ws_subdir = src.get("workspace_subdir") or ""+ host_path = src.get("source_path") or ""+ if not ws_subdir or not host_path:+ continue+ entries[ws_subdir] = LocalDir(src=Path(host_path).expanduser().resolve())+# Caido runs as an in-container sidecar; HTTP(S) traffic from any# process started via ``session.exec`` (the SDK's Shell tool, etc.)# picks up these env vars automatically. ``NO_PROXY`` keeps the@@ -73,7 +85,7 @@ async def create_or_reuse(# through Caido.container_caido_url = f"http://127.0.0.1:{_CONTAINER_CAIDO_PORT}"manifest = Manifest(- entries={"sources": LocalDir(src=sources_path)},+ entries=entries,environment=Environment(value={"PYTHONUNBUFFERED": "1",