Open-source AI penetration testing tool to find and fix your app’s vulnerabilities.
Python agentsai-hackingai-penetration-testingai-pentestingai-securityartificial-intelligencebug-bountycode-qualityctf-toolscybersecuritycybersecurity-toolsethical-hackinghackingllm-securityoffensive-securitypenetration-testingpentesting-toolsred-teamingsecuritysecurity-automation
Scope viewer session cookie to the bound port (#922)
yoni-at-strixb313d78f6030
diff --git a/strix/interface/viewer/server.py b/strix/interface/viewer/server.pyindex 1b5d0e9d..37bfd7cf 100644--- a/strix/interface/viewer/server.py+++ b/strix/interface/viewer/server.py@@ -107,8 +107,11 @@ def resolve_run_dir(base_dir: Path, run_param: str | None, default_run_dir: Pathreturn candidate-# Name of the cookie carrying the per-process session capability.-SESSION_COOKIE = "strix_viewer_session"+# Prefix of the cookie carrying the per-process session capability. The bound+# port is appended (``strix_viewer_session_<port>``) because browsers scope+# cookies by host only, never by port: concurrent viewers on 127.0.0.1 would+# otherwise share one cookie slot and clobber each other's session.+SESSION_COOKIE_PREFIX = "strix_viewer_session"class _ViewerState:@@ -135,6 +138,9 @@ class _ViewerState:# enough to steer a live scan, trigger a report, or browse history --# the token is never handed to a caller who merely reaches ``/``.self.session_token = secrets.token_urlsafe(32)+ # Finalized in ``serve()`` once the port is known (the server binds+ # after this state is constructed); see SESSION_COOKIE_PREFIX.+ self.cookie_name = SESSION_COOKIE_PREFIXdef _make_handler(state: _ViewerState) -> type[BaseHTTPRequestHandler]:@@ -476,7 +482,7 @@ def _make_handler(state: _ViewerState) -> type[BaseHTTPRequestHandler]:the browser this process handed the page to can pass. A directcaller on an exposed port has no cookie and is rejected."""- supplied = self._cookies().get(SESSION_COOKIE, "")+ supplied = self._cookies().get(state.cookie_name, "")return bool(supplied) and secrets.compare_digest(supplied, state.session_token)def _token_presented(self, query: dict[str, list[str]]) -> bool:@@ -512,7 +518,7 @@ def _make_handler(state: _ViewerState) -> type[BaseHTTPRequestHandler]:# SameSite=Strict (never sent from a cross-site context).self.send_header("Set-Cookie",- f"{SESSION_COOKIE}={state.session_token}; Path=/; HttpOnly; SameSite=Strict",+ f"{state.cookie_name}={state.session_token}; Path=/; HttpOnly; SameSite=Strict",)self.end_headers()self.wfile.write(content)@@ -586,6 +592,7 @@ def serve(httpd.daemon_threads = Truebound_port = int(httpd.server_address[1])+ state.cookie_name = f"{SESSION_COOKIE_PREFIX}_{bound_port}"url = f"http://{host}:{bound_port}"thread = threading.Thread(target=httpd.serve_forever, name="strix-viewer", daemon=True)diff --git a/tests/test_viewer.py b/tests/test_viewer.pyindex 7f0c1886..eb13cc1f 100644--- a/tests/test_viewer.py+++ b/tests/test_viewer.py@@ -8,6 +8,7 @@ import sqlite3import urllib.errorimport urllib.requestfrom typing import TYPE_CHECKING+from urllib.parse import urlsplitfrom strix.core.paths import latest_run_dir, runs_base_dirfrom strix.interface.viewer.server import serve@@ -341,6 +342,11 @@ def _session_cookie(url: str, token: str) -> str:return raw.split(";", 1)[0]+def _cookie_name(url: str) -> str:+ """The per-server session cookie name, derived from the bound port."""+ return f"strix_viewer_session_{urlsplit(url).port}"++def _get_status(url: str, *, cookie: str | None = None) -> int:headers = {"Cookie": cookie} if cookie else {}req = urllib.request.Request(url, headers=headers) # noqa: S310 - localhost test server@@ -381,7 +387,7 @@ def test_capability_issued_only_for_tokened_bootstrap(# Only the correct bootstrap token mints the session cookie.with urllib.request.urlopen(f"{url}/?token={token}") as resp: # noqa: S310 # nosec B310cookie = str(resp.headers.get("Set-Cookie", ""))- assert "strix_viewer_session=" in cookie+ assert f"{_cookie_name(url)}=" in cookieassert "HttpOnly" in cookie and "SameSite=Strict" in cookie# Static assets never carry it.@@ -414,7 +420,7 @@ def test_unauthorized_client_cannot_acquire_capability(url,"/api/agents/steer",{"agent_id": "root", "message": "pwn"},- cookie="strix_viewer_session=",+ cookie=f"{_cookie_name(url)}=",)assert status == 403assert delivered == []@@ -611,6 +617,53 @@ def test_runs_list_requires_session_and_verification(httpd.server_close()+def test_concurrent_servers_use_distinct_cookies(+ tmp_path: Path, monkeypatch: pytest.MonkeyPatch+) -> None:+ """Cookies are host-scoped, not port-scoped: two viewers on 127.0.0.1 must+ not share a cookie slot, and one server's cookie must not pass the other's+ session gate."""+ run_a = _make_run(tmp_path / "a", "run-a", status="running", end_time=None)+ run_b = _make_run(tmp_path / "b", "run-b", status="running", end_time=None)+ _bundle(tmp_path, monkeypatch)+ monkeypatch.setattr(+ "strix.interface.viewer.auth.read_auth", lambda: {"email": "[email protected]", "token": "t"}+ )+ monkeypatch.setattr("strix.interface.viewer.auth.is_verified", lambda: True)++ httpd_a, url_a, token_a = serve(run_a, open_browser=False)+ httpd_b, url_b, token_b = serve(run_b, open_browser=False)+ try:+ cookie_a = _session_cookie(url_a, token_a)+ cookie_b = _session_cookie(url_b, token_b)++ # The two servers mint differently named cookies, so a browser stores both.+ assert cookie_a.split("=", 1)[0] == _cookie_name(url_a)+ assert cookie_b.split("=", 1)[0] == _cookie_name(url_b)+ assert cookie_a.split("=", 1)[0] != cookie_b.split("=", 1)[0]++ def _status(url: str, cookie: str) -> dict[str, object]:+ _, _, body = _get(f"{url}/api/auth/status", cookie=cookie)+ return dict(json.loads(body))++ # Each server honors its own cookie...+ assert _status(url_a, cookie_a)["verified"] is True+ assert _status(url_b, cookie_b)["verified"] is True+ # ...but treats the other server's cookie as session-less.+ assert _status(url_a, cookie_b)["verified"] is False+ assert _status(url_b, cookie_a)["verified"] is False+ # Even both cookies together (what a real browser would send) only+ # match the token minted by the receiving server.+ both = f"{cookie_a}; {cookie_b}"+ assert _status(url_a, both)["verified"] is True+ assert _status(url_b, both)["verified"] is True+ finally:+ httpd_a.shutdown()+ httpd_a.server_close()+ httpd_b.shutdown()+ httpd_b.server_close()++def test_server_rejects_path_traversal(tmp_path: Path, monkeypatch: pytest.MonkeyPatch) -> None:run_dir = _make_run(tmp_path, "guard", status="completed", end_time="2026-01-01T00:00:00Z")secret = tmp_path / "secret.txt"