Open-source AI penetration testing tool to find and fix your app’s vulnerabilities.
Python agentsai-hackingai-penetration-testingai-pentestingai-securityartificial-intelligencebug-bountycode-qualityctf-toolscybersecuritycybersecurity-toolsethical-hackinghackingllm-securityoffensive-securitypenetration-testingpentesting-toolsred-teamingsecuritysecurity-automation
fix(reporting): keep git blame guidance to the technical_analysis field
Ahmed Allamcafa4b19fde2
diff --git a/strix/tools/reporting/tool.py b/strix/tools/reporting/tool.pyindex c7caf4be..c95b4bee 100644--- a/strix/tools/reporting/tool.py+++ b/strix/tools/reporting/tool.py@@ -927,29 +927,6 @@ async def create_vulnerability_report() -> str:"""File a vulnerability report — one report per fully-verified finding.- **Local Git attribution (best effort)**: for a finding with a repository- file and valid line number, use ``exec_command`` in the existing full-clone- checkout. Identify the affected repository first; if ambiguous, skip- attribution. Blame the primary vulnerable line when known, otherwise the- ``start_line`` of the primary code location. Quote paths and use a short- timeout, for example::-- GIT_NO_LAZY_FETCH=1 timeout 3s git -C REPO -c safe.directory=REPO \\- blame --line-porcelain --no-textconv -L LINE,LINE -- FILE-- Add a **Last modified by** subsection to ``technical_analysis`` with the- file/line, author name (``author``), author email (``author-mail``), commit- SHA (first field), commit timestamp (``committer-time``, rendered in UTC),- and commit summary (``summary``), where available. Convert the Unix timestamp- using a tool (e.g. Python ``datetime`` with ``timezone.utc``), never mentally;- if conversion fails, keep the observed Unix timestamp. Use only observed- output; never invent attribution or imply the author introduced the flaw.- Skip all-zero SHAs (uncommitted lines), missing/invalid line numbers,- missing or renamed paths you cannot resolve, binary/generated files without- useful history, unavailable Git metadata, and command errors/timeouts.- Do not clone, fetch, or retry just for attribution; omit it and file the- finding normally when unavailable. It must never block scanning or reporting.-**When to file**: you have a concrete vulnerability with a workingproof-of-concept and you're 100% sure it's a real issue.@@ -1146,13 +1123,17 @@ async def create_vulnerability_report(but unverified follow-on risks separate; do not use them toset CVSS metrics.target: Affected URL / domain / repository.- technical_analysis: The mechanism and root cause. Before filing a finding- with code locations, use ``exec_command`` to attempt local ``git blame``- on the primary vulnerable line (otherwise ``start_line``) in the correct- existing checkout, using the short timeout described above. Include the- observed author name/email, full commit SHA, UTC commit timestamp, and- summary under **Last modified by** here. If history is unavailable or- the command fails, omit attribution and file normally; never invent it.+ technical_analysis: The mechanism and root cause. For source-backed+ findings, optionally end with a **Last modified by** line from a+ best-effort ``git blame`` of the primary vulnerable line (otherwise+ ``start_line``) in the existing checkout, run with ``exec_command``::++ timeout 3s git -C REPO -c safe.directory=REPO blame --porcelain -L LINE,LINE -- FILE++ Report the author name/email, commit SHA, UTC commit time (convert+ ``committer-time`` with a tool, not mentally), and summary. Use only+ observed output. Skip all-zero SHAs, unresolvable paths, or command+ errors and file normally without it.poc_description: Step-by-step reproduction (steps only, no code).poc_script_code: Working PoC (Python preferred).remediation_steps: Specific, actionable fix (prose, no code).@@ -1470,8 +1451,6 @@ async def update_vulnerability_report(``severity_change_conditions`` with a new ``cvss_breakdown``.- ``code_locations`` replaces the whole list. A location carrying``fix_after`` needs ``fix_verification``.- - When changing a target or code location, refresh or remove any "Last modified- by" attribution in ``technical_analysis``; do not retain stale Git details.The report keeps its id, its original author, and its filing time. Therevision is recorded in the report as update history, so state thediff --git a/tests/test_report_history.py b/tests/test_report_history.pyindex ca9a69bf..df3382b7 100644--- a/tests/test_report_history.py+++ b/tests/test_report_history.py@@ -184,28 +184,23 @@ async def _update(report_id: str, **fields: Any) -> dict[str, Any]:return result-def test_reporting_tools_expose_optional_git_attribution_guidance() -> None:+def test_git_attribution_guidance_lives_only_in_technical_analysis() -> None:description = create_vulnerability_report.description+ summary, _, args = description.partition("Args:")+ assert "blame" not in summary+ assert "Last modified by" not in summary+ field = args.split("technical_analysis:", 1)[1].split("poc_description:", 1)[0]for instruction in ("exec_command",- "existing full-clone",+ "git blame","primary vulnerable line","start_line","Last modified by",- "technical_analysis",- "author-mail","committer-time",- "using a tool (e.g. Python",- "timezone.utc",- "summary","all-zero SHAs",- "errors/timeouts",- "never block",):- assert instruction in description- assert "refresh or remove" in update_vulnerability_report.description- assert "Before filing a finding" in description- assert description.index("Local Git attribution") < description.index("When to file")+ assert instruction in field+ assert "blame" not in update_vulnerability_report.description@pytest.mark.parametrize(@@ -228,7 +223,7 @@ async def test_prompted_blame_command_to_report_artifacts(# Execute the exact example exposed to the model, with quoted real paths.match = re.search(- r"GIT_NO_LAZY_FETCH=1 timeout 3s git.*?-- FILE",+ r"timeout 3s git.*?-- FILE",create_vulnerability_report.description,re.DOTALL,)