Open-source AI penetration testing tool to find and fix your app’s vulnerabilities.
Python agentsai-hackingai-penetration-testingai-pentestingai-securityartificial-intelligencebug-bountycode-qualityctf-toolscybersecuritycybersecurity-toolsethical-hackinghackingllm-securityoffensive-securitypenetration-testingpentesting-toolsred-teamingsecuritysecurity-automation
Enforce lifecycle completion in non-interactive runs
0xallame8b172bd2a8d
diff --git a/strix/agents/factory.py b/strix/agents/factory.pyindex 7ae30574..9562b626 100644--- a/strix/agents/factory.py+++ b/strix/agents/factory.py@@ -236,6 +236,11 @@ def build_strix_agent(instructions=instructions,tools=tools,tool_use_behavior=_finish_tool_use_behavior,+ # Autonomous Strix runs must keep forcing tool calls after each+ # tool result; otherwise the SDK resets tool_choice to auto and a+ # plain-text model response can become final output before+ # finish_scan / agent_finish.+ reset_tool_choice=False,# model=None so ``RunConfig.model`` drives provider selection# via :func:`build_multi_provider` rather than the SDK's default.model=None,diff --git a/strix/orchestration/runner.py b/strix/orchestration/runner.pyindex 23d48466..4c9a1fc2 100644--- a/strix/orchestration/runner.py+++ b/strix/orchestration/runner.py@@ -14,7 +14,7 @@ import loggingimport uuidfrom collections.abc import Callablefrom pathlib import Path-from typing import TYPE_CHECKING, Any+from typing import TYPE_CHECKING, Any, castfrom agents import RunConfig, Runnerfrom agents.exceptions import AgentsException, MaxTurnsExceeded, UserError@@ -38,6 +38,7 @@ from strix.telemetry.logging import set_scan_id, setup_scan_loggingif TYPE_CHECKING:+ from agents.items import TResponseInputItemfrom agents.memory import Sessionfrom agents.result import RunResultBase@@ -74,11 +75,47 @@ async def _run_agent_loop(result: RunResultBase | None = Noneif not (start_parked and interactive):+ if interactive:+ result = await _run_cycle(+ agent,+ coordinator,+ agent_id,+ input_data=initial_input,+ run_config=run_config,+ context=context,+ max_turns=max_turns,+ session=session,+ interactive=interactive,+ event_sink=event_sink,+ )+ else:+ result = await _run_noninteractive_until_lifecycle(+ agent,+ coordinator,+ agent_id,+ initial_input=initial_input,+ run_config=run_config,+ context=context,+ max_turns=max_turns,+ session=session,+ event_sink=event_sink,+ )++ if not interactive:+ return result++ while True:+ try:+ await coordinator.wait_for_message(agent_id)+ except asyncio.CancelledError:+ return result++ await coordinator.consume_pending(agent_id)result = await _run_cycle(agent,coordinator,agent_id,- input_data=initial_input,+ input_data=[],run_config=run_config,context=context,max_turns=max_turns,@@ -87,29 +124,68 @@ async def _run_agent_loop(event_sink=event_sink,)- if not interactive:- return result- while True:- try:- await coordinator.wait_for_message(agent_id)- except asyncio.CancelledError:- return result+async def _run_noninteractive_until_lifecycle(+ agent: Any,+ coordinator: AgentCoordinator,+ agent_id: str,+ *,+ initial_input: Any,+ run_config: RunConfig,+ context: dict[str, Any],+ max_turns: int,+ session: Session | None,+ event_sink: StreamEventSink | None,+) -> RunResultBase | None:+ """Non-chat mode keeps running until finish_scan / agent_finish settles status."""+ result: RunResultBase | None = None+ input_data: Any = initial_input+ invalid_final_outputs = 0+ invalid_final_output_limit = max(1, max_turns)- await coordinator.consume_pending(agent_id)+ while True:result = await _run_cycle(agent,coordinator,agent_id,- input_data=[],+ input_data=input_data,run_config=run_config,context=context,max_turns=max_turns,session=session,- interactive=interactive,+ interactive=False,event_sink=event_sink,)+ status = await _agent_status(coordinator, agent_id)+ if status != "running":+ return result++ invalid_final_outputs += 1+ logger.warning(+ "agent %s produced non-lifecycle final output in non-interactive mode; "+ "forcing tool continuation (%d/%d): %s",+ agent_id,+ invalid_final_outputs,+ invalid_final_output_limit,+ _final_output_preview(result),+ )++ if invalid_final_outputs >= invalid_final_output_limit:+ await coordinator.set_status(agent_id, "crashed")+ await _notify_parent_on_crash(coordinator, agent_id, "crashed")+ raise MaxTurnsExceeded(+ "Agent exhausted non-interactive recovery attempts without calling "+ "finish_scan or agent_finish."+ )++ input_data = await _append_noninteractive_tool_required_message(+ session=session,+ context=context,+ attempt=invalid_final_outputs,+ limit=invalid_final_output_limit,+ )+async def _run_cycle(agent: Any,@@ -175,9 +251,50 @@ async def _settle_run_result(if current_status != "running":return- status: Status = "waiting" if interactive else "crashed"- await coordinator.set_status(agent_id, status)- await _notify_parent_on_crash(coordinator, agent_id, status)+ if not interactive:+ return++ await coordinator.set_status(agent_id, "waiting")+++async def _agent_status(coordinator: AgentCoordinator, agent_id: str) -> Status | None:+ async with coordinator._lock:+ return coordinator.statuses.get(agent_id)+++def _final_output_preview(result: RunResultBase | None) -> str:+ final_output = getattr(result, "final_output", None)+ if final_output is None:+ return "<none>"+ text = str(final_output).replace("\n", " ").strip()+ if not text:+ return "<empty>"+ return text[:300]+++async def _append_noninteractive_tool_required_message(+ *,+ session: Session | None,+ context: dict[str, Any],+ attempt: int,+ limit: int,+) -> list[dict[str, str]]:+ finish_tool = "finish_scan" if context.get("parent_id") is None else "agent_finish"+ message = (+ "Your previous response ended the autonomous Strix run without a lifecycle tool call. "+ "That is invalid in non-interactive mode; plain text final answers are ignored. "+ "Continue immediately and call exactly one tool. "+ f"If your work is complete, call {finish_tool}. "+ "If you are blocked waiting for another agent, call wait_for_message. "+ "Otherwise use the appropriate execution or planning tool. "+ f"This is recovery attempt {attempt}/{limit}."+ )+ item = {"role": "user", "content": message}+ if session is None:+ return [item]++ await session.add_items([cast("TResponseInputItem", item)])+ return []async def _notify_parent_on_crash(