Open-source AI penetration testing tool to find and fix your app’s vulnerabilities.
Python agentsai-hackingai-penetration-testingai-pentestingai-securityartificial-intelligencebug-bountycode-qualityctf-toolscybersecuritycybersecurity-toolsethical-hackinghackingllm-securityoffensive-securitypenetration-testingpentesting-toolsred-teamingsecuritysecurity-automation
Strip all images from session on vision-rejection, not just the latest (#553)
Ahmed Allamf7e3af49bd5c
diff --git a/strix/core/execution.py b/strix/core/execution.pyindex 1b561e9e..0e9f9140 100644--- a/strix/core/execution.py+++ b/strix/core/execution.py@@ -16,7 +16,7 @@ from docker import errors as docker_errors # type: ignore[import-untyped, unusefrom openai import APIErrorfrom strix.core.inputs import child_initial_input-from strix.core.sessions import open_agent_session, strip_latest_image_from_session+from strix.core.sessions import open_agent_session, strip_all_images_from_sessionif TYPE_CHECKING:@@ -384,14 +384,14 @@ async def _run_cycle( # noqa: PLR0912, PLR0915and getattr(exc, "status_code", None) in _INPUT_REJECTION_CODES):try:- stripped = await strip_latest_image_from_session(session)+ stripped = await strip_all_images_from_session(session)except Exception:logger.exception("image-strip recovery failed for %s", agent_id)stripped = Falseif stripped:image_strips += 1logger.info(- "Stripped latest image from %s session after rejection; retrying (%d)",+ "Stripped images from %s session after rejection; retrying (%d)",agent_id,image_strips,)diff --git a/strix/core/sessions.py b/strix/core/sessions.pyindex 28bdf711..8e4f4142 100644--- a/strix/core/sessions.py+++ b/strix/core/sessions.py@@ -2,7 +2,8 @@from __future__ import annotations-from typing import TYPE_CHECKING, cast+import contextlib+from typing import TYPE_CHECKING, Any, castfrom agents.memory import SQLiteSession@@ -22,29 +23,43 @@ def open_agent_session(agent_id: str, path: Path) -> SQLiteSession:_IMAGE_REJECTED_TEXT = "[image rejected by the model]"-async def strip_latest_image_from_session(session: Session) -> bool:+async def strip_all_images_from_session(session: Session) -> bool:items = await session.get_items()if not items:return False- latest = items[-1]- if not isinstance(latest, dict) or latest.get("type") != "function_call_output":- return False- output = latest.get("output")- if not isinstance(output, list):- return False- if not any(isinstance(b, dict) and b.get("type") == "input_image" for b in output):- return False- await session.pop_item()- await session.add_items(- cast(- "list[TResponseInputItem]",- [++ rebuilt: list[Any] = []+ changed = False+ for item in items:+ item_dict = cast("dict[str, Any]", item) if isinstance(item, dict) else None+ if (+ item_dict is not None+ and item_dict.get("type") == "function_call_output"+ and isinstance(item_dict.get("output"), list)+ and any(+ isinstance(b, dict) and b.get("type") == "input_image" for b in item_dict["output"]+ )+ ):+ rebuilt.append({"type": "function_call_output",- "call_id": latest.get("call_id"),+ "call_id": item_dict.get("call_id"),"output": [{"type": "input_text", "text": _IMAGE_REJECTED_TEXT}],},- ],- ),- )+ )+ changed = True+ else:+ rebuilt.append(item)++ if not changed:+ return False++ rebuilt_items = cast("list[TResponseInputItem]", rebuilt)+ await session.clear_session()+ try:+ await session.add_items(rebuilt_items)+ except Exception:+ with contextlib.suppress(Exception):+ await session.add_items(rebuilt_items)+ raisereturn Truediff --git a/strix/tools/view_image/README.md b/strix/tools/view_image/README.mdindex 38272061..cd4c6229 100644--- a/strix/tools/view_image/README.md+++ b/strix/tools/view_image/README.md@@ -13,5 +13,5 @@ returns it as an image content block for vision-capable models.`containers/docker-entrypoint.sh`).- **Skill:** screenshot workflow lives in `strix/skills/tooling/agent_browser.md`.- **Recovery:** vision-not-supported model rejections are auto-recovered- via `strix.core.sessions.strip_latest_image_from_session`, invoked from+ via `strix.core.sessions.strip_all_images_from_session`, invoked from`strix/core/execution.py`.