Skip to content

The Postgres development platform. Supabase gives you a dedicated Postgres database to build your web, mobile, and AI applications.

fix: clean up grouped input border rendering (#44690)

Danny White0005d3742dc6
diff --git a/packages/ui-patterns/src/DataInputs/Input.tsx b/packages/ui-patterns/src/DataInputs/Input.tsx
index 9b723c887c5..5254b837af8 100644
--- a/packages/ui-patterns/src/DataInputs/Input.tsx
+++ b/packages/ui-patterns/src/DataInputs/Input.tsx
@@ -88,7 +88,11 @@ const Input = forwardRef<
/>
{icon && <InputGroupAddon align="inline-start">{icon}</InputGroupAddon>}
{copy || actions ? (
- <InputGroupAddon align="inline-end">
+ <InputGroupAddon
+ align="inline-end"
+ // Override defaults
+ className="pr-1 has-[>button]:mr-0 has-[>kbd]:mr-0"
+ >
{copy && !(reveal && hidden) ? (
<InputGroupButton
size="tiny"
diff --git a/packages/ui/src/components/shadcn/ui/input-group.tsx b/packages/ui/src/components/shadcn/ui/input-group.tsx
index 8d5cef5dbf8..404f8c37dc0 100644
--- a/packages/ui/src/components/shadcn/ui/input-group.tsx
+++ b/packages/ui/src/components/shadcn/ui/input-group.tsx
@@ -59,7 +59,8 @@ function InputGroup({
'has-[[data-slot=input-group-control]:focus-visible]:outline-none has-[[data-slot=input-group-control]:focus-visible]:ring-2 has-[[data-slot=input-group-control]:focus-visible]:ring-background-control has-[[data-slot=input-group-control]:focus-visible]:ring-offset-2 has-[[data-slot=input-group-control]:focus-visible]:ring-offset-foreground-muted',
// Error state.
- 'has-[[data-slot][aria-invalid=true]]:ring-destructive/20 has-[[data-slot][aria-invalid=true]]:border-destructive dark:has-[[data-slot][aria-invalid=true]]:ring-destructive/40',
+ 'has-[[data-slot][aria-invalid=true]]:bg-destructive-200 has-[[data-slot][aria-invalid=true]]:ring-destructive/20 has-[[data-slot][aria-invalid=true]]:border-destructive-400 dark:has-[[data-slot][aria-invalid=true]]:ring-destructive/40',
+ 'has-[[data-slot][aria-invalid=true]]:has-[[data-slot=input-group-control]:focus-visible]:border-destructive',
// Disabled state.
'has-[[data-slot=input-group-control]:disabled]:cursor-not-allowed has-[[data-slot=input-group-control]:disabled]:text-foreground-muted',
@@ -163,7 +164,11 @@ function InputGroupInput({ className, ...props }: InputProps) {
<Input
data-slot="input-group-control"
className={cn(
- 'flex-1 rounded-none border-0 -m-px bg-transparent shadow-none focus-visible:ring-0 focus-visible:ring-offset-0 dark:bg-transparent',
+ 'flex-1 rounded-none border border-transparent -m-px bg-transparent shadow-none',
+ 'focus:border-transparent focus-visible:border-transparent focus-visible:ring-0 focus-visible:ring-offset-0',
+ 'read-only:border-transparent',
+ 'aria-[invalid=true]:border-transparent aria-[invalid=true]:bg-transparent',
+ 'aria-[invalid=true]:focus:border-transparent aria-[invalid=true]:focus-visible:border-transparent',
className
)}
{...props}
@@ -179,7 +184,8 @@ function InputGroupTextarea({ className, ...props }: TextareaProps) {
<Textarea
data-slot="input-group-control"
className={cn(
- 'flex-1 resize-none rounded-none border-0 bg-transparent py-0 shadow-none focus-visible:ring-0 focus-visible:ring-offset-0 dark:bg-transparent',
+ 'flex-1 resize-none rounded-none border border-transparent bg-transparent py-0 shadow-none',
+ 'focus:border-transparent focus-visible:border-transparent focus-visible:ring-0 focus-visible:ring-offset-0',
className
)}
{...props}