Skip to content

The Postgres development platform. Supabase gives you a dedicated Postgres database to build your web, mobile, and AI applications.

Add role impersonation check for CSV imports (#50213)

Joshen Lim103051a1498d
diff --git a/apps/studio/components/interfaces/TableGridEditor/SidePanelEditor/SidePanelEditor.tsx b/apps/studio/components/interfaces/TableGridEditor/SidePanelEditor/SidePanelEditor.tsx
index e9b6de95b4d..9e995ed9a4e 100644
--- a/apps/studio/components/interfaces/TableGridEditor/SidePanelEditor/SidePanelEditor.tsx
+++ b/apps/studio/components/interfaces/TableGridEditor/SidePanelEditor/SidePanelEditor.tsx
@@ -63,6 +63,7 @@ import { isObjectContainingKeys } from '@/lib/helpers'
import type { SafePostgresTable } from '@/lib/postgres-types'
import { useTrack } from '@/lib/telemetry/track'
import type { DeepReadonly, Prettify } from '@/lib/type-helpers'
+import { useGetImpersonatedRoleState } from '@/state/role-impersonation-state'
import { useTableEditorStateSnapshot, type TableEditorState } from '@/state/table-editor'
import { createTabId, useTabsStateSnapshot } from '@/state/tabs'
import type { Dictionary } from '@/types'
@@ -191,6 +192,7 @@ export const SidePanelEditor = ({
const { data: project } = useSelectedProjectQuery()
const isQueueOperationsEnabled = useIsQueueOperationsEnabled()
const { updateRow, addRow, isEditPending } = useTableRowOperations()
+ const getImpersonatedRoleState = useGetImpersonatedRoleState()
const scoped = !!useFlag(PG_META_SCOPED_INTROSPECTION_FLAG)
const [isEdited, setIsEdited] = useState<boolean>(false)
@@ -824,6 +826,7 @@ export const SidePanelEditor = ({
table: selectedTable,
selectedHeaders,
emptyStringAsNullHeaders,
+ roleImpersonationState: getImpersonatedRoleState(),
onProgressUpdate: (progress: number) => {
toast.loading(
<SonnerProgress
@@ -849,6 +852,7 @@ export const SidePanelEditor = ({
rows: importContent.rows,
selectedHeaders,
emptyStringAsNullHeaders,
+ roleImpersonationState: getImpersonatedRoleState(),
onProgressUpdate: (progress: number) => {
toast.loading(
<SonnerProgress
diff --git a/apps/studio/components/interfaces/TableGridEditor/SidePanelEditor/SidePanelEditor.utils.tsx b/apps/studio/components/interfaces/TableGridEditor/SidePanelEditor/SidePanelEditor.utils.tsx
index a23576628b5..39b053096de 100644
--- a/apps/studio/components/interfaces/TableGridEditor/SidePanelEditor/SidePanelEditor.utils.tsx
+++ b/apps/studio/components/interfaces/TableGridEditor/SidePanelEditor/SidePanelEditor.utils.tsx
@@ -47,8 +47,10 @@ import {
import { getTables } from '@/data/tables/tables-query'
import { isObject, isObjectContainingKeys, timeout, tryParseJson } from '@/lib/helpers'
import type { SafePostgresColumn } from '@/lib/postgres-types'
+import { RoleImpersonationState, wrapWithRoleImpersonation } from '@/lib/role-impersonation'
import type { useTrack } from '@/lib/telemetry/track'
import type { DeepReadonly } from '@/lib/type-helpers'
+import { isRoleImpersonationEnabled } from '@/state/role-impersonation-state'
import type { SidePanel } from '@/state/table-editor'
const BATCH_SIZE = 1000
@@ -933,6 +935,7 @@ export async function insertRowsViaSpreadsheet({
table,
selectedHeaders,
emptyStringAsNullHeaders = selectedHeaders,
+ roleImpersonationState,
onProgressUpdate,
}: {
projectRef: string
@@ -941,6 +944,7 @@ export async function insertRowsViaSpreadsheet({
table: RetrieveTableResult
selectedHeaders: string[]
emptyStringAsNullHeaders?: string[]
+ roleImpersonationState?: RoleImpersonationState
onProgressUpdate: (progress: number) => void
}): Promise<{ error: unknown }> {
let chunkNumber = 0
@@ -964,10 +968,18 @@ export async function insertRowsViaSpreadsheet({
emptyStringAsNullHeaders,
})
- const insertQuery = new Query().from(table.name, table.schema).insert(formattedData).toSql()
+ const insertQuery = wrapWithRoleImpersonation(
+ new Query().from(table.name, table.schema).insert(formattedData).toSql(),
+ roleImpersonationState
+ )
try {
await executeWithRetry(() =>
- executeSql({ projectRef, connectionString, sql: insertQuery })
+ executeSql({
+ projectRef,
+ connectionString,
+ sql: insertQuery,
+ isRoleImpersonationEnabled: isRoleImpersonationEnabled(roleImpersonationState?.role),
+ })
)
} catch (error) {
console.warn(error)
@@ -1034,6 +1046,7 @@ export async function insertTableRows({
rows,
selectedHeaders,
emptyStringAsNullHeaders = selectedHeaders,
+ roleImpersonationState,
onProgressUpdate,
}: {
projectRef: string
@@ -1042,6 +1055,7 @@ export async function insertTableRows({
rows: unknown[]
selectedHeaders: string[]
emptyStringAsNullHeaders?: string[]
+ roleImpersonationState?: RoleImpersonationState
onProgressUpdate: (progress: number) => void
}): Promise<{ error: unknown }> {
let insertError: unknown = undefined
@@ -1059,9 +1073,17 @@ export async function insertTableRows({
return () => {
return Promise.race([
new Promise(async (resolve, reject) => {
- const insertQuery = new Query().from(table.name, table.schema).insert(batch).toSql()
+ const insertQuery = wrapWithRoleImpersonation(
+ new Query().from(table.name, table.schema).insert(batch).toSql(),
+ roleImpersonationState
+ )
try {
- await executeSql({ projectRef, connectionString, sql: insertQuery })
+ await executeSql({
+ projectRef,
+ connectionString,
+ sql: insertQuery,
+ isRoleImpersonationEnabled: isRoleImpersonationEnabled(roleImpersonationState?.role),
+ })
} catch (error) {
insertError = error
reject(error)