Skip to content

The Postgres development platform. Supabase gives you a dedicated Postgres database to build your web, mobile, and AI applications.

fix: updated styling based on feedback (#42694)

Ali Waseem1ed4ea0c60de
diff --git a/packages/ui-patterns/src/FilterBar/CommandListItem.tsx b/packages/ui-patterns/src/FilterBar/CommandListItem.tsx
index c420640469a..8c05ebb985b 100644
--- a/packages/ui-patterns/src/FilterBar/CommandListItem.tsx
+++ b/packages/ui-patterns/src/FilterBar/CommandListItem.tsx
@@ -1,4 +1,3 @@
-import { Check } from 'lucide-react'
import { cn } from 'ui'
import { OperatorSymbolBadge } from './OperatorSymbolBadge'
@@ -7,7 +6,6 @@ import { MenuItem } from './types'
export type CommandListItemProps = {
item: MenuItem
isHighlighted: boolean
- isSelected: boolean
includeIcon: boolean
onSelect: (item: MenuItem) => void
setRef: (el: HTMLDivElement | null) => void
@@ -16,7 +14,6 @@ export type CommandListItemProps = {
export function CommandListItem({
item,
isHighlighted,
- isSelected,
includeIcon,
onSelect,
setRef,
@@ -25,7 +22,6 @@ export function CommandListItem({
<div
ref={setRef}
role="option"
- aria-selected={isSelected}
onClick={() => onSelect(item)}
className={cn(
'relative flex items-center justify-between gap-2 px-2 py-1.5 text-xs cursor-pointer select-none outline-none text-foreground-light',
@@ -37,10 +33,7 @@ export function CommandListItem({
{includeIcon && item.icon}
{item.label}
</span>
- <span className="flex items-center gap-1.5">
- {item.operatorSymbol && <OperatorSymbolBadge symbol={item.operatorSymbol} />}
- {isSelected && <Check className="h-4 w-4 text-foreground-muted" strokeWidth={2} />}
- </span>
+ {item.operatorSymbol && <OperatorSymbolBadge symbol={item.operatorSymbol} />}
</div>
)
}
diff --git a/packages/ui-patterns/src/FilterBar/DefaultCommandList.helpers.tsx b/packages/ui-patterns/src/FilterBar/DefaultCommandList.helpers.tsx
index 7f75ff009ca..7a507adc69f 100644
--- a/packages/ui-patterns/src/FilterBar/DefaultCommandList.helpers.tsx
+++ b/packages/ui-patterns/src/FilterBar/DefaultCommandList.helpers.tsx
@@ -4,7 +4,7 @@ export function EmptyState() {
export function GroupHeader({ label }: { label: string }) {
return (
- <div className="px-2 py-1.5 text-xs text-foreground-lighter font-normal tracking-wide">
+ <div className="px-2 py-1.5 text-xs text-foreground-lighter font-medium tracking-wide">
{label}
</div>
)
diff --git a/packages/ui-patterns/src/FilterBar/DefaultCommandList.tsx b/packages/ui-patterns/src/FilterBar/DefaultCommandList.tsx
index 09d5065ac6d..761019dfc25 100644
--- a/packages/ui-patterns/src/FilterBar/DefaultCommandList.tsx
+++ b/packages/ui-patterns/src/FilterBar/DefaultCommandList.tsx
@@ -13,7 +13,6 @@ export type DefaultCommandListProps = {
onSelect: (item: MenuItem) => void
includeIcon?: boolean
grouped?: boolean
- selectedValue?: string
}
export function DefaultCommandList({
@@ -22,7 +21,6 @@ export function DefaultCommandList({
onSelect,
includeIcon = true,
grouped = false,
- selectedValue,
}: DefaultCommandListProps) {
const listRef = useRef<HTMLDivElement>(null)
const itemRefs = useRef<Map<number, HTMLDivElement>>(new Map())
@@ -78,7 +76,6 @@ export function DefaultCommandList({
key={`${item.value}-${item.label}`}
item={item}
isHighlighted={index === highlightedIndex}
- isSelected={selectedValue === item.value}
includeIcon={includeIcon}
onSelect={onSelect}
setRef={setItemRef(index)}
diff --git a/packages/ui-patterns/src/FilterBar/FilterCondition.tsx b/packages/ui-patterns/src/FilterBar/FilterCondition.tsx
index 27e7637b590..1c10369aae1 100644
--- a/packages/ui-patterns/src/FilterBar/FilterCondition.tsx
+++ b/packages/ui-patterns/src/FilterBar/FilterCondition.tsx
@@ -260,7 +260,6 @@ export function FilterCondition({
highlightedIndex={opHighlightedIndex}
onSelect={handleSelectMenuItem}
includeIcon={false}
- selectedValue={condition.operator}
grouped
/>
</PopoverContent_Shadcn_>
diff --git a/packages/ui-patterns/src/FilterBar/OperatorSymbolBadge.tsx b/packages/ui-patterns/src/FilterBar/OperatorSymbolBadge.tsx
index d0788fd7b28..1870be99c0b 100644
--- a/packages/ui-patterns/src/FilterBar/OperatorSymbolBadge.tsx
+++ b/packages/ui-patterns/src/FilterBar/OperatorSymbolBadge.tsx
@@ -4,7 +4,7 @@ export type OperatorSymbolBadgeProps = {
export function OperatorSymbolBadge({ symbol }: OperatorSymbolBadgeProps) {
return (
- <span className="ml-auto text-xs text-brand bg-surface-200 rounded px-1.5 py-0.5 font-mono">
+ <span className="ml-auto text-xs text-foreground-light bg-surface-200 rounded px-1.5 py-0.5 font-mono">
{symbol}
</span>
)