Skip to content

The Postgres development platform. Supabase gives you a dedicated Postgres database to build your web, mobile, and AI applications.

feat(studio): edit pipeline setup sections from review (#51901)

Danny White306cd88a2b34
diff --git a/apps/studio/components/interfaces/Database/Replication/CreatePipeline/PipelineCreationFlow.test.tsx b/apps/studio/components/interfaces/Database/Replication/CreatePipeline/PipelineCreationFlow.test.tsx
index c58a7e8a1e7..da10ae6121a 100644
--- a/apps/studio/components/interfaces/Database/Replication/CreatePipeline/PipelineCreationFlow.test.tsx
+++ b/apps/studio/components/interfaces/Database/Replication/CreatePipeline/PipelineCreationFlow.test.tsx
@@ -135,9 +135,9 @@ const selectPublication = async () => {
const back = () => fireEvent.click(within(stepCard()).getByRole('button', { name: 'Back' }))
describe('PipelineCreationFlow', () => {
- const reachReview = async (onClose = vi.fn()) => {
+ const reachReview = async (onClose = vi.fn(), onUrlUpdate = vi.fn()) => {
customRender(<PipelineCreationFlow availableDestinations={['BigQuery']} onClose={onClose} />, {
- nuqs: { hasMemory: true },
+ nuqs: { hasMemory: true, rateLimitFactor: 1, onUrlUpdate },
})
next()
fillConnection()
@@ -254,6 +254,34 @@ describe('PipelineCreationFlow', () => {
}
)
+ it('edits each section from Review without losing values', async () => {
+ const onUrlUpdate = vi.fn()
+ const waitForReview = () =>
+ waitFor(() =>
+ expect(onUrlUpdate).toHaveBeenLastCalledWith(
+ expect.objectContaining({ queryString: '?step=review' })
+ )
+ )
+ await reachReview(vi.fn(), onUrlUpdate)
+ await waitForReview()
+ fireEvent.click(screen.getByRole('button', { name: 'Edit connection' }))
+ await screen.findByText(/Step 2 of 4/)
+ expect(screen.getByRole('textbox', { name: 'Pipeline name' })).toHaveValue('Warehouse')
+ next()
+ await screen.findByText(/Step 3 of 4/)
+ next()
+ await waitForReview()
+ fireEvent.click(screen.getByRole('button', { name: 'Edit data' }))
+ await screen.findByText(/Step 3 of 4/)
+ next()
+ await waitForReview()
+ fireEvent.click(screen.getByRole('button', { name: 'Edit destination' }))
+ await screen.findByText(/Step 1 of 4/)
+ next()
+ await screen.findByText(/Step 2 of 4/)
+ expect(screen.getByRole('textbox', { name: 'Pipeline name' })).toHaveValue('Warehouse')
+ })
+
it('preserves reviewed values when creation fails and retries safely', async () => {
const { requests, starts } = mockCreation({ failCreate: true })
const onClose = vi.fn()
diff --git a/apps/studio/components/interfaces/Database/Replication/CreatePipeline/PipelineCreationFlow.tsx b/apps/studio/components/interfaces/Database/Replication/CreatePipeline/PipelineCreationFlow.tsx
index d9600a90676..60bb9f03fcf 100644
--- a/apps/studio/components/interfaces/Database/Replication/CreatePipeline/PipelineCreationFlow.tsx
+++ b/apps/studio/components/interfaces/Database/Replication/CreatePipeline/PipelineCreationFlow.tsx
@@ -185,12 +185,18 @@ export const PipelineCreationFlow = ({
)}
{accessibleStep === 'review' && (
<>
- <PipelineDestinationReview type={type} control={form.control} />
+ <PipelineDestinationReview
+ type={type}
+ control={form.control}
+ onEditDestination={() => void setStep('destination')}
+ onEditConnection={() => void setStep('connection')}
+ />
<Separator />
<PipelineDataReview
type={type}
control={form.control}
publication={publication}
+ onEdit={() => void setStep('data')}
/>
<Separator />
<PipelineReviewCosts control={form.control} publication={publication} />
diff --git a/apps/studio/components/interfaces/Database/Replication/CreatePipeline/PipelineDataReview.tsx b/apps/studio/components/interfaces/Database/Replication/CreatePipeline/PipelineDataReview.tsx
index 3a713f1d545..6eb3bc89b00 100644
--- a/apps/studio/components/interfaces/Database/Replication/CreatePipeline/PipelineDataReview.tsx
+++ b/apps/studio/components/interfaces/Database/Replication/CreatePipeline/PipelineDataReview.tsx
@@ -1,5 +1,6 @@
+import { EditIcon } from 'lucide-react'
import { useWatch, type Control } from 'react-hook-form'
-import { Input } from 'ui'
+import { Button, Input } from 'ui'
import { FormItemLayout } from 'ui-patterns/form/FormItemLayout/FormItemLayout'
import * as defaults from '../DestinationPanel/DestinationForm/DestinationForm.constants'
@@ -17,10 +18,12 @@ export const PipelineDataReview = ({
type,
control,
publication,
+ onEdit,
}: {
type: DestinationType
control: Control<DestinationPanelSchemaType>
publication?: ReplicationPublicationData
+ onEdit?: () => void
}) => {
const [publicationName, mode, ids, workers, copies, slot, batch, options] = useWatch({
control,
@@ -111,7 +114,20 @@ export const PipelineDataReview = ({
: []
return (
<section aria-label="Data review" className="space-y-6 p-5">
- <h3 className="text-sm font-medium text-foreground">Data</h3>
+ <div className="flex items-center justify-between gap-2">
+ <h3 className="text-sm font-medium text-foreground">Data</h3>
+ {onEdit && (
+ <Button
+ type="button"
+ icon={<EditIcon />}
+ size="tiny"
+ aria-label="Edit data"
+ onClick={onEdit}
+ >
+ Edit
+ </Button>
+ )}
+ </div>
{rows.map((row) => (
<ReviewField key={row.label} {...row} />
))}
diff --git a/apps/studio/components/interfaces/Database/Replication/CreatePipeline/PipelineDestinationReview.tsx b/apps/studio/components/interfaces/Database/Replication/CreatePipeline/PipelineDestinationReview.tsx
index 3e0044a591b..434be5de377 100644
--- a/apps/studio/components/interfaces/Database/Replication/CreatePipeline/PipelineDestinationReview.tsx
+++ b/apps/studio/components/interfaces/Database/Replication/CreatePipeline/PipelineDestinationReview.tsx
@@ -1,4 +1,4 @@
-import { EyeIcon, EyeOffIcon } from 'lucide-react'
+import { EditIcon, EyeIcon, EyeOffIcon } from 'lucide-react'
import { useState } from 'react'
import { useWatch, type Control } from 'react-hook-form'
import { Button, Input, Separator } from 'ui'
@@ -49,9 +49,13 @@ const MaskedUrl = ({ value, label }: { value: string; label: string }) => {
export const PipelineDestinationReview = ({
type,
control,
+ onEditDestination,
+ onEditConnection,
}: {
type: DestinationType
control: Control<DestinationPanelSchemaType>
+ onEditDestination?: () => void
+ onEditConnection?: () => void
}) => {
const [
name,
@@ -144,7 +148,20 @@ export const PipelineDestinationReview = ({
return (
<section aria-label="Destination review">
<div className="space-y-6 p-5">
- <h3 className="text-sm font-medium text-foreground">Destination</h3>
+ <div className="flex items-center justify-between gap-2">
+ <h3 className="text-sm font-medium text-foreground">Destination</h3>
+ {onEditDestination && (
+ <Button
+ type="button"
+ icon={<EditIcon />}
+ size="tiny"
+ aria-label="Edit destination"
+ onClick={onEditDestination}
+ >
+ Edit
+ </Button>
+ )}
+ </div>
<FormItemLayout
isReactForm={false}
layout="horizontal"
@@ -159,7 +176,20 @@ export const PipelineDestinationReview = ({
</div>
<Separator />
<div className="space-y-6 p-5">
- <h3 className="text-sm font-medium text-foreground">Connection</h3>
+ <div className="flex items-center justify-between gap-2">
+ <h3 className="text-sm font-medium text-foreground">Connection</h3>
+ {onEditConnection && (
+ <Button
+ type="button"
+ icon={<EditIcon />}
+ size="tiny"
+ aria-label="Edit connection"
+ onClick={onEditConnection}
+ >
+ Edit
+ </Button>
+ )}
+ </div>
{[{ ...PIPELINE_NAME_FIELD_COPY, value: name }, ...rows].map((row) => (
<FormItemLayout
key={row.label}