The Postgres development platform. Supabase gives you a dedicated Postgres database to build your web, mobile, and AI applications.
TypeScript aialternativeauthdatabasedenoembeddingsexamplefirebasenextjsoauth2pgvectorpostgispostgrespostgresqlpostgrestrealtimesupabasevectorswebsockets
Joshen/fe 3624 queryblock causes client side crash if rendering many rows (#47021)
Joshen Lim42ec3c4960b9
diff --git a/apps/studio/components/interfaces/Reports/ReportBlock/ReportBlock.tsx b/apps/studio/components/interfaces/Reports/ReportBlock/ReportBlock.tsxindex fc75bd1b27d..f0e8152f3b2 100644--- a/apps/studio/components/interfaces/Reports/ReportBlock/ReportBlock.tsx+++ b/apps/studio/components/interfaces/Reports/ReportBlock/ReportBlock.tsx@@ -5,6 +5,7 @@ import { X } from 'lucide-react'import { useEffect, useState } from 'react'import { toast } from 'sonner'+import { checkIfAppendLimitRequired, suffixWithLimit } from '../../SQLEditor/SQLEditor.utils'import { BURSTABLE_IO_METRIC_KEYS, DEPRECATED_REPORTS } from '../Reports.constants'import { ChartBlock } from './ChartBlock'import { DeprecatedChartBlock } from './DeprecatedChartBlock'@@ -78,7 +79,10 @@ export const ReportBlock = ({})+ const autoLimit = 100const sql = isSnippet ? (data?.content as SqlSnippets.Content)?.unchecked_sql : undefined+ const { appendAutoLimit } = checkIfAppendLimitRequired(sql ?? '', autoLimit)+const chartConfig = { ...DEFAULT_CHART_CONFIG, ...(item.chartConfig ?? {}) }const isDeprecatedChart = DEPRECATED_REPORTS.includes(item.attribute)const snippetMissing = contentError?.message.includes('Content not found')@@ -98,6 +102,7 @@ export const ReportBlock = ({sql,readOnlyConnectionString,postgresConnectionString,+ autoLimit,]),queryFn: async () => {if (!projectRef || !sql) return null@@ -109,13 +114,15 @@ export const ReportBlock = ({return null}+ const formattedSql = suffixWithLimit(acceptUntrustedSql(sql), autoLimit)+return executeSql({projectRef,connectionString,// acceptUntrustedSql is usually not allowed in an auto-run position,// but in this case we are explicitly allowing it because adding a block// to a report is an explicit user action.- sql: acceptUntrustedSql(sql),+ sql: formattedSql,})},enabled: !isLoadingContent && contentError == null,@@ -180,6 +187,7 @@ export const ReportBlock = ({onUpdateChartConfig={onUpdateChart}onRemoveChart={() => onRemoveChart({ metric: { key: item.attribute } })}disabled={isLoadingContent || snippetMissing || !sql}+ autoLimit={appendAutoLimit}/>) : isUnavailableBurstChart ? (<UnavailableChartBlockdiff --git a/apps/studio/components/ui/QueryBlock/QueryBlock.tsx b/apps/studio/components/ui/QueryBlock/QueryBlock.tsxindex 43e8d866c81..c586fb79f6a 100644--- a/apps/studio/components/ui/QueryBlock/QueryBlock.tsx+++ b/apps/studio/components/ui/QueryBlock/QueryBlock.tsx@@ -50,6 +50,7 @@ export interface QueryBlockProps {blockWriteQueries?: boolean/** Render the chart tooltip in a portal so it isn't clipped by overflow-hidden ancestors (e.g. report cards). */portalTooltip?: boolean+ autoLimit?: booleanonExecute?: (queryType: 'select' | 'mutation') => voidonRemoveChart?: () => voidonUpdateChartConfig?: ({ chartConfig }: { chartConfig: Partial<ChartConfig> }) => void@@ -73,6 +74,7 @@ export const QueryBlock = ({disabled = false,blockWriteQueries = false,portalTooltip = false,+ autoLimit = false,onExecute,onRemoveChart,onUpdateChartConfig,@@ -390,6 +392,11 @@ export const QueryBlock = ({)}><Results rows={results} />+ {autoLimit && (+ <p className="text-xs font-mono px-2 py-1 border-t text-foreground-light">+ Limited to only 100 rows+ </p>+ )}</div>))}diff --git a/apps/studio/components/ui/QueryBlock/QueryBlock.utils.ts b/apps/studio/components/ui/QueryBlock/QueryBlock.utils.tsindex 884b6d58663..7a7ffbb9708 100644--- a/apps/studio/components/ui/QueryBlock/QueryBlock.utils.ts+++ b/apps/studio/components/ui/QueryBlock/QueryBlock.utils.ts@@ -31,8 +31,11 @@ export const computeYAxisWidth = (): number => {if (isLogScale) return 52if (isPercentage) return Math.max(36, (3 + 1) * 8) // max tick is "100"- const maxMagnitude =- data.length > 0 ? Math.max(...data.map((d) => Math.abs(Number(d[key]) || 0))) : 0++ const maxMagnitude = data.reduce((max, d) => {+ const magnitude = Math.abs(Number(d[key]) || 0)+ return magnitude > max ? magnitude : max+ }, 0)return Math.max(36, (formatYAxisTick(maxMagnitude).length + 1) * 8)}