The Postgres development platform. Supabase gives you a dedicated Postgres database to build your web, mobile, and AI applications.
TypeScript aialternativeauthdatabasedenoembeddingsexamplefirebasenextjsoauth2pgvectorpostgispostgrespostgresqlpostgrestrealtimesupabasevectorswebsockets
Refactor ReportSettings to use popover instead of dropdown menu (#47488)
Joshen Lim61a333a41d96
diff --git a/apps/studio/components/ui/Charts/ReportSettings.tsx b/apps/studio/components/ui/Charts/ReportSettings.tsxindex 2b1299c1b92..17248926ddf 100644--- a/apps/studio/components/ui/Charts/ReportSettings.tsx+++ b/apps/studio/components/ui/Charts/ReportSettings.tsx@@ -1,6 +1,6 @@import { Settings } from 'lucide-react'import { useState } from 'react'-import { cn, DropdownMenu, DropdownMenuContent, DropdownMenuTrigger, Label, Switch } from 'ui'+import { Label, Popover, PopoverContent, PopoverTrigger, Switch } from 'ui'import { useChartHoverState } from './useChartHoverState'import { ButtonTooltip } from '@/components/ui/ButtonTooltip'@@ -14,46 +14,43 @@ export const ReportSettings = ({ chartId }: ReportSettingsProps) => {const { syncHover, syncTooltip, setSyncHover, setSyncTooltip } = useChartHoverState(chartId)return (- <DropdownMenu open={isOpen} onOpenChange={setIsOpen}>- <DropdownMenuTrigger asChild>+ <Popover open={isOpen} onOpenChange={setIsOpen}>+ <PopoverTrigger asChild><ButtonTooltipvariant="default"icon={<Settings />}className="w-7"tooltip={{ content: { side: 'bottom', text: 'Report settings' } }}/>- </DropdownMenuTrigger>- <DropdownMenuContent align="start" side="bottom" className="w-64 p-3">- <div className="space-y-4">- <Label htmlFor="sync-hover" className="text-sm font-normal">- <div className="flex items-center justify-between space-x-2">- Sync chart headers- <Switch id="sync-hover" checked={syncHover} onCheckedChange={setSyncHover} />- </div>- <p className="text-xs text-foreground-light mt-1">- When enabled, hovering over any chart will update headers across all charts- </p>- </Label>-- <Label htmlFor="sync-tooltips" className="text-sm font-normal flex flex-col">- <div className="flex items-center justify-between space-x-2">- Sync tooltips- <Switch- id="sync-tooltips"- checked={syncTooltip}- disabled={!syncHover}- onCheckedChange={setSyncTooltip}- />- </div>- <p className="text-xs text-foreground-light mt-1">- When enabled, also shows tooltips on all charts.{' '}- <span className={cn(syncHover ? 'text-foreground-light' : 'text-foreground')}>- Requires header sync.- </span>+ </PopoverTrigger>+ <PopoverContent align="center" side="bottom" className="w-64 p-3 flex flex-col gap-y-4">+ <div className="flex items-start justify-between space-x-2">+ <Label htmlFor="sync-hover" className="text-xs">+ <p>Sync chart headers</p>+ <p className="text-xs text-foreground-light mt-1 text-balance">+ Hovering over any chart will update headers across all charts</p></Label>+ <Switch id="sync-hover" checked={syncHover} onCheckedChange={setSyncHover} /></div>- </DropdownMenuContent>- </DropdownMenu>++ {syncHover && (+ <div className="flex items-start justify-between space-x-2">+ <Label htmlFor="sync-tooltips" className="text-xs">+ <p>Sync tooltips</p>+ <p className="text-xs text-foreground-light mt-1 text-balance">+ Shows tooltips on all charts+ </p>+ </Label>+ <Switch+ id="sync-tooltips"+ checked={syncTooltip}+ disabled={!syncHover}+ onCheckedChange={setSyncTooltip}+ />+ </div>+ )}+ </PopoverContent>+ </Popover>)}